From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1AF55ECAAD1 for ; Wed, 31 Aug 2022 14:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lm91+hVl/9Fjx2qc/RD/YknNWxuP5gJoi0IX6Xsicis=; b=PK7vsULwYD0mYo Q0ea1WwLwQK4gX/05K0acDWInPwNpExuBQEZA2u0sIT/EVVPRCMpXHKNdvPucwhMa6X+pdLqnzdKe G0Dyj7RX5BqXHvCM6yQyD23iID45uKzL3CZr2Zsvh7dnyzDmQExsYQqA+jcgwz647fm3vcL+LBMF6 U5ZCJJHjlY62qbsX3uC2dLFJFt6rDCN+8Ku9wuQIcK7DLMqMzQ9lFmn1mktfi/g3E7p4LQnipHUPU 2JMuYtBiM/zmftEvNIfkF4Q3pOnYsco1zZTN4iJs5b0Basz5hyVSQ9y8tBNYqxfYHLXoDvORn4ZG7 8MPZVKCYngXl7IKhQLiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTObF-006gR4-5S; Wed, 31 Aug 2022 14:21:49 +0000 Received: from netrider.rowland.org ([192.131.102.5]) by bombadil.infradead.org with smtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTOb8-006gOs-FM for linux-arm-kernel@lists.infradead.org; Wed, 31 Aug 2022 14:21:44 +0000 Received: (qmail 191439 invoked by uid 1000); 31 Aug 2022 10:21:36 -0400 Date: Wed, 31 Aug 2022 10:21:36 -0400 From: Alan Stern To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, kernel test robot , Ard Biesheuvel , Krzysztof Kozlowski , Alim Akhtar , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: hcd: remove unused hcd_name variables Message-ID: References: <20220831073032.1409291-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220831073032.1409291-1-gregkh@linuxfoundation.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220831_072142_678145_7DF13DCF X-CRM114-Status: GOOD ( 14.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 31, 2022 at 09:30:32AM +0200, Greg Kroah-Hartman wrote: > In the commit 10174220f55a ("usb: reduce kernel log spam on driver > registration") a lot of unneeded kernel log messages were removed, but > that caused a few build warnings to show up where the variable > `hcd_name` was being set but never used anymore. > > Resolve this by just removing these variables as they are not needed > anymore > > Reported-by: kernel test robot > Cc: Ard Biesheuvel > Cc: Alan Stern > Cc: Krzysztof Kozlowski > Cc: Alim Akhtar > Cc: Rob Herring > Cc: linux-usb@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration") > Signed-off-by: Greg Kroah-Hartman > --- > drivers/usb/host/ehci-exynos.c | 1 - > drivers/usb/host/ehci-platform.c | 2 -- > drivers/usb/host/ohci-platform.c | 2 -- > 3 files changed, 5 deletions(-) This isn't enough, as you can see from this kernel test robot excerpt: clang_recent_errors |-- arm-s5pv210_defconfig | |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name | `-- drivers-usb-host-ohci-exynos.c:warning:unused-variable-hcd_name |-- hexagon-randconfig-r024-20220830 | |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ehci-orion.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ehci-spear.c:warning:unused-variable-hcd_name | `-- drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name |-- hexagon-randconfig-r036-20220830 | |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ehci-npcm7xx.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ehci-st.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ohci-at91.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ohci-s3c2410.c:warning:unused-variable-hcd_name | |-- drivers-usb-host-ohci-spear.c:warning:unused-variable-hcd_name | `-- drivers-usb-host-ohci-st.c:warning:unused-variable-hcd_name Yes, it has duplicates and your patch handles some of these. But there are others that still need to be fixed. Also, this list is missing ohci-pxa27x.c. Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel