From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51786ECAAD4 for ; Fri, 26 Aug 2022 22:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/UNxA/zjhPDbmjYg11TIqvRO1mbUh3HtBTaudQklEWM=; b=ztokBBGzaZPB02 VCRHUqR55cNujDqMNKDt1rO8Jfv0IT5Mfbf2cWD5pqc8WGKiDULZ9HCsdXV5c2Qug+E5HqmCATH6R bt3OOJZ1A0dQu1bDjE2jmK2lKqs/DbXPSiJkq2r8UszBAs6H4CjELRPkRA0ouetCUfkJhOikIvVmp m1moZhcy5GNJ116QIOK0sPGtwYKbMpZgCYNdImT20ccEgO+/YSJoL88rUc8t5oPCXAExXzUX5Efey et6CVnrwRqggouq1k0IVhxBNKZUwuRUJtZ1wkCJ4ERH8czhvchOJK3vqJ36Y7cYVOKacOiQ6fnJZn 5/qugVcq3zVZmJ27CqJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRhpE-00EJbc-QU; Fri, 26 Aug 2022 22:29:16 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oRhpB-00EJXY-Pf for linux-arm-kernel@lists.infradead.org; Fri, 26 Aug 2022 22:29:15 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 9226930B; Sat, 27 Aug 2022 00:29:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1661552950; bh=WSO4BBqN3kAWRsPaZun6o5Wyzwiloi0fiRjTiQQBlps=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZJ/MZVSjHVesGFLeABJ156fSAsMDk2Gn7VYBrjHsJdNC1biGU22sCrNqX3H/EXQgU 83xshZaVXR+NhZBHx9vOdxNY4MD+VvtaI9puOcnP2JorV8Ue/IRvzXuZUsqRpsOfmD vooI9CLbNB83gCAH3wclj8tqanWGKIz+mxyv11Jc= Date: Sat, 27 Aug 2022 01:29:03 +0300 From: Laurent Pinchart To: Paul Kocialkowski Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Sakari Ailus , Hans Verkuil , Maxime Ripard , Thomas Petazzoni , Rob Herring Subject: Re: [PATCH v6 2/6] dt-bindings: media: sun6i-a31-csi: Add ISP output port Message-ID: References: <20220826184144.605605-1-paul.kocialkowski@bootlin.com> <20220826184144.605605-3-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220826184144.605605-3-paul.kocialkowski@bootlin.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220826_152914_009202_AFB8AC50 X-CRM114-Status: GOOD ( 16.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, Thank you for the patch. On Fri, Aug 26, 2022 at 08:41:40PM +0200, Paul Kocialkowski wrote: > Some Allwinner devices come with an Image Signal Processor (ISP) that > allows processing camera data to produce good-looking images, > especially from raw bayer representations. > > The ISP does not have a dedicated capture path: it is fed directly by > one of the CSI controllers, which can be selected at run-time. > > Represent this possibility as a graph connection between the CSI > controller and the ISP in the device-tree bindings. > > Signed-off-by: Paul Kocialkowski > Acked-by: Rob Herring > --- > .../devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > index 8551c4a711dc..54eb80e517e3 100644 > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml > @@ -73,6 +73,10 @@ properties: > $ref: /schemas/graph.yaml#/properties/port > description: MIPI CSI-2 bridge input port > > + port@2: > + $ref: /schemas/graph.yaml#/properties/port > + description: ISP output port > + I'd write "Output port to the ISP" to make it clearer. Reviewed-by: Laurent Pinchart > anyOf: > - required: > - port@0 -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel