From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60F69ECAAD3 for ; Thu, 1 Sep 2022 14:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G/mp1mwt2HHm645xbkQMGe/I/sjdknQcbge9WP9RC2g=; b=oOhuEQYfm3cAMy ZeYnfcsRiDIgVUeogZem2k4XR+1fdUJrErs4IZ3rBRHdqz0vrMFAX4by7aGVMFmUBasIjePOatmDq hPGO2Hzee4lQLbSvFi6PIWI8B/4yQqk98AzNLK68CslIIJb7f/ecM7QR1NXOzt0SOZUx69Y8vNr3B 8MqcIkf7uh1ZnF1+8SPhx++dvYXXY4IShgahk3He8N4dd+zXljpjzDCqccbFCNXC8CQZsMBRTaYEE SR+xTNZdnmJlViS0t5UQBRSzjDgpvA2I85soYpQXn9anRdY9uNyUhZqzl+UVezhjoAPOMerh4tIE6 F8cALtMYcVyfOy+whozw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTl4c-00CSEv-LJ; Thu, 01 Sep 2022 14:21:38 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTl4W-00CSAc-KR for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 14:21:35 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B4846CD; Thu, 1 Sep 2022 16:21:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1662042088; bh=A5gkBR9bPfI62fiXWS9MBQdkIPuX3rhZB6oxYtEU7sc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UpYA6BFhSUdU8txv9sZ2xFyWokhbwkCjKKCPikq1hPctQaIdop/y9Nj3Jl5fR5sVJ kzTb1dap0tPiMNh+RDtJUVq8vTpicd2AvWEzo0dXqKbNhE6Iwc7TzOVnRdR4auWExG ty4J+5/QDmMW8XyiY1cCWC9TbkvdSB4NFvSN6dxg= Date: Thu, 1 Sep 2022 17:21:16 +0300 From: Laurent Pinchart To: Paul Kocialkowski Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Rob Herring , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Michael Turquette , Stephen Boyd , Frank Rowand , Maxime Ripard , Thomas Petazzoni Subject: Re: [PATCH v5 5/6] ARM: dts: sun8i: a83t: Add MIPI CSI-2 controller node Message-ID: References: <20220826182803.604563-1-paul.kocialkowski@bootlin.com> <20220826182803.604563-6-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_072132_915259_AB2EF807 X-CRM114-Status: GOOD ( 35.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 01, 2022 at 04:04:40PM +0200, Paul Kocialkowski wrote: > Hi Laurent, > > On Fri 26 Aug 22, 21:59, Laurent Pinchart wrote: > > Hi Paul, > > > > Thank you for the patch. > > > > On Fri, Aug 26, 2022 at 08:28:02PM +0200, Paul Kocialkowski wrote: > > > MIPI CSI-2 is supported on the A83T with a dedicated controller that > > > covers both the protocol and D-PHY. It can be connected to the CSI > > > interface as a V4L2 subdev through the fwnode graph. > > > > > > This is not done by default since connecting the bridge without a > > > subdev attached to it will cause a failure on the CSI driver. > > > > No urgency, but would it be possible to fix this so that the CSI-2 > > receiver can be connected to the CSI unconditionally in DT ? The > > connection exists at the hardware level in the SoC, and should thus > > exist here too, regardless of whether or not a sensor is connected. > > Yes it's true that having the link always would be legitimate. > > For the context, this CSI controller can be switched between the MIPI CSI-2 > controller and a parallel sensor input (i.e. it's not dedicated to one or the > other like on the V3). > > Last time I tried, having the connection between the two always there resulted > in the unability to use a parallel sensor when no sensor is attached to the > mipi csi-2 receiver. Probably because the async notifier never completes since > the mipi csi-2's subdev is never registered without a sensor subdev attached. > > Do you see a way to handle this case properly? It sounds like an issue in the CSI-2 receiver driver. If there's no input device attached to it, it should register its subdev directly, without its own async notifier. > > > Signed-off-by: Paul Kocialkowski > > > --- > > > arch/arm/boot/dts/sun8i-a83t.dtsi | 26 ++++++++++++++++++++++++++ > > > 1 file changed, 26 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi > > > index 82fdb04122ca..ecf9f3b2c0c0 100644 > > > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi > > > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi > > > @@ -1064,6 +1064,32 @@ csi: camera@1cb0000 { > > > status = "disabled"; > > > }; > > > > > > + mipi_csi2: csi@1cb1000 { > > > + compatible = "allwinner,sun8i-a83t-mipi-csi2"; > > > + reg = <0x01cb1000 0x1000>; > > > + interrupts = ; > > > + clocks = <&ccu CLK_BUS_CSI>, > > > + <&ccu CLK_CSI_SCLK>, > > > + <&ccu CLK_MIPI_CSI>, > > > + <&ccu CLK_CSI_MISC>; > > > + clock-names = "bus", "mod", "mipi", "misc"; > > > + resets = <&ccu RST_BUS_CSI>; > > > + status = "disabled"; > > > + > > > + ports { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + mipi_csi2_in: port@0 { > > > + reg = <0>; > > > + }; > > > + > > > + mipi_csi2_out: port@1 { > > > + reg = <1>; > > > + }; > > > + }; > > > + }; > > > + > > > hdmi: hdmi@1ee0000 { > > > compatible = "allwinner,sun8i-a83t-dw-hdmi"; > > > reg = <0x01ee0000 0x10000>; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel