From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A90A8C64991 for ; Thu, 1 Sep 2022 13:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MeHxCvh3Y7BXoBulph4pm/w1UzW2fV9BajOnd692r+A=; b=hWJ4b5oQv+ekpC bdBARM8mK3YOUV4G5In0VgWUFSZjQSjjUUFCKp2kSeBl85BrVFSDnyLC3+/7vKL1Lj66+K6wLCvvQ WZrbEYAYWabMIa/Klp2AS7+brd/OOtpwcPIg0K1jHHxwAhtZnJ4CM8bU8yyeCD4d1luFWd/5AXmZG 4+lncfAgIQmmZ/DcAGQMagAZLVmu6rn5t1T9WgWFkwnFPPPZJjLrgtGGkBWJH9tDi+JzPP8Parkc9 LC5TWeF/QM3+tDQsleMys623dPycQ7GcJVxhikGHC7l0IHh6+7Sx8fmKTBSdcPywGH5FIB9MhxvFz 6Bekpqju13BcLEbJ/pcw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTkdY-00CEcv-5E; Thu, 01 Sep 2022 13:53:40 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTkdU-00CEbp-Ps for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 13:53:38 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C53361728; Thu, 1 Sep 2022 13:53:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 22043C433C1; Thu, 1 Sep 2022 13:53:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1662040415; bh=maj09gBjgscBkimh9rmhEf4vQtAIsp/gFrKj8Dk/SMc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ER2mMSX7WIaCZk/ViG3Pj/CXpVATHmCLMeUgxwozwckOUik86kZiChQGC5NXMWbiH tdbW3Q7tw30yl6Cjj93D+UPPSpteRSzWpPtQffjN1j67unQtAigqeIlv+GJOImfge1 pYWvbaUeXE+OnfhgRW5GDYdh6TkP25Xy8w+lNnyc= Date: Thu, 1 Sep 2022 15:53:32 +0200 From: Greg Kroah-Hartman To: Alan Stern Cc: linux-usb@vger.kernel.org, kernel test robot , Ard Biesheuvel , Krzysztof Kozlowski , Alim Akhtar , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: hcd: remove unused hcd_name variables Message-ID: References: <20220831073032.1409291-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_065336_945921_611ED408 X-CRM114-Status: GOOD ( 21.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 31, 2022 at 10:21:36AM -0400, Alan Stern wrote: > On Wed, Aug 31, 2022 at 09:30:32AM +0200, Greg Kroah-Hartman wrote: > > In the commit 10174220f55a ("usb: reduce kernel log spam on driver > > registration") a lot of unneeded kernel log messages were removed, but > > that caused a few build warnings to show up where the variable > > `hcd_name` was being set but never used anymore. > > > > Resolve this by just removing these variables as they are not needed > > anymore > > > > Reported-by: kernel test robot > > Cc: Ard Biesheuvel > > Cc: Alan Stern > > Cc: Krzysztof Kozlowski > > Cc: Alim Akhtar > > Cc: Rob Herring > > Cc: linux-usb@vger.kernel.org > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: linux-samsung-soc@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Fixes: 10174220f55a ("usb: reduce kernel log spam on driver registration") > > Signed-off-by: Greg Kroah-Hartman > > --- > > drivers/usb/host/ehci-exynos.c | 1 - > > drivers/usb/host/ehci-platform.c | 2 -- > > drivers/usb/host/ohci-platform.c | 2 -- > > 3 files changed, 5 deletions(-) > > This isn't enough, as you can see from this kernel test robot excerpt: > > clang_recent_errors > |-- arm-s5pv210_defconfig > | |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name > | `-- drivers-usb-host-ohci-exynos.c:warning:unused-variable-hcd_name > |-- hexagon-randconfig-r024-20220830 > | |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name > | |-- drivers-usb-host-ehci-exynos.c:warning:unused-variable-hcd_name > | |-- drivers-usb-host-ehci-orion.c:warning:unused-variable-hcd_name > | |-- > drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name > | |-- drivers-usb-host-ehci-spear.c:warning:unused-variable-hcd_name > | `-- > drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name > |-- hexagon-randconfig-r036-20220830 > | |-- drivers-usb-host-ehci-atmel.c:warning:unused-variable-hcd_name > | |-- drivers-usb-host-ehci-npcm7xx.c:warning:unused-variable-hcd_name > | |-- > drivers-usb-host-ehci-platform.c:warning:unused-variable-hcd_name > | |-- drivers-usb-host-ehci-st.c:warning:unused-variable-hcd_name > | |-- drivers-usb-host-ohci-at91.c:warning:unused-variable-hcd_name > | |-- > drivers-usb-host-ohci-platform.c:warning:unused-variable-hcd_name > | |-- drivers-usb-host-ohci-s3c2410.c:warning:unused-variable-hcd_name > | |-- drivers-usb-host-ohci-spear.c:warning:unused-variable-hcd_name > | `-- drivers-usb-host-ohci-st.c:warning:unused-variable-hcd_name > > Yes, it has duplicates and your patch handles some of these. But there > are others that still need to be fixed. Also, this list is missing > ohci-pxa27x.c. Ick, ok, I went off of a different kbuild report. Let me fix this up later today... greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel