From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 494BDECAAD1 for ; Thu, 1 Sep 2022 18:15:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zzY/wo9ZKW2L62+NHQ/ibWnUk0I0bYqIWA/YRQMEbLc=; b=EkK1D6Qqx0XMNB P42Ak2frVZDpPWG/HUN+TYvjjWvuk6/pagy9a/isfkrLWZdZO2vj0U9KPevLECPHUG41/75KFi/S/ fqhYz6PQLSaVPLfO6Ydnv5FVrcQhn+NSmn0iZa64IPdQF5bHSkgoD9VNoot/HczpZXbLO2CnPPBBj ICXPZGdPjGwmOxy+V+yo9TNq/+L2hczQUkVkyjYiv0GzCeggZJiihllphmNQqZEYUCC/nSLyQayDN lHdqTgsWaOvP9H+AY6KXAdXC0Vu4kOWLzH39b9TwB5q2bmPO7t7/b2vgQ95o+QlZRVTzmssjvkrKr +mCKZ55iy9l14+uUPK5w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTohX-00Dquc-4l; Thu, 01 Sep 2022 18:14:03 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oToeE-00DpO0-H8 for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 18:10:40 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BF7E06CD; Thu, 1 Sep 2022 20:10:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1662055837; bh=yisMqaoWBDsbWebXqcpHBHBjvKY6q+kjKiEmjB4kfeo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LzKug78Jh6jAwH5sL52x6kMBrm941Z72a6IYapStVAuwe5lJ92fR5S4wTK6jAZWKc 1ziH80WGYihPVFmtuqImuWOKECc6zGrlG23uVu9B46N0MuL3zuh0Ls5W6W0U4eH8xM cua6gl/RILJerjkUSreHo/7jOnJ1tM7++0dn0qf4= Date: Thu, 1 Sep 2022 21:10:25 +0300 From: Laurent Pinchart To: Max Krummenacher Cc: Max Krummenacher , Fabio Estevam , Krzysztof Kozlowski , Marcel Ziswiler , NXP Linux Team , Pengutronix Kernel Team , Philippe Schenker , Rob Herring , Sascha Hauer , Shawn Guo , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: imx8mp-verdin: add dsi to lvds functionality Message-ID: References: <20220901154051.1885509-1-max.oss.09@gmail.com> <20220901154051.1885509-2-max.oss.09@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220901154051.1885509-2-max.oss.09@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_111038_784464_D1558721 X-CRM114-Status: GOOD ( 18.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Max, Thank you for the patch. On Thu, Sep 01, 2022 at 05:40:51PM +0200, Max Krummenacher wrote: > From: Max Krummenacher > > Add a panel-lvds node and use the correct dsi to lvds chip name. > Both to be later extended in a dt overlay according to the exact > board HW configuration. Same as with patch 1/2, this doesn't look right. The panel isn't part of the Verdin SoM, it's not even part of the base board. It should be moved to an overlay, and the SN65DSI83, which I understand isn't on the SoM either, should be moved somewhere else too.. > Signed-off-by: Max Krummenacher > --- > > arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > index bd84a0d135dc..a3e20c7add3e 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi > @@ -67,6 +67,13 @@ hdmi_connector: hdmi-connector { > status = "disabled"; > }; > > + panel_lvds: panel-lvds { > + compatible = "panel-lvds"; > + backlight = <&backlight>; > + data-mapping = "vesa-24"; > + status = "disabled"; > + }; > + > /* Carrier Board Supplies */ > reg_1p8v: regulator-1p8v { > compatible = "regulator-fixed"; > @@ -690,8 +697,8 @@ gpio_expander_21: gpio-expander@21 { > status = "disabled"; > }; > > - lvds_ti_sn65dsi83: bridge@2c { > - compatible = "ti,sn65dsi83"; > + lvds_ti_sn65dsi84: bridge@2c { > + compatible = "ti,sn65dsi84"; > /* Verdin GPIO_9_DSI (SN65DSI84 IRQ, SODIMM 17, unused) */ > /* Verdin GPIO_10_DSI (SODIMM 21) */ > enable-gpios = <&gpio4 28 GPIO_ACTIVE_HIGH>; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel