* [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on
@ 2022-09-01 11:04 Max Krummenacher
2022-09-01 18:29 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Max Krummenacher @ 2022-09-01 11:04 UTC (permalink / raw)
To: Max Krummenacher
Cc: Fabio Estevam, Krzysztof Kozlowski, Laurent Pinchart,
Marcel Ziswiler, NXP Linux Team, Pengutronix Kernel Team,
Philippe Schenker, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, linux-arm-kernel, linux-kernel
From: Max Krummenacher <max.krummenacher@toradex.com>
These regulators are switched on by HW during power up and can not
be influenced by SW.
Set the always-on property.
Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
---
arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
index 557cfef8f049..76cc89296150 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
@@ -62,6 +62,7 @@ button-wakeup {
/* Carrier Board Supplies */
reg_1p8v: regulator-1p8v {
compatible = "regulator-fixed";
+ regulator-always-on;
regulator-max-microvolt = <1800000>;
regulator-min-microvolt = <1800000>;
regulator-name = "+V1.8_SW";
@@ -69,6 +70,7 @@ reg_1p8v: regulator-1p8v {
reg_3p3v: regulator-3p3v {
compatible = "regulator-fixed";
+ regulator-always-on;
regulator-max-microvolt = <3300000>;
regulator-min-microvolt = <3300000>;
regulator-name = "+V3.3_SW";
@@ -76,6 +78,7 @@ reg_3p3v: regulator-3p3v {
reg_5p0v: regulator-5p0v {
compatible = "regulator-fixed";
+ regulator-always-on;
regulator-max-microvolt = <5000000>;
regulator-min-microvolt = <5000000>;
regulator-name = "+V5_SW";
--
2.35.3
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on
2022-09-01 11:04 [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on Max Krummenacher
@ 2022-09-01 18:29 ` Laurent Pinchart
2022-09-01 18:44 ` Mark Brown
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2022-09-01 18:29 UTC (permalink / raw)
To: Max Krummenacher
Cc: Max Krummenacher, Fabio Estevam, Krzysztof Kozlowski,
Marcel Ziswiler, NXP Linux Team, Pengutronix Kernel Team,
Philippe Schenker, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, linux-arm-kernel, linux-kernel, Liam Girdwood,
Mark Brown
Hi Max,
(CC'ing Mark and Liam)
Thank you for the patch.
On Thu, Sep 01, 2022 at 01:04:22PM +0200, Max Krummenacher wrote:
> From: Max Krummenacher <max.krummenacher@toradex.com>
>
> These regulators are switched on by HW during power up and can not
> be influenced by SW.
> Set the always-on property.
Is this needed ? When a fixed regulator has no control GPIO or clock, as
is the case here, I would expect the driver and/or regulator core to
understand that it's always on, as the alternative is always-off, which
is pointless :-) Mark, Liam, what do you think ?
> Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
>
> ---
>
> arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> index 557cfef8f049..76cc89296150 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi
> @@ -62,6 +62,7 @@ button-wakeup {
> /* Carrier Board Supplies */
> reg_1p8v: regulator-1p8v {
> compatible = "regulator-fixed";
> + regulator-always-on;
> regulator-max-microvolt = <1800000>;
> regulator-min-microvolt = <1800000>;
> regulator-name = "+V1.8_SW";
> @@ -69,6 +70,7 @@ reg_1p8v: regulator-1p8v {
>
> reg_3p3v: regulator-3p3v {
> compatible = "regulator-fixed";
> + regulator-always-on;
> regulator-max-microvolt = <3300000>;
> regulator-min-microvolt = <3300000>;
> regulator-name = "+V3.3_SW";
> @@ -76,6 +78,7 @@ reg_3p3v: regulator-3p3v {
>
> reg_5p0v: regulator-5p0v {
> compatible = "regulator-fixed";
> + regulator-always-on;
> regulator-max-microvolt = <5000000>;
> regulator-min-microvolt = <5000000>;
> regulator-name = "+V5_SW";
--
Regards,
Laurent Pinchart
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on
2022-09-01 18:29 ` Laurent Pinchart
@ 2022-09-01 18:44 ` Mark Brown
2022-09-02 12:50 ` Francesco Dolcini
0 siblings, 1 reply; 4+ messages in thread
From: Mark Brown @ 2022-09-01 18:44 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Max Krummenacher, Max Krummenacher, Fabio Estevam,
Krzysztof Kozlowski, Marcel Ziswiler, NXP Linux Team,
Pengutronix Kernel Team, Philippe Schenker, Rob Herring,
Sascha Hauer, Shawn Guo, devicetree, linux-arm-kernel,
linux-kernel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 673 bytes --]
On Thu, Sep 01, 2022 at 09:29:13PM +0300, Laurent Pinchart wrote:
> On Thu, Sep 01, 2022 at 01:04:22PM +0200, Max Krummenacher wrote:
> > From: Max Krummenacher <max.krummenacher@toradex.com>
> > These regulators are switched on by HW during power up and can not
> > be influenced by SW.
> > Set the always-on property.
>
> Is this needed ? When a fixed regulator has no control GPIO or clock, as
> is the case here, I would expect the driver and/or regulator core to
> understand that it's always on, as the alternative is always-off, which
> is pointless :-) Mark, Liam, what do you think ?
If there's no physical control setting always-on does nothing.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on
2022-09-01 18:44 ` Mark Brown
@ 2022-09-02 12:50 ` Francesco Dolcini
0 siblings, 0 replies; 4+ messages in thread
From: Francesco Dolcini @ 2022-09-02 12:50 UTC (permalink / raw)
To: Mark Brown, Laurent Pinchart, Max Krummenacher
Cc: Max Krummenacher, Fabio Estevam, Krzysztof Kozlowski,
Marcel Ziswiler, NXP Linux Team, Pengutronix Kernel Team,
Philippe Schenker, Rob Herring, Sascha Hauer, Shawn Guo,
devicetree, linux-arm-kernel, linux-kernel, Liam Girdwood
On Thu, Sep 01, 2022 at 07:44:43PM +0100, Mark Brown wrote:
> On Thu, Sep 01, 2022 at 09:29:13PM +0300, Laurent Pinchart wrote:
> > On Thu, Sep 01, 2022 at 01:04:22PM +0200, Max Krummenacher wrote:
> > > From: Max Krummenacher <max.krummenacher@toradex.com>
>
> > > These regulators are switched on by HW during power up and can not
> > > be influenced by SW.
> > > Set the always-on property.
> >
> > Is this needed ? When a fixed regulator has no control GPIO or clock, as
> > is the case here, I would expect the driver and/or regulator core to
> > understand that it's always on, as the alternative is always-off, which
> > is pointless :-) Mark, Liam, what do you think ?
>
> If there's no physical control setting always-on does nothing.
The patch was posted because of a warning on trying to disable an unused
regulator.
However this was changed with
261f06315cf7 ("regulator: Flag uncontrollable regulators as always_on").
Max was testing with a kernel without this patch in and forgot to verify
on latest upstream kernel.
Just disregard this.
Francesco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-09-02 12:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-01 11:04 [PATCH] arm64: dts: imx8mp-verdin: board regulators: add always-on Max Krummenacher
2022-09-01 18:29 ` Laurent Pinchart
2022-09-01 18:44 ` Mark Brown
2022-09-02 12:50 ` Francesco Dolcini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).