From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v6 2/6] dt-bindings: media: sun6i-a31-csi: Add ISP output port
Date: Thu, 1 Sep 2022 16:57:25 +0200 [thread overview]
Message-ID: <YxDIVZALmaIo/Y6X@aptenodytes> (raw)
In-Reply-To: <YwlJL3umZrVC4FLc@pendragon.ideasonboard.com>
[-- Attachment #1.1: Type: text/plain, Size: 1948 bytes --]
Hi Laurent,
On Sat 27 Aug 22, 01:29, Laurent Pinchart wrote:
> Hi Paul,
>
> Thank you for the patch.
Thanks for the review!
> On Fri, Aug 26, 2022 at 08:41:40PM +0200, Paul Kocialkowski wrote:
> > Some Allwinner devices come with an Image Signal Processor (ISP) that
> > allows processing camera data to produce good-looking images,
> > especially from raw bayer representations.
> >
> > The ISP does not have a dedicated capture path: it is fed directly by
> > one of the CSI controllers, which can be selected at run-time.
> >
> > Represent this possibility as a graph connection between the CSI
> > controller and the ISP in the device-tree bindings.
> >
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > .../devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> > index 8551c4a711dc..54eb80e517e3 100644
> > --- a/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> > +++ b/Documentation/devicetree/bindings/media/allwinner,sun6i-a31-csi.yaml
> > @@ -73,6 +73,10 @@ properties:
> > $ref: /schemas/graph.yaml#/properties/port
> > description: MIPI CSI-2 bridge input port
> >
> > + port@2:
> > + $ref: /schemas/graph.yaml#/properties/port
> > + description: ISP output port
> > +
>
> I'd write "Output port to the ISP" to make it clearer.
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Agreed, thanks!
Paul
> > anyOf:
> > - required:
> > - port@0
>
> --
> Regards,
>
> Laurent Pinchart
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-01 14:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 18:41 [PATCH v6 0/6] Allwinner A31/A83T MIPI CSI-2 and A31 ISP / ISP Driver Paul Kocialkowski
2022-08-26 18:41 ` [PATCH v6 1/6] dt-bindings: media: Add Allwinner A31 ISP bindings documentation Paul Kocialkowski
2022-08-26 21:12 ` Laurent Pinchart
2022-09-01 15:03 ` Paul Kocialkowski
2022-09-01 18:12 ` Laurent Pinchart
2022-08-26 18:41 ` [PATCH v6 2/6] dt-bindings: media: sun6i-a31-csi: Add ISP output port Paul Kocialkowski
2022-08-26 22:29 ` Laurent Pinchart
2022-09-01 14:57 ` Paul Kocialkowski [this message]
2022-08-26 18:41 ` [PATCH v6 3/6] staging: media: Add support for the Allwinner A31 ISP Paul Kocialkowski
2022-08-26 18:41 ` [PATCH v6 4/6] MAINTAINERS: Add entry for the Allwinner A31 ISP driver Paul Kocialkowski
2022-08-26 22:30 ` Laurent Pinchart
2022-08-26 18:41 ` [PATCH v6 5/6] media: sun6i-csi: Detect the availability of the ISP Paul Kocialkowski
2022-08-26 22:39 ` Laurent Pinchart
2022-09-01 15:11 ` Paul Kocialkowski
2022-09-01 18:14 ` Laurent Pinchart
2022-08-26 18:41 ` [PATCH v6 6/6] media: sun6i-csi: Add support for hooking to the isp devices Paul Kocialkowski
2022-08-26 22:44 ` Laurent Pinchart
2022-09-01 14:55 ` Paul Kocialkowski
2022-09-01 18:17 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YxDIVZALmaIo/Y6X@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=linux-sunxi@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=samuel@sholland.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).