From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A9D4AECAAD1 for ; Thu, 1 Sep 2022 16:48:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O6ktyH0a/mLgFug5CDUvv6pLFYMDcdx3L57xhnvw8TQ=; b=qOdrHrXdu6Bdxg T95282cyPfxP/hYU0J2wGFsKjOpLwEHxyT85wqZsx4pgv3A20zahYKA87ho9+/7G0xxhAxQh+xTa4 ksYSnTY4myykZ92Bf+GJvkyY1BLsRTDSmhJlFYTfh6ecnCmAhfHF/DN/Q5xTu42lG3JH1sU1+AWL3 ozbuKBo2eezs0QZcysyQmyDKs7/RQ+/niIJWoxdTJ9whl9/GCxmRxS/B1hfrc6I93b4AO5GmmnqhC SisoGzFzAjbOr6s4tPXHpefPY2mVvzpRiovBQl66LeFPRJ9zbngYne3mPWW5voINlETPwYZudlFo9 I5XFGc0tr/9Lqy30IVJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTnLc-00DPyN-7g; Thu, 01 Sep 2022 16:47:20 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTnLX-00DPwD-Ri for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 16:47:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=W3O+xqsQoDS/3T7c0b2c2tsv+0Mvz/bo8Rn3y7uzjGI=; b=C/NeG9Wwc+f4CQtNRwJHx9O/5r 9rR6E+eKH9pnWdiSk1+xcF/h1mfmzlX+VOajEfaIfLLpxH3AggR08fcZ4t0qV3dm9CUA0JE7c1H3m djKAQjTCzxmHxu2nohfLG6LtiGG+DfHf4Lt8osN0RVfCG68n3QZTRyeaxLk/bXeiToyJQ7+05jUZp Gs+SAIaZnDqyi3+jpMw40Km2TSRSMtfuGLNmLEI0fv4XJSflI8aoP81xPadMEJ7hmpKoVEuru3NC8 y71Ulz5JkRZZ2q/r0vKORvpOQL7zX4k815j6eOIZf++l1HO4DQ+vA/eKsyC11Zg4Em9Kdge0zGgTA HVWLu05Q==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34050) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oTnLL-0006EO-IG; Thu, 01 Sep 2022 17:47:03 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1oTnLI-0003cg-GY; Thu, 01 Sep 2022 17:47:00 +0100 Date: Thu, 1 Sep 2022 17:47:00 +0100 From: "Russell King (Oracle)" To: Krzysztof Kozlowski Cc: Arnd Bergmann , Lee Jones , Linus Walleij , Alyssa Rosenzweig , asahi@lists.linux.dev, Bartosz Golaszewski , Hector Martin , linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, Sven Peter , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org Subject: Re: [PATCH 1/6] dt-bindings: mfd: add binding for Apple Mac System Management Controller Message-ID: References: <426469c1-13cc-178b-4904-09439d7788e8@linaro.org> <928ddeff-efac-920c-7bbf-dda35a942b93@linaro.org> <2fedff34-6a20-f1ce-a756-2bd8671fcd52@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_094715_918997_6734D935 X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 01, 2022 at 07:25:03PM +0300, Krzysztof Kozlowski wrote: > On 01/09/2022 18:56, Russell King (Oracle) wrote: > > > > 8<=== > > From: "Russell King (Oracle)" > > Subject: [PATCH] dt-bindings: mfd: add binding for Apple Mac System Management > > Controller > > > > Add a DT binding for the Apple Mac System Management Controller. > > > > Signed-off-by: Russell King (Oracle) > > Yes, looks good. > > I won't add Reviewed-by tag, because I think it would confuse Patchwork, > so please send a v2 at some point. Thanks. Do you have any suggestions for patch 2? Should I merge the description in patch 2 into this file? The full dts for this series looks like this: smc: smc@23e400000 { compatible = "apple,t8103-smc", "apple,smc"; reg = <0x2 0x3e400000 0x0 0x4000>, <0x2 0x3fe00000 0x0 0x100000>; reg-names = "smc", "sram"; mboxes = <&smc_mbox>; smc_gpio: gpio { gpio-controller; #gpio-cells = <2>; }; }; but the fuller version in the asahi linux tree looks like: smc: smc@23e400000 { compatible = "apple,t8103-smc", "apple,smc"; reg = <0x2 0x3e400000 0x0 0x4000>, <0x2 0x3fe00000 0x0 0x100000>; reg-names = "smc", "sram"; mboxes = <&smc_mbox>; smc_gpio: gpio { gpio-controller; #gpio-cells = <2>; }; smc_rtc: rtc { nvmem-cells = <&rtc_offset>; nvmem-cell-names = "rtc_offset"; }; smc_reboot: reboot { nvmem-cells = <&shutdown_flag>, <&boot_stage>, <&boot_error_count>, <&panic_count>, <&pm_setting>; nvmem-cell-names = "shutdown_flag", "boot_stage", "boot_error_count", "panic_count", "pm_setting"; }; }; So whatever is decided for the gpio node would eventually also apply to the other nodes too. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel