From: Andrew Lunn <andrew@lunn.ch>
To: Tao Ren <rentao.bupt@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Heyi Guo <guoheyi@linux.alibaba.com>,
Dylan Hung <dylan_hung@aspeedtech.com>,
Guangbin Huang <huangguangbin2@huawei.com>,
Liang He <windhl@126.com>, Hao Chen <chenhao288@hisilicon.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Tao Ren <taoren@fb.com>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net-next 2/2] ARM: dts: aspeed: elbert: Enable mac3 controller
Date: Tue, 6 Sep 2022 13:55:35 +0200 [thread overview]
Message-ID: <Yxc1N1auY5jk3yJI@lunn.ch> (raw)
In-Reply-To: <YxalTToannPyLQpI@taoren-fedora-PC23YAB4>
On Mon, Sep 05, 2022 at 06:41:33PM -0700, Tao Ren wrote:
> Hi Andrew,
>
> On Tue, Sep 06, 2022 at 02:22:50AM +0200, Andrew Lunn wrote:
> > On Mon, Sep 05, 2022 at 04:56:34PM -0700, rentao.bupt@gmail.com wrote:
> > > From: Tao Ren <rentao.bupt@gmail.com>
> > >
> > > Enable mac3 controller in Elbert dts: Elbert MAC3 is connected to the
> > > onboard switch directly (fixed link).
> >
> > What is the switch? Could you also add a DT node for it?
> >
> > >
> > > Signed-off-by: Tao Ren <rentao.bupt@gmail.com>
> > > ---
> > > arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts | 11 +++++++++++
> > > 1 file changed, 11 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts
> > > index 27b43fe099f1..52cb617783ac 100644
> > > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts
> > > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-elbert.dts
> > > @@ -183,3 +183,14 @@ imux31: i2c@7 {
> > > &i2c11 {
> > > status = "okay";
> > > };
> > > +
> > > +&mac3 {
> > > + status = "okay";
> > > + phy-mode = "rgmii";
> >
> > 'rgmii' is suspicious, though not necessarily wrong. This value is
> > normally passed to the PHY, so the PHY inserts the RGMII delay. You
> > however don't have a PHY. So i assume the switch is inserting the
> > delay? Again, being able to see the DT properties for the switch would
> > be useful.
> >
> > Andrew
>
> Thank you for the quick review!
>
> The BMC mac3 is connected to BCM53134P's IMP_RGMII port, and there is no
> PHY between BMC MAC and BCM53134P. BCM53134P loads configurations from
> its EEPROM when the chip is powered.
So i assume you have the switch RGMII port doing the delays. That is
fine.
> Could you please point me an example showing how to describe the switch in
> dts? Anyhow I will need to improve the patch description and comments in
> v2.
It looks like drivers/net/dsa/b53 does not support this particular
switch. You could consider extending the driver. See
Documentation/devicetree/bindings/net/dsa/brcm,b53.yaml
for documentation of the binding.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-06 11:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-05 23:56 [PATCH net-next 0/2] net: ftgmac100: support fixed link rentao.bupt
2022-09-05 23:56 ` [PATCH net-next 1/2] " rentao.bupt
2022-09-06 0:24 ` Andrew Lunn
2022-09-05 23:56 ` [PATCH net-next 2/2] ARM: dts: aspeed: elbert: Enable mac3 controller rentao.bupt
2022-09-06 0:22 ` Andrew Lunn
2022-09-06 1:41 ` Tao Ren
2022-09-06 11:55 ` Andrew Lunn [this message]
2022-09-06 17:05 ` Florian Fainelli
2022-09-06 23:35 ` Tao Ren
2022-09-07 0:36 ` Andrew Lunn
2022-09-07 1:08 ` Tao Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxc1N1auY5jk3yJI@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew@aj.id.au \
--cc=chenhao288@hisilicon.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dylan_hung@aspeedtech.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=guoheyi@linux.alibaba.com \
--cc=huangguangbin2@huawei.com \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rentao.bupt@gmail.com \
--cc=robh+dt@kernel.org \
--cc=taoren@fb.com \
--cc=windhl@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).