From: Greg KH <greg@kroah.com>
To: yee.lee@mediatek.com
Cc: linux-kernel@vger.kernel.org, patrick.wang.shcn@gmail.com,
stable@vger.kernel.org, Catalin Marinas <catalin.marinas@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH 5.15.y] Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()"
Date: Tue, 6 Sep 2022 14:08:51 +0200 [thread overview]
Message-ID: <Yxc4U/8zzfkHHv+W@kroah.com> (raw)
In-Reply-To: <20220906070309.18809-1-yee.lee@mediatek.com>
On Tue, Sep 06, 2022 at 03:03:06PM +0800, yee.lee@mediatek.com wrote:
> From: Yee Lee <yee.lee@mediatek.com>
>
> This reverts commit 23c2d497de21f25898fbea70aeb292ab8acc8c94.
>
> Commit 23c2d497de21 ("mm: kmemleak: take a full lowmem check in
> kmemleak_*_phys()") brought false leak alarms on some archs like arm64
> that does not init pfn boundary in early booting. The final solution
> lands on linux-6.0: commit 0c24e061196c ("mm: kmemleak: add rbtree and
> store physical address for objects allocated with PA").
>
> Revert this commit before linux-6.0. The original issue of invalid PA
> can be mitigated by additional check in devicetree.
>
> The false alarm report is as following: Kmemleak output: (Qemu/arm64)
> unreferenced object 0xffff0000c0170a00 (size 128):
> comm "swapper/0", pid 1, jiffies 4294892404 (age 126.208s)
> hex dump (first 32 bytes):
> 62 61 73 65 00 00 00 00 00 00 00 00 00 00 00 00 base............
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> backtrace:
> [<(____ptrval____)>] __kmalloc_track_caller+0x1b0/0x2e4
> [<(____ptrval____)>] kstrdup_const+0x8c/0xc4
> [<(____ptrval____)>] kvasprintf_const+0xbc/0xec
> [<(____ptrval____)>] kobject_set_name_vargs+0x58/0xe4
> [<(____ptrval____)>] kobject_add+0x84/0x100
> [<(____ptrval____)>] __of_attach_node_sysfs+0x78/0xec
> [<(____ptrval____)>] of_core_init+0x68/0x104
> [<(____ptrval____)>] driver_init+0x28/0x48
> [<(____ptrval____)>] do_basic_setup+0x14/0x28
> [<(____ptrval____)>] kernel_init_freeable+0x110/0x178
> [<(____ptrval____)>] kernel_init+0x20/0x1a0
> [<(____ptrval____)>] ret_from_fork+0x10/0x20
>
> This pacth is also applicable to linux-5.17.y/linux-5.18.y/linux-5.19.y
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Yee Lee <yee.lee@mediatek.com>
> ---
> mm/kmemleak.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
What is the git commit id of this change in Linus's tree?
And what about older stable trees with this commit in it?
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-06 12:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-06 7:03 [PATCH 5.15.y] Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()" yee.lee
2022-09-06 12:08 ` Greg KH [this message]
2022-09-07 8:37 ` Yee Lee (李建誼)
2022-09-08 17:06 ` Greg KH
2022-09-08 17:09 ` Patch "Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()"" has been added to the 4.9-stable tree gregkh
2022-09-08 17:09 ` Patch "Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()"" has been added to the 4.14-stable tree gregkh
2022-09-08 17:10 ` Patch "Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()"" has been added to the 4.19-stable tree gregkh
2022-09-08 17:10 ` Patch "Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()"" has been added to the 5.4-stable tree gregkh
2022-09-08 17:10 ` Patch "Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()"" has been added to the 5.10-stable tree gregkh
2022-09-08 17:10 ` Patch "Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()"" has been added to the 5.15-stable tree gregkh
2022-09-08 17:11 ` Patch "Revert "mm: kmemleak: take a full lowmem check in kmemleak_*_phys()"" has been added to the 5.19-stable tree gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yxc4U/8zzfkHHv+W@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=matthias.bgg@gmail.com \
--cc=patrick.wang.shcn@gmail.com \
--cc=stable@vger.kernel.org \
--cc=yee.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).