From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9B8A3ECAAD8 for ; Tue, 20 Sep 2022 13:40:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=74EYLsqNifOncX1VbDa+/nVEYBLzo1LrymdtYJ4TnMY=; b=BKchXNKW6dOcSk 7zczlD4XwNsr9KtO38aiF7LTSsq9fnIuO7+fo2ZJvRL16DUxvQOGQ2uMbuXFNvLA267FymhTQMt1Z W5FgkE3aRULckbDGrce2L6RA0VmlLIS8MshQTI8z+hMeQZKRrbQ7kjqtsm5+5VxTDCrj2HrP1hLZR unvk/l6I5QvyELvQIaGWFKBlIEa21W/+n6dlXoBGLpa5HSyQ+T4BuA3FC/+2tXJnaXWaQA+TpeJPO s1xLjRiEGQ1ohd54E80ipsfY4yTNXhAu2RJ66Han3p6kGyZlDakm6ewdHspGyLdrOlyb2WMu/CsLZ mZVyPNhQuu4AyQimZDgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oadTQ-0049X2-53; Tue, 20 Sep 2022 13:39:40 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oadTM-0049Tj-O3 for linux-arm-kernel@lists.infradead.org; Tue, 20 Sep 2022 13:39:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=3pIjUlJA919B9lQ4aUcTZDjl/ToQpR3Iu1q2qExlc+0=; b=RZSS9O3GRyd5jXE3KqsVzp/6ja w4m8lGQbeA2elwVVGEM4FwtLGj41wsYTWJU01DB3/dGo7oz+mIiJ307vyc0rZZf6FUXW6nV/IK3ih pWNCaYVxkQanbkWV34A7U42jndu60DeFADkyspOOmRFIy0w+IJ1b7pPZ9aKgoBWH4Ouk=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oadT4-00HH5w-0s; Tue, 20 Sep 2022 15:39:18 +0200 Date: Tue, 20 Sep 2022 15:39:18 +0200 From: Andrew Lunn To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Liam Girdwood , Mark Brown , Gregory Clement , Sebastian Hesselbarth , Marcin Wojtas , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/5] ASoC: kirkwood: enable Kirkwood driver for Armada 38x platforms Message-ID: References: <20220920132648.2008-1-pali@kernel.org> <20220920132648.2008-2-pali@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220920132648.2008-2-pali@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220920_063936_796151_9D799180 X-CRM114-Status: UNSURE ( 9.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > + if (of_device_is_compatible(np, "marvell,armada-380-audio")) { > + err = armada_38x_i2s_init_quirk(pdev, priv, soc_dai); > + /* Set initial pll frequency */ > + if (priv->pll_config) > + armada_38x_set_pll(priv->pll_config, 44100); > + if (err < 0) > + return err; A nitpick: It would be better to do the test for err before calling armada_38x_set_pll(), and then there is no need for the NULL check. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel