From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90861C433FE for ; Fri, 7 Oct 2022 07:41:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lPzQThxb5bu2pdT7hAP4JXqw5wg8B3SBjtDosQvufUk=; b=X2EYfqhwl2qLzH 0WzauHJL4tYDWXLEEOJM0VForGEXv55BA9pHXZhZrdmAWq0LszeeiDStVUFfAR0kDN9rA6SqAj2Nm KNsYE/qv6JLqHN6vt4PqIG8C76IMVKml5MQOYkiyVCUQRcF2RGjOAVfUPfuO2LZGhPVo0/OJIf4eh JVe7yBxqHm+OBfXiXmdhZeTJYFxDV6o88QMd/+oBR8uyCyTeOiQdoxW1k/Gv5bmqZawCKbotcWOFo dhGQuOrnx+/pT/Tl4Zf/tCDzVQxDlYABx/27GupDG/Fyfv58cN82upP1rPIypmQegSr+8zQL2SZsV iVnQuS2BaZwpAAkNKbLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oghxw-007wBy-FZ; Fri, 07 Oct 2022 07:40:16 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oghxs-007w7l-UA for linux-arm-kernel@lists.infradead.org; Fri, 07 Oct 2022 07:40:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D5BC61BE9; Fri, 7 Oct 2022 07:40:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7BCCEC433D6; Fri, 7 Oct 2022 07:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1665128411; bh=GKlx4XpC4V4eNmFalCE62eQxE/iy5Kh4EpFqqS1kpA4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GZ9K3KULO5a/jrGADpCK92s3OF1ZGtLpoouHlBzykdZSDl0a2f+PvoVCMOjyp6M1m gRhvzgyze5T4gAMbmuIN2Rbf55/EcfXwHIOLLEBo7YdDr2wCeDU692KjAriyVZTObK bg1lFSw6AE8+Y1jZPiql6aBLW7DexwIQyoABzIrc= Date: Fri, 7 Oct 2022 09:40:52 +0200 From: Greg Kroah-Hartman To: Elliot Berman Cc: Bjorn Andersson , Jiri Slaby , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services Message-ID: References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-15-quic_eberman@quicinc.com> <14d0ff9f-60f3-71cc-ea42-ceee389298ac@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <14d0ff9f-60f3-71cc-ea42-ceee389298ac@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221007_004013_081892_5A8FF57A X-CRM114-Status: GOOD ( 24.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 06, 2022 at 10:59:51PM -0700, Elliot Berman wrote: > > > + */ > > > +#define RSC_MGR_TTY_ADAPTERS 16 > > > > We can have dynamic tty devices, so I don't understand this comment. > > What really is the problem here? > > > > Yes, I see the confusion. Dynamic device addition of tty devices is > supported. As I understand, you need to know the maximum number of lines > that could be added, and that is limitation I was referring to. What do you mean by "lines"? That's not a tty kernel term. > Is this comment better? > > The Linux TTY code requires us to know ahead of time how many lines we > might need. Each line here corresponds to a VM. 16 seems like a > reasonable number of lines for systems that are running Gunyah and using > the provided console interface. Again, line? Do you mean port? > > > + cons_data->tty_driver->driver_name = "gh"; KBUILD_MODNAME? > > > + cons_data->tty_driver->name = "ttyGH"; > > > > Where did you pick this name from? > > > > Where is it documented? > > > > "GH" is the shorthand we've been using for "Gunyah". I didn't find > documentation for dynamically assigned char devices, but if it exists, I can > add entry for ttyGH. Why use a new name at all? Why not stick with the existing tty names and device numbers? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel