From: Quentin Perret <qperret@google.com>
To: Vincent Donnefort <vdonnefort@google.com>
Cc: maz@kernel.org, oliver.upton@linux.dev, james.morse@arm.com,
alexandru.elisei@arm.com, suzuki.poulose@arm.com,
will@kernel.org, catalin.marinas@arm.com, kvmarm@lists.linux.dev,
linux-arm-kernel@lists.infradead.org, dbrazdil@google.com
Subject: Re: [PATCH] KVM: arm64: Enable stack protection and branch profiling for VHE
Date: Thu, 6 Oct 2022 07:17:56 +0000 [thread overview]
Message-ID: <Yz6BJJIadPqiktfO@google.com> (raw)
In-Reply-To: <20221004154216.2833636-1-vdonnefort@google.com>
On Tuesday 04 Oct 2022 at 16:42:16 (+0100), Vincent Donnefort wrote:
> For historical reasons, the VHE code inherited the build configuration from
> nVHE. Now those two parts have their own folder and makefile, we can
> enable stack protection and branch profiling for VHE.
+CC David who has been messing with these Makefiles in the past to
confirm, but this makes sense to me.
Reviewed-by: Quentin Perret <qperret@google.com>
> Signed-off-by: Vincent Donnefort <vdonnefort@google.com>
>
> diff --git a/arch/arm64/kvm/hyp/Makefile b/arch/arm64/kvm/hyp/Makefile
> index 687598e41b21..a38dea6186c9 100644
> --- a/arch/arm64/kvm/hyp/Makefile
> +++ b/arch/arm64/kvm/hyp/Makefile
> @@ -5,9 +5,6 @@
>
> incdir := $(srctree)/$(src)/include
> subdir-asflags-y := -I$(incdir)
> -subdir-ccflags-y := -I$(incdir) \
> - -fno-stack-protector \
> - -DDISABLE_BRANCH_PROFILING \
> - $(DISABLE_STACKLEAK_PLUGIN)
> +subdir-ccflags-y := -I$(incdir)
>
> obj-$(CONFIG_KVM) += vhe/ nvhe/ pgtable.o
> diff --git a/arch/arm64/kvm/hyp/nvhe/Makefile b/arch/arm64/kvm/hyp/nvhe/Makefile
> index b5c5119c7396..48f6ae7cc6e6 100644
> --- a/arch/arm64/kvm/hyp/nvhe/Makefile
> +++ b/arch/arm64/kvm/hyp/nvhe/Makefile
> @@ -10,6 +10,9 @@ asflags-y := -D__KVM_NVHE_HYPERVISOR__ -D__DISABLE_EXPORTS
> # will explode instantly (Words of Marc Zyngier). So introduce a generic flag
> # __DISABLE_TRACE_MMIO__ to disable MMIO tracing for nVHE KVM.
> ccflags-y := -D__KVM_NVHE_HYPERVISOR__ -D__DISABLE_EXPORTS -D__DISABLE_TRACE_MMIO__
> +ccflags-y += -fno-stack-protector \
> + -DDISABLE_BRANCH_PROFILING \
> + $(DISABLE_STACKLEAK_PLUGIN)
>
> hostprogs := gen-hyprel
> HOST_EXTRACFLAGS += -I$(objtree)/include
> --
> 2.38.0.rc1.362.ged0d419d3c-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-06 7:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-04 15:42 [PATCH] KVM: arm64: Enable stack protection and branch profiling for VHE Vincent Donnefort
2022-10-06 7:17 ` Quentin Perret [this message]
2022-10-09 2:16 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz6BJJIadPqiktfO@google.com \
--to=qperret@google.com \
--cc=alexandru.elisei@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dbrazdil@google.com \
--cc=james.morse@arm.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=suzuki.poulose@arm.com \
--cc=vdonnefort@google.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).