From: Andrew Lunn <andrew@lunn.ch>
To: Rob Herring <robh@kernel.org>
Cc: "Pali Rohár" <pali@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Marcin Wojtas" <mw@semihalf.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ASoC: kirkwood: enable Kirkwood driver for Armada 38x platforms
Date: Mon, 26 Sep 2022 22:04:21 +0200 [thread overview]
Message-ID: <YzIFxWq7Kt0SudLz@lunn.ch> (raw)
In-Reply-To: <20220926194832.GA2668987-robh@kernel.org>
On Mon, Sep 26, 2022 at 02:48:32PM -0500, Rob Herring wrote:
> On Tue, Sep 20, 2022 at 03:26:44PM +0200, Pali Rohár wrote:
> > From: Marcin Wojtas <mw@semihalf.com>
> >
> > The audio unit of Marvell Armada38x SoC is similar to the ones comprised by
> > other Marvell SoCs (Kirkwood, Dove and Armada 370). Therefore KW audio
> > driver can be used to support it and this commit adds new compatible string
> > to identify Armada 38x variant.
> >
> > Two new memory regions are added: first one for PLL configuration and
> > the second one for choosing one of audio I/O modes (I2S or S/PDIF).
> > For the latter purpose a new optional DT property is added ('spdif-mode').
> >
> > kirkwood-i2s driver is extended by adding a new init function for Armada
> > 38x flavor and also a routine that enables PLL output (i.e. MCLK)
> > configuration.
> >
> > Signed-off-by: Marcin Wojtas <mw@semihalf.com>
> > Tested-by: Star_Automation <star@marvell.com>
> > Reviewed-by: Nadav Haklai <nadavh@marvell.com>
> > Reviewed-by: Lior Amsalem <alior@marvell.com>
> > Tested-by: Lior Amsalem <alior@marvell.com>
> > Signed-off-by: Hezi Shahmoon <hezi@marvell.com>
> > Reviewed-by: Neta Zur Hershkovits <neta@marvell.com>
> > [pali: Fix support for pre-38x SoCs]
> > Signed-off-by: Pali Rohár <pali@kernel.org>
> > ---
> > .../devicetree/bindings/sound/mvebu-audio.txt | 14 +-
> > sound/soc/kirkwood/kirkwood-i2s.c | 136 +++++++++++++++++-
> > sound/soc/kirkwood/kirkwood.h | 2 +
> > 3 files changed, 149 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/mvebu-audio.txt b/Documentation/devicetree/bindings/sound/mvebu-audio.txt
> > index cb8c07c81ce4..4f5dec5cb3c2 100644
> > --- a/Documentation/devicetree/bindings/sound/mvebu-audio.txt
> > +++ b/Documentation/devicetree/bindings/sound/mvebu-audio.txt
> > @@ -6,9 +6,14 @@ Required properties:
> > "marvell,kirkwood-audio" for Kirkwood platforms
> > "marvell,dove-audio" for Dove platforms
> > "marvell,armada370-audio" for Armada 370 platforms
> > + "marvell,armada-380-audio" for Armada 38x platforms
>
> Perhaps be consistent with the 370 string above it.
Hi Rob
That was something i also considered. But actually, all 380
compatibles use armada-380-FOOBAR. So this is inconsistent with
armada370-audio, but consistent with armada-380 in general.
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-26 20:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 13:26 [PATCH 0/5] ARM: mvebu: Add audio support for Armada 38x Pali Rohár
2022-09-20 13:26 ` [PATCH 1/5] ASoC: kirkwood: enable Kirkwood driver for Armada 38x platforms Pali Rohár
2022-09-20 13:39 ` Andrew Lunn
2022-09-26 19:48 ` Rob Herring
2022-09-26 20:04 ` Andrew Lunn [this message]
2022-09-20 13:26 ` [PATCH 2/5] ARM: mvebu: add audio I2S controller to Armada 38x Device Tree Pali Rohár
2022-09-20 13:40 ` Andrew Lunn
2022-09-20 13:26 ` [PATCH 3/5] ARM: mvebu: add audio support to Armada 385 DB Pali Rohár
2022-09-20 13:41 ` Andrew Lunn
2022-09-20 13:26 ` [PATCH 4/5] ARM: mvebu: Add spdif-pins mpp pins for Armada 38x Pali Rohár
2022-09-20 13:41 ` Andrew Lunn
2022-09-20 13:26 ` [PATCH 5/5] ARM: dts: turris-omnia: Define S/PDIF audio card Pali Rohár
2022-09-20 13:42 ` Andrew Lunn
2022-09-23 15:14 ` [PATCH 0/5] ARM: mvebu: Add audio support for Armada 38x Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzIFxWq7Kt0SudLz@lunn.ch \
--to=andrew@lunn.ch \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).