From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFF92C04A95 for ; Wed, 28 Sep 2022 08:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gL7F7Kpn8rNZsPewshROwB9UKmTjjjgGQgrgDOz+pdg=; b=Qu9MP2eyP5Urx9 41RKmTE6Pw8ooR2/TGHDW8VPAL60yE7/KufIeNFsutz63wkvmH1rwxssC7eiBPEU+8o62rcBFlsCY jP2JOGcJbLe6N9iI1pc4ff7R1tKvrCf7Nm4PefulAy7msKgFZUvu0nHVb7U6h/8cSTIlQw/cHIVkM fTGr41U4E2WRsQcjI8FIS4BOZfvTP1FJe39Fo4phJ0Jwd61Acc/u+ipf8snqNXsfiPqE7lwD1lxVA wbP8fZfW7S2/5vrspSA9Q/YpbIaLBFJkvbgBChZfQZ42WnrhvNQXHecWTzFuTTmEiXEy3ytzJ9UDs kTVkeCkJjPVbWTey7ihQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odSbM-00EwPK-FJ; Wed, 28 Sep 2022 08:39:32 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odSbJ-00EwMQ-B5 for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 08:39:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 9DBA0CE1D58; Wed, 28 Sep 2022 08:39:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9CFAC433D6; Wed, 28 Sep 2022 08:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664354360; bh=s/YcRSwr9zctteq1dmxPcXH2bnKWNhBdbSVODYGwNz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vDlhN+wOGpLcYy2dzLZG3vJxpBMJqwmMmjxrkov2S4tdBv8u7Z25Q4Z0opf6P5a7q TkWRAzR0qGhovGIc8EwxPQwJxjsNGaWXX8a6f7AxWTl+xMTKFExqjqmSzAtKhZVXpp UjOXHuRRIT1t1plhO0WxKQJlY4iK1MK8FdQJ+Fr5UY9vgAGI7YhDifGHiV5MSRlMlk J892stCpd8yY6wVyfdAs3vRPy8jBVLZoB+xUeTTOGU6H1ZipSJsSmh/efyd0lVgaE7 EGqsFnEKeHq8te5jM+MxVVocDoFDevcqmuK4O6ggwQU8SDgHNx/riE3NxyfTByLlD/ DP/WgrJb5NvYA== Date: Wed, 28 Sep 2022 10:39:14 +0200 From: Lorenzo Pieralisi To: Marek =?iso-8859-1?Q?Beh=FAn?= , Bjorn Helgaas Cc: Lorenzo Pieralisi , Lukas Wunner , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , pali@kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 02/11] PCI: pciehp: Enable Command Completed Interrupt only if supported Message-ID: References: <20220818135140.5996-1-kabel@kernel.org> <20220818135140.5996-3-kabel@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220818135140.5996-3-kabel@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_013929_581931_83C843A9 X-CRM114-Status: GOOD ( 22.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 18, 2022 at 03:51:31PM +0200, Marek Beh=FAn wrote: > From: Pali Roh=E1r > = > The No Command Completed Support bit in the Slot Capabilities register > indicates whether Command Completed Interrupt Enable is unsupported. > = > We already check whether No Command Completed Support bit is set in > pcie_wait_cmd(), and do not wait in this case. > = > Let's not enable this Command Completed Interrupt at all if NCCS is set, > so that when users dump configuration space from userspace, the dump > does not confuse them by saying that Command Completed Interrupt is not > supported, but it is enabled. > = > Signed-off-by: Pali Roh=E1r > Signed-off-by: Marek Beh=FAn > --- > Changes since batch 5: > - changed commit message, previously we wrote that the change is needed > to fix a bug where kernel was waiting for an event which did not > come. This turns out to be false. See > https://lore.kernel.org/linux-pci/20220818142243.4c046c59@dellmb/T/#u > --- > drivers/pci/hotplug/pciehp_hpc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Hi Bjorn, this patch is mixed with aardvark specific changes, please let me know if it is fine for you to merge it. Thanks, Lorenzo > diff --git a/drivers/pci/hotplug/pciehp_hpc.c b/drivers/pci/hotplug/pcieh= p_hpc.c > index 373bb396fe22..838eb6cc3ec7 100644 > --- a/drivers/pci/hotplug/pciehp_hpc.c > +++ b/drivers/pci/hotplug/pciehp_hpc.c > @@ -817,7 +817,9 @@ static void pcie_enable_notification(struct controlle= r *ctrl) > else > cmd |=3D PCI_EXP_SLTCTL_PDCE; > if (!pciehp_poll_mode) > - cmd |=3D PCI_EXP_SLTCTL_HPIE | PCI_EXP_SLTCTL_CCIE; > + cmd |=3D PCI_EXP_SLTCTL_HPIE; > + if (!pciehp_poll_mode && !NO_CMD_CMPL(ctrl)) > + cmd |=3D PCI_EXP_SLTCTL_CCIE; > = > mask =3D (PCI_EXP_SLTCTL_PDCE | PCI_EXP_SLTCTL_ABPE | > PCI_EXP_SLTCTL_PFDE | > -- = > 2.35.1 > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel