From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA5FBC433F5 for ; Fri, 30 Sep 2022 12:23:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=b8xnjJUnUq6gDdItdXoU3P81UOIBLAfb1mddO+haZtU=; b=3W+abI6lKGS1U3 eCX4gd1Me7zIybVDe+H2AfD0LchGgPNzdjwEAaVFX+ZvUgiPW2BWk7s5nE/eS32C/do2DGkRTTy6F o4nrpyk12qTmLP4QiErHBO0gz/pw0vklQG5B+we8Rkt0GJJuEi3nkXNY7QS2wgsNTbDI3gV3MagH7 i44D6kuWkj5wpNMVxCuu1yc9URCHRDgtu6ma7VeHmrbwPW5jY8mQzGaf/VEcL/wAMp7iv+WwQi37V 729IOeVC1cml7Pgzcf4wtbDlAsjl/LyY2kM+rbWXmqyVMNlx9EVKaI8WWkdtW/gOeQ1mqS/YjFyEP LhmRTHkUwVn4Ks4wrR0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeF1r-0097N0-VC; Fri, 30 Sep 2022 12:22:08 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oeF1o-0097Lb-OC for linux-arm-kernel@lists.infradead.org; Fri, 30 Sep 2022 12:22:06 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1AE9762304; Fri, 30 Sep 2022 12:22:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3576C433D6; Fri, 30 Sep 2022 12:22:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1664540523; bh=rIbGJ12SYgk+2I6draZEZwvcyTCpTsiUZ5ZhxdE6Cx0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tkLM65PqSKrKBFln2qW+m34r3Rb9biTw64Qq1nRmrwRlttKWRzGijYcPirgkj9/j7 KY9/lmJhODMLOFkw6NkXFSriJALSk8lH/vxej/oBf+0sTIyLi5Z4vCYEJgFmB6OVMN jYUPdn6E6NMm/twBzxZYvH+FueY+Gm2FMR5SFszg= Date: Fri, 30 Sep 2022 14:22:00 +0200 From: Greg Kroah-Hartman To: Elliot Berman Cc: Bjorn Andersson , Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Andy Gross , Dmitry Baryshkov , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 12/14] gunyah: rsc_mgr: Add RPC for console services Message-ID: References: <20220928195633.2348848-1-quic_eberman@quicinc.com> <20220928195633.2348848-13-quic_eberman@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220928195633.2348848-13-quic_eberman@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220930_052204_890798_93484A5C X-CRM114-Status: GOOD ( 32.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 28, 2022 at 12:56:31PM -0700, Elliot Berman wrote: > Gunyah resource manager defines a simple API for virtual machine log > sharing with the console service. A VM's own log can be opened by using > GH_VMID_SELF. Another VM's log can be accessed via its VMID. Once > opened, characters can be written to the log with a write command. > Characters are received with resource manager notifications (using ID > GH_RM_NOTIF_VM_CONSOLE_CHARS). > > These high level rpc calls are kept in > drivers/virt/gunyah/rsc_mgr_rpc.c. Future RPC calls, e.g. to launch a VM > will also be maintained in this file. > > Signed-off-by: Elliot Berman > --- > drivers/virt/gunyah/Makefile | 2 +- > drivers/virt/gunyah/rsc_mgr.h | 22 +++++ > drivers/virt/gunyah/rsc_mgr_rpc.c | 151 ++++++++++++++++++++++++++++++ > include/linux/gunyah_rsc_mgr.h | 16 ++++ > 4 files changed, 190 insertions(+), 1 deletion(-) > create mode 100644 drivers/virt/gunyah/rsc_mgr_rpc.c > > diff --git a/drivers/virt/gunyah/Makefile b/drivers/virt/gunyah/Makefile > index 7c512490f921..73339ed445b3 100644 > --- a/drivers/virt/gunyah/Makefile > +++ b/drivers/virt/gunyah/Makefile > @@ -1,5 +1,5 @@ > gunyah-y += sysfs.o > obj-$(CONFIG_GUNYAH) += gunyah.o > > -gunyah_rsc_mgr-y += rsc_mgr.o > +gunyah_rsc_mgr-y += rsc_mgr.o rsc_mgr_rpc.o > obj-$(CONFIG_GUNYAH_RESORUCE_MANAGER) += gunyah_rsc_mgr.o > diff --git a/drivers/virt/gunyah/rsc_mgr.h b/drivers/virt/gunyah/rsc_mgr.h > index e4f2499267bf..deb884979209 100644 > --- a/drivers/virt/gunyah/rsc_mgr.h > +++ b/drivers/virt/gunyah/rsc_mgr.h > @@ -28,6 +28,28 @@ > #define GH_RM_ERROR_IRQ_INUSE 0x10 > #define GH_RM_ERROR_IRQ_RELEASED 0x11 > > +/* Message IDs: VM Management */ > +#define GH_RM_RPC_VM_GET_VMID 0x56000024 > + > +/* Message IDs: VM Services */ > +#define GH_RM_RPC_VM_CONSOLE_OPEN_ID 0x56000081 > +#define GH_RM_RPC_VM_CONSOLE_CLOSE_ID 0x56000082 > +#define GH_RM_RPC_VM_CONSOLE_WRITE_ID 0x56000083 > +#define GH_RM_RPC_VM_CONSOLE_FLUSH_ID 0x56000084 > + > +/* Call: CONSOLE_OPEN, CONSOLE_CLOSE, CONSOLE_FLUSH */ > +struct gh_vm_console_common_req { > + u16 vmid; > + u16 reserved0; > +} __packed; > + > +/* Call: CONSOLE_WRITE */ > +struct gh_vm_console_write_req { > + u16 vmid; > + u16 num_bytes; > + u8 data[0]; > +} __packed; > + > int gh_rm_call(u32 message_id, void *req_buff, size_t req_buff_size, > void **resp_buf, size_t *resp_buff_size); > > diff --git a/drivers/virt/gunyah/rsc_mgr_rpc.c b/drivers/virt/gunyah/rsc_mgr_rpc.c > new file mode 100644 > index 000000000000..8238c6ef301f > --- /dev/null > +++ b/drivers/virt/gunyah/rsc_mgr_rpc.c > @@ -0,0 +1,151 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +#define pr_fmt(fmt) "gh_rsc_mgr: " fmt > + > +#include > +#include > +#include > +#include > + > +#include "rsc_mgr.h" > + > +/** > + * gh_rm_get_vmid() - Retrieve VMID of this virtual machine > + * @vmid: Filled with the VMID of this VM > + */ > +int gh_rm_get_vmid(u16 *vmid) > +{ > + void *resp; > + size_t resp_size; > + int ret; > + int payload = 0; > + > + ret = gh_rm_call(GH_RM_RPC_VM_GET_VMID, &payload, sizeof(payload), &resp, &resp_size); > + if (ret) > + return ret; > + > + if (resp_size != sizeof(*vmid)) > + return -EIO; > + *vmid = *(u16 *)resp; > + kfree(resp); > + > + return ret; > +} > + > +/** > + * gh_rm_console_open() - Open a console with a VM > + * @vmid: VMID of the other VM whose console to open. If VMID is GH_VMID_SELF, the > + * console associated with this VM is opened. > + */ > +int gh_rm_console_open(u16 vmid) > +{ > + void *resp; > + struct gh_vm_console_common_req req_payload = {0}; > + size_t resp_size; > + int ret; > + > + req_payload.vmid = vmid; > + > + ret = gh_rm_call(GH_RM_RPC_VM_CONSOLE_OPEN_ID, > + &req_payload, sizeof(req_payload), > + &resp, &resp_size); > + kfree(resp); > + > + if (!ret && resp_size) > + pr_warn("Received unexpected payload for CONSOLE_OPEN: %lu\n", resp_size); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(gh_rm_console_open); > + > +/** > + * gh_rm_console_close() - Close a console with a VM > + * @vmid: The vmid of the vm whose console to close. > + */ > +int gh_rm_console_close(u16 vmid) > +{ > + void *resp; > + struct gh_vm_console_common_req req_payload = {0}; > + size_t resp_size; > + int ret; > + > + req_payload.vmid = vmid; > + > + ret = gh_rm_call(GH_RM_RPC_VM_CONSOLE_CLOSE_ID, > + &req_payload, sizeof(req_payload), > + &resp, &resp_size); > + kfree(resp); > + > + if (!ret && resp_size) > + pr_warn("Received unexpected payload for CONSOLE_CLOSE: %lu\n", resp_size); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(gh_rm_console_close); > + > +/** > + * gh_rm_console_write() - Write to a VM's console > + * @vmid: The vmid of the vm whose console to write to. > + * @buf: Buffer to write to the VM's console > + * @size: Size of the buffer > + */ > +int gh_rm_console_write(u16 vmid, const char *buf, size_t size) > +{ > + void *resp; > + struct gh_vm_console_write_req *req_payload; > + size_t resp_size; > + int ret = 0; > + size_t req_payload_size = sizeof(*req_payload) + size; > + > + if (size < 1 || size > (U32_MAX - sizeof(*req_payload))) > + return -EINVAL; > + > + req_payload = kzalloc(req_payload_size, GFP_KERNEL); > + > + if (!req_payload) > + return -ENOMEM; > + > + req_payload->vmid = vmid; > + req_payload->num_bytes = size; > + memcpy(req_payload->data, buf, size); > + > + ret = gh_rm_call(GH_RM_RPC_VM_CONSOLE_WRITE_ID, > + req_payload, req_payload_size, > + &resp, &resp_size); > + kfree(req_payload); > + kfree(resp); > + > + if (!ret && resp_size) > + pr_warn("Received unexpected payload for CONSOLE_WRITE: %lu\n", resp_size); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(gh_rm_console_write); > + > +/** > + * gh_rm_console_flush() - Flush a console with a VM > + * @vmid: The vmid of the vm whose console to flush > + */ > +int gh_rm_console_flush(u16 vmid) > +{ > + void *resp; > + struct gh_vm_console_common_req req_payload = {0}; > + size_t resp_size; > + int ret; > + > + req_payload.vmid = vmid; > + > + ret = gh_rm_call(GH_RM_RPC_VM_CONSOLE_FLUSH_ID, > + &req_payload, sizeof(req_payload), > + &resp, &resp_size); > + kfree(resp); > + > + if (!ret && resp_size) > + pr_warn("Received unexpected payload for CONSOLE_FLUSH: %lu\n", resp_size); > + > + return ret; > +} > +EXPORT_SYMBOL_GPL(gh_rm_console_flush); > diff --git a/include/linux/gunyah_rsc_mgr.h b/include/linux/gunyah_rsc_mgr.h > index b3b37225b7fb..f831ca921c26 100644 > --- a/include/linux/gunyah_rsc_mgr.h > +++ b/include/linux/gunyah_rsc_mgr.h > @@ -23,4 +23,20 @@ struct gh_rm_notification { > int gh_rm_register_notifier(struct notifier_block *nb); > int gh_rm_unregister_notifier(struct notifier_block *nb); > > +/* Notification type Message IDs */ > +#define GH_RM_NOTIF_VM_CONSOLE_CHARS 0x56100080 > + > +struct gh_rm_notif_vm_console_chars { > + u16 vmid; > + u16 num_bytes; > + u8 bytes[0]; Please do not use [0] for new structures, otherwise we will just have to fix them up again as we are trying to get rid of all of these from the kernel. Just use "bytes[];" instead. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel