From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E56ACC33C9E for ; Mon, 25 Nov 2019 15:47:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE7B620865 for ; Mon, 25 Nov 2019 15:47:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DLNsvkOd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE7B620865 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:From:Date: MIME-Version:Subject:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v1nOzrni2ajm9HVzRutT0LLEsUQdUG/SALCH1zuioBA=; b=DLNsvkOdiJ1sPTlLKJrKe31f2 zqYJcoil6b94odkdXGmrMeEtIlwAwVNgyImvNl5JVzoqq4i3px05k3Egu+JH6oPwI+XeBdOrVYoDZ H21IS9Bax2yNUcyecQz7Cnx6Upw+BAYIegKACZea4SZdmCNbFKVoYv4DOClO3uEP92MYDkZgf3sKX tr4aWM2j/gAWhjpybbVfdMtvsAeFuN9UuCHXssl4O+a/8TYoMt8BjROi3nCa8gJF50X2NwR00bvnK +BnIT/MlKNFV2BnBY6ee0G2749kS7SbfpAA/JYV42qG37hEgGj9gwN7vYb446XcB0feZI2rLvZx26 pIlX1rNDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZGaf-00045Z-4q; Mon, 25 Nov 2019 15:47:53 +0000 Received: from inca-roads.misterjones.org ([213.251.177.50]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iZGab-00045D-Mr for linux-arm-kernel@lists.infradead.org; Mon, 25 Nov 2019 15:47:51 +0000 Received: from www-data by cheepnis.misterjones.org with local (Exim 4.80) (envelope-from ) id 1iZGaS-00029Q-Ac; Mon, 25 Nov 2019 16:47:40 +0100 To: Jianyong Wu Subject: Re: [RFC PATCH v8 3/8] ptp: Reorganize =?UTF-8?Q?ptp=5Fkvm=20modu?= =?UTF-8?Q?les=20to=20make=20it=20arch-independent=2E?= X-PHP-Originating-Script: 0:main.inc MIME-Version: 1.0 Date: Mon, 25 Nov 2019 15:47:40 +0000 From: Marc Zyngier In-Reply-To: <20191125104506.36850-4-jianyong.wu@arm.com> References: <20191125104506.36850-1-jianyong.wu@arm.com> <20191125104506.36850-4-jianyong.wu@arm.com> Message-ID: X-Sender: maz@kernel.org User-Agent: Roundcube Webmail/0.7.2 X-SA-Exim-Connect-IP: X-SA-Exim-Rcpt-To: jianyong.wu@arm.com, netdev@vger.kernel.org, yangbo.lu@nxp.com, john.stultz@linaro.org, tglx@linutronix.de, pbonzini@redhat.com, sean.j.christopherson@intel.com, richardcochran@gmail.com, mark.rutland@arm.com, will@kernel.org, suzuki.poulose@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, steve.capper@arm.com, kaly.xin@arm.com, justin.he@arm.com, nd@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on cheepnis.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191125_074749_891743_E42BE16C X-CRM114-Status: GOOD ( 15.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, justin.he@arm.com, kvm@vger.kernel.org, suzuki.poulose@arm.com, netdev@vger.kernel.org, richardcochran@gmail.com, steve.capper@arm.com, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, kaly.xin@arm.com, john.stultz@linaro.org, yangbo.lu@nxp.com, pbonzini@redhat.com, tglx@linutronix.de, nd@arm.com, will@kernel.org, kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2019-11-25 10:45, Jianyong Wu wrote: > Currently, ptp_kvm modules implementation is only for x86 which > includs > large part of arch-specific code. This patch move all of those code > into new arch related file in the same directory. > > Signed-off-by: Jianyong Wu > --- > drivers/ptp/Makefile | 1 + > drivers/ptp/{ptp_kvm.c => ptp_kvm_common.c} | 77 +++++------------- > drivers/ptp/ptp_kvm_x86.c | 87 > +++++++++++++++++++++ > include/asm-generic/ptp_kvm.h | 12 +++ > 4 files changed, 118 insertions(+), 59 deletions(-) > rename drivers/ptp/{ptp_kvm.c => ptp_kvm_common.c} (63%) > create mode 100644 drivers/ptp/ptp_kvm_x86.c > create mode 100644 include/asm-generic/ptp_kvm.h [...] > diff --git a/include/asm-generic/ptp_kvm.h > b/include/asm-generic/ptp_kvm.h > new file mode 100644 > index 000000000000..e5dd386f6664 > --- /dev/null > +++ b/include/asm-generic/ptp_kvm.h > @@ -0,0 +1,12 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +/* > + * Virtual PTP 1588 clock for use with KVM guests > + * > + * Copyright (C) 2019 ARM Ltd. I think you should live the original copyright assignment here. This really isn't anything new. > + * All Rights Reserved > + */ > + > +int kvm_arch_ptp_init(void); > +int kvm_arch_ptp_get_clock(struct timespec64 *ts); > +int kvm_arch_ptp_get_crosststamp(unsigned long *cycle, > + struct timespec64 *tspec, void *cs); Why is this include file in asm-generic? This isn't a kernel-wide API. I think it should be sitting in drivers/ptp, as it is only shared between the generic and arch-specific stuff. Thanks, M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel