From: Daniel Almeida <daniel.almeida@collabora.com>
To: Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
linux-media@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>,
Philipp Zabel <p.zabel@pengutronix.de>,
Heiko Stuebner <heiko@sntech.de>,
kernel@collabora.com
Subject: Re: [RFC 2/2] media: rkvdec: Add VP8 encoder
Date: Sat, 18 Mar 2023 20:23:10 -0300 [thread overview]
Message-ID: <a142c30ab49a8ff65c59bdc9bc0e4552c48bac68.camel@collabora.com> (raw)
In-Reply-To: <20230309125651.23911-3-andrzej.p@collabora.com>
Hi Andrzej, one thing I noticed while looking at this:
> +struct hantro_vp8_entropy {
> + /* TODO: int32_t? */
> + int32_t coeff_prob[4][8][3][11];
> + int32_t coeff_prob_old[4][8][3][11];
> + int32_t mv_prob[2][19];
> + int32_t mv_prob_old[2][19];
> + int32_t y_mode_prob[4];
> + int32_t uv_mode_prob[3];
> +};
>
In VP9, probabilities are coded in the 0..255 range, so if you want to
save space here, you can go with uint8_t.
-- Daniel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-18 23:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 12:56 [RFC 0/2] VP8 stateless V4L2 encoding uAPI + driver Andrzej Pietrasiewicz
2023-03-09 12:56 ` [RFC 1/2] media: uapi: Add VP8 stateless encoder controls Andrzej Pietrasiewicz
2023-03-21 13:39 ` Hans Verkuil
2023-03-22 10:06 ` Andrzej Pietrasiewicz
2023-03-24 18:49 ` Nicolas Dufresne
2023-03-27 12:53 ` Andrzej Pietrasiewicz
2023-03-31 14:59 ` Nicolas Dufresne
2023-03-09 12:56 ` [RFC 2/2] media: rkvdec: Add VP8 encoder Andrzej Pietrasiewicz
2023-03-18 23:23 ` Daniel Almeida [this message]
2023-03-18 23:27 ` Dmitry Osipenko
2023-03-20 10:34 ` Andrzej Pietrasiewicz
2023-03-20 10:33 ` Andrzej Pietrasiewicz
2023-05-05 16:33 ` guan wentao
2023-05-20 18:57 ` Adam Ford
2023-05-23 6:42 ` Marco Felsch
2023-05-25 14:20 ` Nicolas Dufresne
2023-03-18 9:20 ` [RFC 0/2] VP8 stateless V4L2 encoding uAPI + driver Nicolas Frattaroli
2023-03-20 10:07 ` Andrzej Pietrasiewicz
2023-03-20 14:37 ` Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a142c30ab49a8ff65c59bdc9bc0e4552c48bac68.camel@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=andrzej.p@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).