From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8811ECAAD3 for ; Fri, 9 Sep 2022 08:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AEraQpFe/b5TSjpu8yZ4cbkwXP7m11uMyhy9rzVJ5Ws=; b=1Z3uD9VYqbx20J VgcsmZ6h5ddjh5Z3A9cPDvTzSHkUG9T2lEk11zjTf/j6bKrOZK2t4fblaA4ks9ibKWYhzY9t/qcE1 3FN/Y8IBI12bghbHKCJTYxTLZsCldFZucsXk7/oXlIAxdI+/ScpdYlX+RyedIVrwB5c96l+cDwnA9 AuhsUDXkVzoswXrOLqz1W/x5L00Vt3pfzBuTL5m+5bH4dj9Vqlxy4kPKGlMHeBXZBXzU+0/WzZ0TO gS4gF6UKp1xC3HpnH7qjYoId8ekhxtUIl9R99Xr1k3DYgj3kWi2Q4K0XDMvviEE7AQ7myavy3sEn1 YK2NFwItXlzoNFJ7DS2A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWYyf-00EK5J-FT; Fri, 09 Sep 2022 08:03:06 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oWYyc-00EK0x-Cs for linux-arm-kernel@lists.infradead.org; Fri, 09 Sep 2022 08:03:03 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5877BB82373; Fri, 9 Sep 2022 08:03:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FD5CC433D7; Fri, 9 Sep 2022 08:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662710579; bh=+1jf4vnkdN2PEc2sJmjoWRV+8uzkgTQry95TvIwUh1I=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GTjnX5bMeCaAxxZ9L9Ehc2UzzS/QVJ4WG47BVxApQhRxPoGyTxGf8YzCxluvx5Xuo cW422r4xQUcHZB4U6i6zsR1gFgorgtLr3yVhoYnrhX26DLze8bdsgoOzgrQ9zmkwa5 EcMooQX1M+rd/aIJOh8PjVianR0V7Gab17mPMNMVD3mdI/IwfATRXJcagJ1LmNqkob wcw8WMKsY3bgdXrs4m2e+/wzQ5GM58axt26ehPJgdFymLQ65tciid6pbw5SGvmIUQT 3a1dVjigZDVk8qtet3AIiHboCLlz1ICgScJl/b9+vNAlS8ZuSMJPUoxtiwLUrunxGU GiywkL4AkOhEQ== Message-ID: Date: Fri, 9 Sep 2022 10:02:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 1/2] dt-bindings: arm: Add i.MX8M Mini Gateworks GW7904 board Content-Language: en-US To: Tim Harvey , Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team References: <20220902230500.2624739-1-tharvey@gateworks.com> <20220908211916.GA3348959-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220909_010302_654681_AAB6960C X-CRM114-Status: GOOD ( 19.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 08/09/2022 23:44, Tim Harvey wrote: > On Thu, Sep 8, 2022 at 2:19 PM Rob Herring wrote: >> >> On Fri, Sep 02, 2022 at 04:04:59PM -0700, Tim Harvey wrote: >>> Add DT compatible string for i.MX8M Mini based Gateworks GW7904 board. >>> >>> Signed-off-by: Tim Harvey >>> Cc: Rob Herring >>> Cc: Krzysztof Kozlowski >>> Cc: Shawn Guo >>> Cc: Sascha Hauer >>> Cc: Pengutronix Kernel Team >>> Cc: Fabio Estevam >>> Cc: NXP Linux Team >>> --- >>> Documentation/devicetree/bindings/arm/fsl.yaml | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml >>> index 7431579ab0e8..ce89fac1898e 100644 >>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml >>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml >>> @@ -831,6 +831,7 @@ properties: >>> - gw,imx8mm-gw7901 # i.MX8MM Gateworks Board >>> - gw,imx8mm-gw7902 # i.MX8MM Gateworks Board >>> - gw,imx8mm-gw7903 # i.MX8MM Gateworks Board >>> + - gateworks,imx8mm-gw7904 # i.MX8MM Gateworks Board >> >> A useful comment would be ones that distuiguish these boards. It's >> obvious from the compatible it's a i.MX8MM board from Gateworks. > > But isn't it clear that you need to go to the device-tree itself to > understand the details? > > As far as basic features go sometimes there is very little difference > in these board models. It would be a struggle to list all the board > details (which I do in the dts commit) in a way that doesn't take up > too much space in fsl.yaml. > But then the comment you added is useless. So either add useful comment or no comment. :) Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel