From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B32C04AA7 for ; Mon, 13 May 2019 16:05:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D731D2084E for ; Mon, 13 May 2019 16:05:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ATNb3e0O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D731D2084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Mime-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=87Xg3sFLjoGlWBSg0x1PqI0pUUtpHZgW/XG84GjzBJY=; b=ATNb3e0Oq6hbxJ ltcusbT77ZnGPLLE4iw9W1peLWsKckNqF8Y8QAmL+VrDwBB5xmr3zkNLyyPSHqZKQtvsf8JcbLuoW 13ulrhn4/UjiFX990d6YIiVIeAtTqLrIdwVHIea8itxWD8N5Ni9kEiIzrzWkY53xCxup2FXux3IB6 LywypvZT+4AXUL5bjHxrndQitKm1QSh/5wb6TzhxANIfbCmP/Ytpi2MqlXnCFPSHragwhhReP/ECS PfucndN+8Sx5HrUBw+pDHltFud01t83pCOKZJeS/4mtBdLhNWJ0UVe13CV0AY+7gwJjtsWVo2vpzr tYM5s063C8DPVFIjKZ3g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQDSP-0003D6-KU; Mon, 13 May 2019 16:05:41 +0000 Received: from smtprelay0130.hostedemail.com ([216.40.44.130] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQDSM-0003CG-MU for linux-arm-kernel@lists.infradead.org; Mon, 13 May 2019 16:05:40 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay04.hostedemail.com (Postfix) with ESMTP id D35CA180A8CCE; Mon, 13 May 2019 16:05:31 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: band11_4ce277087f652 X-Filterd-Recvd-Size: 3941 Received: from XPS-9350.home (cpe-23-242-196-136.socal.res.rr.com [23.242.196.136]) (Authenticated sender: joe@perches.com) by omf14.hostedemail.com (Postfix) with ESMTPA; Mon, 13 May 2019 16:05:28 +0000 (UTC) Message-ID: Subject: Re: [PATCH v9 1/3] arm64: dts: fsl: librem5: Add a device tree for the Librem5 devkit From: Joe Perches To: Angus Ainslie Date: Mon, 13 May 2019 09:05:27 -0700 In-Reply-To: <11c9a715ee0599e50359eb5ad5bd093e@www.akkea.ca> References: <20190513145539.28174-1-angus@akkea.ca> <20190513145539.28174-2-angus@akkea.ca> <0f355f524122cb4dd6388431495a9d182e3ed9d6.camel@perches.com> <11c9a715ee0599e50359eb5ad5bd093e@www.akkea.ca> User-Agent: Evolution 3.30.1-1build1 Mime-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190513_090538_885037_807D0A98 X-CRM114-Status: GOOD ( 16.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-kernel-owner@vger.kernel.org, Fabio Estevam , Sascha Hauer , linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , angus.ainslie@puri.sm, Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 2019-05-13 at 08:35 -0700, Angus Ainslie wrote: > Hi Joe, Hi. > On 2019-05-13 08:11, Joe Perches wrote: > > On Mon, 2019-05-13 at 07:55 -0700, Angus Ainslie (Purism) wrote: > > > This is for the development kit board for the Librem 5. The current > > > level > > > of support yields a working console and is able to boot userspace from > > > the network or eMMC. > > [] > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > > > b/arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts > > > new file mode 100644 > > > > Perhaps add an entry in the MAINTAINERS file for this > > .dts file similar to other freescale boards? > > The MAINTAINERS files has this entry > > ARM/FREESCALE IMX / MXC ARM ARCHITECTURE > M: Shawn Guo > M: Sascha Hauer > R: Pengutronix Kernel Team > R: Fabio Estevam > R: NXP Linux Team > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > S: Maintained > T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git > N: imx > N: mxs > X: drivers/media/i2c/ > > Shouldn't the "N: imx" cover this board already ? Yes, it would, but not 'exclusively' by the get_maintainer.pl script. > Maybe I misunderstood, are you suggesting I add an new entry for "F: > arch/arm64/boot/dts/freescale/*" ? I don't believe an F: arch/arm64/boot/dts/freescale/* pattern would be appropriate as there is already another section with this path as a pattern. ARM/FREESCALE LAYERSCAPE ARM ARCHITECTURE M: Shawn Guo M: Li Yang L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained T: git git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git F: arch/arm/boot/dts/ls1021a* F: arch/arm64/boot/dts/freescale/fsl-* F: arch/arm64/boot/dts/freescale/qoriq-* I suggest perhaps just adding a more specific entry of F: arch/arm64/boot/dts/freescale/imx* And just FYI: F: entries should be preferred over N: entries as filename collisions with other regex matches are common. Controlling the mismatches as was done with the X: exclusion for drivers/media/i2c/ may not scale if another filename is added into the kernel tree that is not maintained by you that matches either of the imx or mxs pattern. It's not really a significant issue though you may get a few patches for files you don't care about at some point. cheers, Joe _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel