From: Randy Dunlap <rdunlap@infradead.org>
To: Jim Quinlan <james.quinlan@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] mailbox: Add Broadcom STB mailbox driver
Date: Fri, 18 Sep 2020 15:21:22 -0700 [thread overview]
Message-ID: <a45018a6-c250-bdd4-fc88-8b09464f71d8@infradead.org> (raw)
In-Reply-To: <20200918221520.21999-3-james.quinlan@broadcom.com>
Hi,
On 9/18/20 3:15 PM, Jim Quinlan wrote:
> diff --git a/drivers/mailbox/Kconfig b/drivers/mailbox/Kconfig
> index 05b1009e2820..378ebd5a7933 100644
> --- a/drivers/mailbox/Kconfig
> +++ b/drivers/mailbox/Kconfig
> @@ -254,4 +254,16 @@ config QCOM_IPCC
> acts as an interrupt controller for receiving interrupts from clients.
> Say Y here if you want to build this driver.
>
coding-style.rst says:
Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two
spaces.
so please fix up the "help" line and the next 2 lines under it.
> +config BRCMSTB_MBOX
> + tristate "Broadcom STB Mailbox"
> + depends on ARM64 || ARM
> + depends on ARM_SCMI_PROTOCOL && ARCH_BRCMSTB
> + default ARM_SCMI_PROTOCOL && ARCH_BRCMSTB
> + help
> + Mailbox implementation of the Broadcom STB for the sole purposes
> + of SCMI communication. This is used by the SCMI drivers to
> + communicate with FW that runs in EL3. This mailbox only implements
> + the agent-to-platform channgel of SCMI but may be augmented in
channel
> + the future to add the platform-to-agent channel.
> +
> endif
thanks.
--
~Randy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-09-18 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 22:15 [PATCH v2 0/2] mailbox: Add Broadcom STB mailbox driver Jim Quinlan
2020-09-18 22:15 ` [PATCH v2 1/2] dt-bindings: Add bindings for BrcmSTB SCMI " Jim Quinlan
2020-09-18 22:15 ` [PATCH v2 2/2] mailbox: Add Broadcom STB " Jim Quinlan
2020-09-18 22:21 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a45018a6-c250-bdd4-fc88-8b09464f71d8@infradead.org \
--to=rdunlap@infradead.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=james.quinlan@broadcom.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).