From: Andrzej Hajda <a.hajda@samsung.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Neil Armstrong <narmstrong@baylibre.com>,
Jonas Karlman <jonas@kwiboo.se>, Mark Brown <broonie@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v7 2/4] driver core: add deferring probe reason to devices_deferred property
Date: Tue, 30 Jun 2020 10:32:06 +0200 [thread overview]
Message-ID: <a48ab93c-0d9c-ed8b-76dd-62007826bf6f@samsung.com> (raw)
In-Reply-To: <CAHp75VdS_u8h4qfBxsQRUp1-2SL_hq20=dQkpteXH7Xg7epArQ@mail.gmail.com>
On 29.06.2020 18:36, Andy Shevchenko wrote:
> On Mon, Jun 29, 2020 at 2:22 PM Andrzej Hajda <a.hajda@samsung.com> wrote:
>> /sys/kernel/debug/devices_deferred property contains list of deferred devices.
>> This list does not contain reason why the driver deferred probe, the patch
>> improves it.
>> The natural place to set the reason is dev_err_probe function introduced recently,
>> ie. if dev_err_probe will be called with -EPROBE_DEFER instead of printk the message
>> will be attached to deferred device and printed when user read devices_deferred
> to a deferred
>
> reads
OK, thx.
>
>> property.
> ...
>
>> @@ -3984,10 +3986,12 @@ int dev_err_probe(const struct device *dev, int err, const char *fmt, ...)
>> vaf.fmt = fmt;
>> vaf.va = &args;
>>
>> - if (err != -EPROBE_DEFER)
>> + if (err != -EPROBE_DEFER) {
> Why not positive conditional? (Okay, I'm fine with either in this case)
I put more natural branch 1st.
>
>> dev_err(dev, "error %d: %pV", err, &vaf);
>> - else
>> + } else {
>> + device_set_deferred_probe_reson(dev, &vaf);
>> dev_dbg(dev, "error %d: %pV", err, &vaf);
>> + }
> To reduce churn, you may move {} addition to the first patch.
But then I need to explain why it is there :)
>
> ...
>
>> list_for_each_entry(curr, &deferred_probe_pending_list, deferred_probe)
>> - seq_printf(s, "%s\n", dev_name(curr->device));
>> + seq_printf(s, "%s\t%s", dev_name(curr->device),
>> + curr->device->p->deferred_probe_reason ?: "\n");
> Hmm... "\t" will be dangling in the latter case
Hmm, I followed your advice [1] :)
[1]:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1787370.html
Regards
Andrzej
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-30 8:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200629112247eucas1p2f5a1c0a4ffe3a2571658646a7b369cfd@eucas1p2.samsung.com>
2020-06-29 11:22 ` [PATCH v7 0/4] driver core: add probe error check helper Andrzej Hajda
[not found] ` <CGME20200629112248eucas1p187e5dac2f4f6120aacbc86e48ad0fff9@eucas1p1.samsung.com>
2020-06-29 11:22 ` [PATCH v7 1/4] driver core: add device probe log helper Andrzej Hajda
2020-06-29 16:38 ` Andy Shevchenko
[not found] ` <CGME20200702134434eucas1p233a3f66f5bdb4b97f4f49d2d43d45297@eucas1p2.samsung.com>
2020-07-02 13:44 ` [PATCH v8 2/5] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda
2020-07-10 13:31 ` Greg Kroah-Hartman
2020-07-10 15:25 ` Andrzej Hajda
2020-06-30 15:35 ` [PATCH v7 1/4] driver core: add device probe log helper Mark Brown
[not found] ` <CGME20200629112249eucas1p160b845444f8fbad96bdec41e9d3938da@eucas1p1.samsung.com>
2020-06-29 11:22 ` [PATCH v7 2/4] driver core: add deferring probe reason to devices_deferred property Andrzej Hajda
2020-06-29 16:36 ` Andy Shevchenko
2020-06-30 8:32 ` Andrzej Hajda [this message]
2020-06-30 10:00 ` Andy Shevchenko
[not found] ` <CGME20200629112249eucas1p12fc95f88729c12c78b1a5bfe32afad8f@eucas1p1.samsung.com>
2020-06-29 11:22 ` [PATCH v7 3/4] drm/bridge/sii8620: fix resource acquisition error handling Andrzej Hajda
[not found] ` <CGME20200629112250eucas1p162ce47eab8946c45357a7e2c03a6da9a@eucas1p1.samsung.com>
2020-06-29 11:22 ` [PATCH v7 4/4] drm/bridge: lvds-codec: simplify " Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a48ab93c-0d9c-ed8b-76dd-62007826bf6f@samsung.com \
--to=a.hajda@samsung.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andy.shevchenko@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=narmstrong@baylibre.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).