From: Philipp Zabel <p.zabel@pengutronix.de> To: Samuel Holland <samuel@sholland.org>, Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>, Jassi Brar <jassisinghbrar@gmail.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Ondrej Jirman <megous@megous.com>, Vasily Khoruzhick <anarsoul@gmail.com> Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 2/6] mailbox: sun6i-msgbox: Add a new mailbox driver Date: Mon, 13 Jan 2020 10:15:58 +0100 Message-ID: <a4ff0a8571895c65ed5c20abd0c332b0d92defab.camel@pengutronix.de> (raw) In-Reply-To: <20200113051852.15996-3-samuel@sholland.org> On Sun, 2020-01-12 at 23:18 -0600, Samuel Holland wrote: > Allwinner sun6i, sun8i, sun9i, and sun50i SoCs contain a hardware > message box used for communication between the ARM CPUs and the ARISC > management coprocessor. This mailbox contains 8 unidirectional > 4-message FIFOs. > > Add a driver for it, so it can be used for SCPI or other communication > protocols. > > Signed-off-by: Samuel Holland <samuel@sholland.org> > --- > drivers/mailbox/Kconfig | 9 + > drivers/mailbox/Makefile | 2 + > drivers/mailbox/sun6i-msgbox.c | 332 +++++++++++++++++++++++++++++++++ > 3 files changed, 343 insertions(+) > create mode 100644 drivers/mailbox/sun6i-msgbox.c > [...] > diff --git a/drivers/mailbox/sun6i-msgbox.c b/drivers/mailbox/sun6i-msgbox.c > new file mode 100644 > index 000000000000..15d6fd522dc5 > --- /dev/null > +++ b/drivers/mailbox/sun6i-msgbox.c > @@ -0,0 +1,332 @@ [...] > + reset = devm_reset_control_get_exclusive(dev, NULL); > + if (IS_ERR(reset)) { > + ret = PTR_ERR(reset); > + dev_err(dev, "Failed to get reset control: %d\n", ret); > + goto err_disable_unprepare; > + } > + > + /* > + * NOTE: We rely on platform firmware to preconfigure the channel > + * directions, and we share this hardware block with other firmware > + * that runs concurrently with Linux (e.g. a trusted monitor). > + * > + * Therefore, we do *not* assert the reset line if probing fails or > + * when removing the device. > + */ > + ret = reset_control_deassert(reset); > + if (ret) { > + dev_err(dev, "Failed to deassert reset: %d\n", ret); > + goto err_disable_unprepare; > + } Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply index Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-13 5:18 [PATCH v6 0/6] Allwinner sun6i message box support Samuel Holland 2020-01-13 5:18 ` [PATCH v6 1/6] dt-bindings: mailbox: Add a sun6i message box binding Samuel Holland 2020-01-13 9:30 ` Maxime Ripard 2020-01-13 22:38 ` Rob Herring 2020-01-13 5:18 ` [PATCH v6 2/6] mailbox: sun6i-msgbox: Add a new mailbox driver Samuel Holland 2020-01-13 9:15 ` Philipp Zabel [this message] 2020-02-13 2:02 ` Jassi Brar 2020-02-13 2:18 ` Samuel Holland 2020-02-15 3:48 ` Samuel Holland 2020-02-15 4:47 ` Jassi Brar 2020-02-15 6:19 ` [PATCH] mailbox: sun6i-msgbox: Remove unneeded FIFO status check Samuel Holland 2020-01-13 5:18 ` [PATCH v6 3/6] ARM: dts: sunxi: a83t: Add msgbox node Samuel Holland 2020-01-13 5:18 ` [PATCH v6 4/6] ARM: dts: sunxi: h3/h5: " Samuel Holland 2020-01-13 5:18 ` [PATCH v6 5/6] arm64: dts: allwinner: a64: " Samuel Holland 2020-01-13 5:18 ` [PATCH v6 6/6] arm64: dts: allwinner: h6: " Samuel Holland 2020-02-13 1:43 ` [PATCH v6 0/6] Allwinner sun6i message box support Samuel Holland
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a4ff0a8571895c65ed5c20abd0c332b0d92defab.camel@pengutronix.de \ --to=p.zabel@pengutronix.de \ --cc=anarsoul@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=jassisinghbrar@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sunxi@googlegroups.com \ --cc=mark.rutland@arm.com \ --cc=megous@megous.com \ --cc=mripard@kernel.org \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=wens@csie.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-ARM-Kernel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \ linux-arm-kernel@lists.infradead.org public-inbox-index linux-arm-kernel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git