From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56057C4338F for ; Wed, 25 Aug 2021 10:21:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2177C60EFF for ; Wed, 25 Aug 2021 10:21:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2177C60EFF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=0bLxzhD8oSOCT+181faa5jFbnGd2DL5+Iuj3vL/H7r4=; b=1bDjNekgqa5kPh8pYCt2S8Edfy s0DwnVeZcMFhYtmaFrArO3qoCxMNy+M8PH/xAkl2hNTM9hzoQMe2j5C4m6HOMnAOATXOHPPW67Tpt QGf1PR7epcQpF1/oTsTDpkXEdOadTTfciMmHLUQPAvwQYnvalPUdX4el7PlL/5uq8BGN3vyPoAv9W KF3Vb+W2GygMXMDIhLk4c2xLt/stlEavm7wX8Gy71/ytacsARKv0qn1JOiUoGTWSQjVThDKzlNI0h 3D5CZMmMhxSY6ZksT1x1h/9nSiNdR/WIqQP5kp461afVOYyfN8SWtBLgerybSuOrFfBDbSF0CAWEB 0WaV8gOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIpzY-006PqF-7j; Wed, 25 Aug 2021 10:18:44 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIpuh-006Nak-Ca for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 10:13:48 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 31D7331B; Wed, 25 Aug 2021 03:13:38 -0700 (PDT) Received: from [10.57.42.52] (unknown [10.57.42.52]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 307CE3F66F; Wed, 25 Aug 2021 03:13:36 -0700 (PDT) Subject: Re: [PATCH v2 7/9] perf cs-etm: Create ETE decoder To: Leo Yan Cc: mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, acme@kernel.org, suzuki.poulose@arm.com, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-8-james.clark@arm.com> <20210824083305.GE204566@leoy-ThinkPad-X240s> From: James Clark Message-ID: Date: Wed, 25 Aug 2021 11:13:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210824083305.GE204566@leoy-ThinkPad-X240s> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_031343_570132_BF90DA14 X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24/08/2021 09:33, Leo Yan wrote: >> +static void cs_etm_decoder__gen_ete_config(struct cs_etm_trace_params *params, >> + ocsd_ete_cfg *config) >> +{ >> + config->reg_configr = params->ete.reg_configr; >> + config->reg_traceidr = params->ete.reg_traceidr; >> + config->reg_idr0 = params->ete.reg_idr0; >> + config->reg_idr1 = params->ete.reg_idr1; >> + config->reg_idr2 = params->ete.reg_idr2; >> + config->reg_idr8 = params->ete.reg_idr8; >> + config->reg_devarch = params->ete.reg_devarch; >> + config->arch_ver = ARCH_AA64; > Just a nitpick: if we connect with patch 02, it implement function > cs_etm_decoder__get_etmv4_arch_ver(). We can extend it to a more > general function cs_etm_decoder__get_arch_ver(); this can allow us to > have a central place to calculate 'arch_ver' for different archs. > > I understand your patch doesn't want to mix things between ETMv4 and > ETE, either way is okay for me: Hi Leo, Yes that was one of the previous comments from Mike that the logic only applied to ETMv4 so I made it v4 specific. The other arch_vers are fixed at the moment. If we get a new one that needs changing depending on some config we can try to add a generic function. > > Reviewed-by: Leo Yan > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel