From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Branislav Rankov <Branislav.Rankov@arm.com>,
Marco Elver <elver@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Evgenii Stepanov <eugenis@google.com>,
linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Konovalov <andreyknvl@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Andrew Morton <akpm@linux-foundation.org>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v12 6/7] arm64: mte: Save/Restore TFSR_EL1 during suspend
Date: Tue, 9 Feb 2021 10:41:03 +0000 [thread overview]
Message-ID: <a6ac58ef-f437-8a77-d288-c4de3316692f@arm.com> (raw)
In-Reply-To: <20210208185635.GA13187@e121166-lin.cambridge.arm.com>
Hi Lorenzo,
thank you for your review.
On 2/8/21 6:56 PM, Lorenzo Pieralisi wrote:
>> u64 gcr_kernel_excl __ro_after_init;
>>
>> +static u64 mte_suspend_tfsr_el1;
> IIUC you need this per-CPU (core loses context on suspend-to-RAM but also
> CPUidle, S2R is single threaded but CPUidle runs on every core idle
> thread).
>
> Unless you sync/report it on enter/exit (please note: I am not familiar
> with MTE so it is just a, perhaps silly, suggestion to avoid
> saving/restoring it).
>
I thought about making it per cpu, but I concluded that since it is an
asynchronous tag fault it wasn't necessary.
But thinking at it from the statistical point of view what you are saying is
completely right, because we might end up in scenario in which we report the
fault on multiple cores when it happens on one or in a scenario in which we do
not report the potential fault at all.
I am going to update my code accordingly in the next version.
Thanks!
> Lorenzo
>
--
Regards,
Vincenzo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-02-09 10:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 16:56 [PATCH v12 0/7] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 1/7] arm64: mte: Add asynchronous " Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 2/7] kasan: Add KASAN mode kernel parameter Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 3/7] kasan: Add report for async mode Vincenzo Frascino
2021-02-09 7:39 ` kernel test robot
2021-02-09 11:32 ` Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 4/7] arm64: mte: Enable TCO in functions that can read beyond buffer limits Vincenzo Frascino
2021-02-09 11:35 ` Catalin Marinas
2021-02-09 11:45 ` Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 5/7] arm64: mte: Enable async tag check fault Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 6/7] arm64: mte: Save/Restore TFSR_EL1 during suspend Vincenzo Frascino
2021-02-08 18:56 ` Lorenzo Pieralisi
2021-02-09 10:41 ` Vincenzo Frascino [this message]
2021-02-09 11:55 ` Catalin Marinas
2021-02-09 14:33 ` Lorenzo Pieralisi
2021-02-09 14:54 ` Vincenzo Frascino
2021-02-09 17:28 ` Catalin Marinas
2021-02-09 18:25 ` Vincenzo Frascino
2021-02-08 16:56 ` [PATCH v12 7/7] kasan: don't run tests in async mode Vincenzo Frascino
2021-02-09 6:32 ` kernel test robot
2021-02-09 11:33 ` Vincenzo Frascino
2021-02-10 6:33 ` [kbuild-all] " Rong Chen
2021-02-09 12:02 ` Catalin Marinas
2021-02-09 12:20 ` Vincenzo Frascino
2021-02-09 15:02 ` Andrey Konovalov
2021-02-09 17:06 ` Catalin Marinas
2021-02-09 17:26 ` Andrey Konovalov
2021-02-09 17:37 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ac58ef-f437-8a77-d288-c4de3316692f@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=Branislav.Rankov@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=eugenis@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).