From: Matthias Brugger <matthias.bgg@gmail.com>
To: Bibby Hsieh <bibby.hsieh@mediatek.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>, CK HU <ck.hu@mediatek.com>
Cc: devicetree@vger.kernel.org,
Nicolas Boichat <drinkcat@chromium.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
srv_heupstream@mediatek.com,
Daoyuan Huang <daoyuan.huang@mediatek.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel@vger.kernel.org, Daniel Kurtz <djkurtz@chromium.org>,
Dennis-YC Hsieh <dennis-yc.hsieh@mediatek.com>,
linux-mediatek@lists.infradead.org,
Houlong Wei <houlong.wei@mediatek.com>,
Sascha Hauer <kernel@pengutronix.de>,
YT Shen <yt.shen@mediatek.com>,
Jiaguang Zhang <jiaguang.zhang@mediatek.com>,
linux-arm-kernel@lists.infradead.org, ginny.chen@mediatek.com
Subject: Re: [RESEND, PATCH v13 06/12] soc: mediatek: cmdq: clear the event in cmdq initial flow
Date: Fri, 23 Aug 2019 13:43:54 +0200 [thread overview]
Message-ID: <a7c2acbc-cfcd-9109-7ee8-4735cd344da6@gmail.com> (raw)
In-Reply-To: <29eb73c1-04f4-deec-3136-f22434e0e541@gmail.com>
On 23/08/2019 13:36, Matthias Brugger wrote:
>
>
> On 20/08/2019 10:49, Bibby Hsieh wrote:
>> GCE hardware stored event information in own internal sysram,
>> if the initial value in those sysram is not zero value
>> it will cause a situation that gce can wait the event immediately
>> after client ask gce to wait event but not really trigger the
>> corresponding hardware.
>>
>> In order to make sure that the wait event function is
>> exactly correct, we need to clear the sysram value in
>> cmdq initial flow.
>>
>> Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver")
>>
>> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
>> Reviewed-by: CK Hu <ck.hu@mediatek.com>
I oversaw some things/nits.
Patch subject should be:
mailbox: mediatek: cmdq: clear the event in cmdq initial flow
>> ---
>> drivers/mailbox/mtk-cmdq-mailbox.c | 5 +++++
>> include/linux/mailbox/mtk-cmdq-mailbox.h | 2 ++
>> include/linux/soc/mediatek/mtk-cmdq.h | 3 ---
>> 3 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
>> index 69daaadc3a5f..9a6ce9f5a7db 100644
>> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
>> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
>> @@ -21,6 +21,7 @@
>> #define CMDQ_NUM_CMD(t) (t->cmd_buf_size / CMDQ_INST_SIZE)
>>
>> #define CMDQ_CURR_IRQ_STATUS 0x10
>> +#define CMDQ_SYNC_TOKEN_UPDATE 0x68
>> #define CMDQ_THR_SLOT_CYCLES 0x30
>> #define CMDQ_THR_BASE 0x100
>> #define CMDQ_THR_SIZE 0x80
>> @@ -104,8 +105,12 @@ static void cmdq_thread_resume(struct cmdq_thread *thread)
>>
>> static void cmdq_init(struct cmdq *cmdq)
>> {
>> + int i;
>> +
>> WARN_ON(clk_enable(cmdq->clock) < 0);
>> writel(CMDQ_THR_ACTIVE_SLOT_CYCLES, cmdq->base + CMDQ_THR_SLOT_CYCLES);
>> + for (i = 0; i <= CMDQ_MAX_EVENT; i++)
>> + writel(i, cmdq->base + CMDQ_SYNC_TOKEN_UPDATE);
I think CMDQ_SYNC_TOKEN_UPDATE is not a good name for the define.
Any reason why we couldn't name it something like CMDQ_SYNC_TOKEN_RESET?
>> clk_disable(cmdq->clock);
>> }
>>
>> diff --git a/include/linux/mailbox/mtk-cmdq-mailbox.h b/include/linux/mailbox/mtk-cmdq-mailbox.h
>> index ccb73422c2fa..911475da7a53 100644
>> --- a/include/linux/mailbox/mtk-cmdq-mailbox.h
>> +++ b/include/linux/mailbox/mtk-cmdq-mailbox.h
>> @@ -19,6 +19,8 @@
>> #define CMDQ_WFE_UPDATE BIT(31)
>> #define CMDQ_WFE_WAIT BIT(15)
>> #define CMDQ_WFE_WAIT_VALUE 0x1
>> +/** cmdq event maximum */
While at it, add a new line before the comment.
Regards,
Matthias
>> +#define CMDQ_MAX_EVENT 0x3ff
>>
>> /*
>> * CMDQ_CODE_MASK:
>> diff --git a/include/linux/soc/mediatek/mtk-cmdq.h b/include/linux/soc/mediatek/mtk-cmdq.h
>> index 54ade13a9b15..4e8899972db4 100644
>> --- a/include/linux/soc/mediatek/mtk-cmdq.h
>> +++ b/include/linux/soc/mediatek/mtk-cmdq.h
>> @@ -13,9 +13,6 @@
>>
>> #define CMDQ_NO_TIMEOUT 0xffffffffu
>>
>> -/** cmdq event maximum */
>> -#define CMDQ_MAX_EVENT 0x3ff
>> -
>> struct cmdq_pkt;
>>
>> struct cmdq_client {
>>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-23 11:44 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 8:49 [RESEND, PATCH v13 00/12] support gce on mt8183 platform Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 01/12] dt-binding: gce: remove thread-num property Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 02/12] dt-binding: gce: add gce header file for mt8183 Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 03/12] dt-binding: gce: add binding for gce client reg property Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 04/12] mailbox: mediatek: cmdq: move the CMDQ_IRQ_MASK into cmdq driver data Bibby Hsieh
2019-08-23 11:32 ` Matthias Brugger
2019-08-20 8:49 ` [RESEND, PATCH v13 05/12] mailbox: mediatek: cmdq: support mt8183 gce function Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 06/12] soc: mediatek: cmdq: clear the event in cmdq initial flow Bibby Hsieh
2019-08-23 11:36 ` Matthias Brugger
2019-08-23 11:43 ` Matthias Brugger [this message]
2019-08-20 8:49 ` [RESEND, PATCH v13 07/12] soc: mediatek: cmdq: reorder the parameter Bibby Hsieh
2019-08-23 12:05 ` Matthias Brugger
2019-08-20 8:49 ` [RESEND, PATCH v13 08/12] soc: mediatek: cmdq: change the type of input parameter Bibby Hsieh
2019-08-23 12:09 ` Matthias Brugger
2019-08-20 8:49 ` [RESEND, PATCH v13 09/12] soc: mediatek: cmdq: define the instruction struct Bibby Hsieh
2019-08-20 9:39 ` houlong wei
2019-08-23 13:50 ` Matthias Brugger
2019-08-27 4:12 ` Bibby Hsieh
2019-08-27 10:04 ` Matthias Brugger
2019-08-20 8:49 ` [RESEND, PATCH v13 10/12] soc: mediatek: cmdq: add polling function Bibby Hsieh
2019-08-20 9:50 ` houlong wei
2019-08-23 14:05 ` Matthias Brugger
2019-08-27 4:07 ` Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 11/12] soc: mediatek: cmdq: add cmdq_dev_get_client_reg function Bibby Hsieh
2019-08-20 9:40 ` houlong wei
2019-08-20 9:47 ` houlong wei
2019-08-23 14:21 ` Matthias Brugger
2019-08-27 3:59 ` Bibby Hsieh
2019-08-27 10:13 ` Matthias Brugger
2019-08-28 8:32 ` Bibby Hsieh
2019-08-20 8:49 ` [RESEND, PATCH v13 12/12] arm64: dts: add gce node for mt8183 Bibby Hsieh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7c2acbc-cfcd-9109-7ee8-4735cd344da6@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=bibby.hsieh@mediatek.com \
--cc=ck.hu@mediatek.com \
--cc=daoyuan.huang@mediatek.com \
--cc=dennis-yc.hsieh@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=drinkcat@chromium.org \
--cc=ginny.chen@mediatek.com \
--cc=houlong.wei@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=jiaguang.zhang@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=yt.shen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).