linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Murali Karicheri <m-karicheri2@ti.com>,
	Jingoo Han <jingoohan1@gmail.com>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Gustavo Pimentel <gustavo.pimentel@synopsys.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] PCI: dwc: Add common iATU register support
Date: Mon, 28 Sep 2020 09:55:51 +0900	[thread overview]
Message-ID: <a7cbceee-aaee-e770-85a8-99ee2eab0466@socionext.com> (raw)
In-Reply-To: <aef56eed-3966-cb1b-75f3-4b5dffc710c8@socionext.com>

On 2020/09/25 18:10, Kunihiko Hayashi wrote:
> Hi Rob,
> 
> On 2020/09/24 0:57, Rob Herring wrote:
>> On Fri, Sep 11, 2020 at 05:50:02PM +0900, Kunihiko Hayashi wrote:
>>> This gets iATU register area from reg property that has reg-names "atu".
>>> In Synopsys DWC version 4.80 or later, since iATU register area is
>>> separated from core register area, this area is necessary to get from
>>> DT independently.
>>>
>>> Cc: Murali Karicheri <m-karicheri2@ti.com>
>>> Cc: Jingoo Han <jingoohan1@gmail.com>
>>> Cc: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
>>> Suggested-by: Rob Herring <robh@kernel.org>
>>> Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
>>> ---
>>>   drivers/pci/controller/dwc/pcie-designware.c | 8 +++++++-
>>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
>>> index 4d105ef..4a360bc 100644
>>> --- a/drivers/pci/controller/dwc/pcie-designware.c
>>> +++ b/drivers/pci/controller/dwc/pcie-designware.c
>>> @@ -10,6 +10,7 @@
>>>   #include <linux/delay.h>
>>>   #include <linux/of.h>
>>> +#include <linux/of_platform.h>
>>>   #include <linux/types.h>
>>>   #include "../../pci.h"
>>> @@ -526,11 +527,16 @@ void dw_pcie_setup(struct dw_pcie *pci)
>>>       u32 val;
>>>       struct device *dev = pci->dev;
>>>       struct device_node *np = dev->of_node;
>>> +    struct platform_device *pdev;
>>>       if (pci->version >= 0x480A || (!pci->version &&
>>>                          dw_pcie_iatu_unroll_enabled(pci))) {
>>>           pci->iatu_unroll_enabled = true;
>>> -        if (!pci->atu_base)
>>> +        pdev = of_find_device_by_node(np);
>>
>> Use to_platform_device(dev) instead. Put that at the beginning as I'm
>> going to move 'dbi' in here too.
> 
> Okay, I'll rewrite it with to_platform_device(dev).
> Should I refer somewhere to rebase to your change?
It seems there is no dbi patch yet, so I'm going to send v2 in advance
for now. I can rebase it if necessary.

Thank you,

---
Best Regards
Kunihiko Hayashi

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-28  0:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-11  8:50 [PATCH 0/3] PCI: dwc: Move iATU register mapping to common framework Kunihiko Hayashi
2020-09-11  8:50 ` [PATCH 1/3] dt-bindings: PCI: uniphier: Add iATU register description Kunihiko Hayashi
2020-09-11  8:50 ` [PATCH 2/3] PCI: dwc: Add common iATU register support Kunihiko Hayashi
2020-09-23 15:57   ` Rob Herring
2020-09-25  9:10     ` Kunihiko Hayashi
2020-09-28  0:55       ` Kunihiko Hayashi [this message]
2020-09-11  8:50 ` [PATCH 3/3] PCI: keystone: Remove iATU register mapping Kunihiko Hayashi
2020-09-23 15:57   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7cbceee-aaee-e770-85a8-99ee2eab0466@socionext.com \
    --to=hayashi.kunihiko@socionext.com \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=jingoohan1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=m-karicheri2@ti.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).