From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24264C07E95 for ; Tue, 13 Jul 2021 09:45:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9940610D1 for ; Tue, 13 Jul 2021 09:45:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9940610D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=APx4T81naLRNFCRq3lQD1E1IyV5NoDth8peL2qh3vl0=; b=ODdZ5isEp4rIy3ZGL92XCzMhlh YIGVdRwIY25o1QO1mZ9+QNPMHjNBCDizFHADhKcSpRdsoEA0MH/6STqs0OX3gN4GhdM7ECs+4Kdpk 17mgDyhTi9BSXzIFAyrN+S+eNcPeSd1b4zwLtzDPxWdlN/Cr7BOhvoUggwe1AqHp0RpmMf+kVO2d2 V+z14J3blipBhzUqR53mF3R8nKVftrpCRxghd6G9QLiu0hk4ixoPNc+dTxM9pTreZsabKk1qXm5wH jIKIi4ga37QhsxFDshOdYzpdn7+AHtuUKPb//iGPZHi40ja/nFdE4wEE7KzY/zhq6OAaARR+ZX6rd rVzZolxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3Ews-009gkQ-41; Tue, 13 Jul 2021 09:43:30 +0000 Received: from mail-eopbgr130045.outbound.protection.outlook.com ([40.107.13.45] helo=EUR01-HE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m3Ewm-009giN-Va for linux-arm-kernel@lists.infradead.org; Tue, 13 Jul 2021 09:43:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ux5ZeEaFo3r61B/a/+3K9BuN2nuqlumS7H5Iee7Fqyg=; b=AuVtXtDo6ruxfOR6pfovRkBHH59UByZ3KL4oYpmrT7RzuhzLUBf/Li0rq18Wigt7ge/TMPW7sNZgyQ3qNqIeV0hoOwLpY4suROprnhFTv7i3kKOLrqfOaN2D7dMqzPxJnH2MRgeD5o0uEKEk4xJNAScqyUST2FRx8hjDdntm2OI= Received: from PR3P189CA0018.EURP189.PROD.OUTLOOK.COM (2603:10a6:102:52::23) by DBBPR08MB4329.eurprd08.prod.outlook.com (2603:10a6:10:c7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Tue, 13 Jul 2021 09:43:19 +0000 Received: from VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com (2603:10a6:102:52:cafe::56) by PR3P189CA0018.outlook.office365.com (2603:10a6:102:52::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Tue, 13 Jul 2021 09:43:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; lists.infradead.org; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;lists.infradead.org; dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT036.mail.protection.outlook.com (10.152.19.204) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Tue, 13 Jul 2021 09:43:18 +0000 Received: ("Tessian outbound 17c2a40a31ce:v98"); Tue, 13 Jul 2021 09:43:18 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 99cddf1770bb61f0 X-CR-MTA-TID: 64aa7808 Received: from a95075073d94.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 231B3E0E-77EF-49C8-8E25-2EC0BBDD8419.1; Tue, 13 Jul 2021 09:42:59 +0000 Received: from EUR05-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a95075073d94.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Jul 2021 09:42:59 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/JsV9VUylnhxXTJ2DdYB628b2fJ1vCMDspRqi3njAfcRTfNw+vBMj2SjfinCmDSOeQ3jhNL7LdMo4pgj9C+yPP4VRso+U/nWo46QLF3fLnI5w9e3HZxYO+v3i7OlqTp/nAZElC8HFoTaKdvfpm7XdbKYeE98EMXrBjtjZLifhnpG0eGu4ehgl9epqNDADRIlQGia3VX0hiEURl0jwv/IAv2MBB+sXLoMDFLyA7vQLhhcWFpC2jRJXlsoe7i9sEbcc3llGDv+bp4Dr5L/+iErHmEjqH8YuphE/D+czMoejh2KyK/dXqqxHjHWAArrwqoyNnDDjHeLc3bkVV8G7fQ0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ux5ZeEaFo3r61B/a/+3K9BuN2nuqlumS7H5Iee7Fqyg=; b=i1g0U9otAQnBmOMrM4Dh+JRk9cXWX9g8fhDUlKtONSRORDp2kKAa8MzF+w+3ymNbJoc6eTY2K2piJf6jfaC9lELKImDVGuxU2/CFddESzm0A17y9H4vW959iHemCW4rp04z0/1vUuqamCIJRBRfd/PfoRuSArqv4RWU/AfjOtneZle6yYiGxLktIdBZNi1JO8f1oWxTAt/24vMAsqm8QJuSyUImJj35mlLsHxXUJ5xthGzbGD1kN1cAMNaiFGzR4kDmGwj3zlSbaWl54xEQzxOk6W++fz7mkwTWezvx8LNBJSQaq4y0RUtHtXc/UPIX55Qy1NsM6HJy7D29LqY4DvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ux5ZeEaFo3r61B/a/+3K9BuN2nuqlumS7H5Iee7Fqyg=; b=AuVtXtDo6ruxfOR6pfovRkBHH59UByZ3KL4oYpmrT7RzuhzLUBf/Li0rq18Wigt7ge/TMPW7sNZgyQ3qNqIeV0hoOwLpY4suROprnhFTv7i3kKOLrqfOaN2D7dMqzPxJnH2MRgeD5o0uEKEk4xJNAScqyUST2FRx8hjDdntm2OI= Authentication-Results-Original: lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6069.eurprd08.prod.outlook.com (2603:10a6:20b:29c::13) by AM5PR0801MB1841.eurprd08.prod.outlook.com (2603:10a6:203:2e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23; Tue, 13 Jul 2021 09:42:56 +0000 Received: from AS8PR08MB6069.eurprd08.prod.outlook.com ([fe80::4cb0:5d8d:26b4:a9c5]) by AS8PR08MB6069.eurprd08.prod.outlook.com ([fe80::4cb0:5d8d:26b4:a9c5%4]) with mapi id 15.20.4287.033; Tue, 13 Jul 2021 09:42:56 +0000 Subject: Re: [PATCH v8 00/10] CoreSight configuration management; ETM strobing To: Mathieu Poirier , Mike Leach Cc: alexander.shishkin@linux.intel.com, gregkh@linuxfoundation.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210707133003.5414-1-mike.leach@linaro.org> <20210712164413.GA1777012@p14s> From: Branislav Rankov Message-ID: Date: Tue, 13 Jul 2021 10:42:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <20210712164413.GA1777012@p14s> Content-Language: en-US X-ClientProxiedBy: LO2P265CA0006.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::18) To AS8PR08MB6069.eurprd08.prod.outlook.com (2603:10a6:20b:29c::13) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.57.35.153] (217.140.99.251) by LO2P265CA0006.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:62::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Tue, 13 Jul 2021 09:42:56 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 778fe924-f999-42eb-1d41-08d945e2a540 X-MS-TrafficTypeDiagnostic: AM5PR0801MB1841:|DBBPR08MB4329: X-LD-Processed: f34e5979-57d9-4aaa-ad4d-b122a662184d,ExtAddr X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Oob-TLC-OOBClassifiers: OLM:10000;OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: LT80mFmU3ryMnQ6LzVxYTHF9DiknvYdxQfuFp2V1OKCyBfx7ctLcVA5gRC6MucZMP7JaELYqKlHKxDJur+exuqTk1o/d4KqxDLha5XABwNK1kkfeDj+XvvOzjoGJO2XTIGM5aaQZKTTL70nZk9RD4Un1xsY50sSqZzoPbMgQWvK0Uzih++8ohq4wd1oBFbUAgb55j+T99ET4WdHZ7CAqN4ySdL0S9mzIvmIEGfsmqVBVkvupRipvdQIf4pEaJ3/Z9eDqUptC4IOvZiQr5m9HcWFuNXgipBjUqQueThsbti4I5An1J/A32LexbJM6UoLu8zC8ZfZ9CcM+JiZKiH4o1uhyEYZlqEcMUY+7B4qzLHZMIFqgkXzToYoUesuBbf8joEns8uF66ymqoZfmGrT8aaTiMDVTUdpVO/SVkwtS5Wx/EEKCOG7dla/BIZDwqc2+lTBnZQ4HkQS9sic317dKoSmyFk97NC//J/WEpYqXDsxti0Tb12q8lCeOQ5Cv2bFJyvuheG69z7sDuAyX+pIf3Dneby2YIZ3n9gur7hYY8LLVXz9AKlDgyhkDPiEulDkM5Pw6sGLtrEtDDeGmSVROS2RiQTuv07NiohD7wCRUdKwS4RhfOGNQW5eTs9N1/A+hzSFAZUNsJaLdr+Ixr3IeyYVruqmN52Jiv92Syz/LzO0+Vrld0dmXsHJ5bjNuTYFHO3YN7jN9LpI9LCyQ2tiGySJSDZt/rYxc5hNFci7vDN1lFPzEDKgZJ6drD6bnYxBSEjsI6vJUo5g/7dkxP0X5gOu0drK5wje/3g+FY/9UbjI9CK/8Zri6HUmL2uIUfmMn X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR08MB6069.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(396003)(39860400002)(376002)(36756003)(66946007)(186003)(956004)(966005)(6486002)(83380400001)(16576012)(38100700002)(5660300002)(66476007)(478600001)(2906002)(66556008)(53546011)(86362001)(44832011)(31686004)(8936002)(31696002)(316002)(26005)(2616005)(6666004)(30864003)(8676002)(110136005)(4326008)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VTV6dTZTUlRzSWFqOUFQL3NJOERjb0d0ODF2c0pWWkh6ZG9reVV6NU9oOHNS?= =?utf-8?B?YVphOVZJbERxKzl4aGdONUlpNWorQ2RhVmplaGxuS1FEdzkzbXVYQm56ODlR?= =?utf-8?B?dVNJVVZJd3RiTFR3cXBJbTVSWTE1VWsxRWU3cURVUjdLTS9iNUNEL2JUaElm?= =?utf-8?B?eE40WC9rcEJ4U1YzSzYxOUFzdmFpdTlTQk1DMVZRMEdhRXFueCttbUJNRDRL?= =?utf-8?B?VkFsMml4V0pFL0hMbEtLMThSdTNXaFdiaHg1Qk1EcW1FYzRlWHJsQjY2UE93?= =?utf-8?B?ZGZFVGxyKzdFZDZWYzNjQ0xab2JaMEZDbVl3ODYzOWZMNC8yclA3ajJKZ0Fy?= =?utf-8?B?WURuRjUxNyt2SUZwZnFpNlorWlFtdkhON2x3RnZYRlRiK1FmUTRPT3ZFUXp1?= =?utf-8?B?eXNNVHJ3WmlDdHlxQTBWY3k1eE8vUmVMdVRXOC8rQlNZSk1zSFcyTjZFNFB0?= =?utf-8?B?emZ4QmdBejZuMUZST045VC90LzBwN3hhRjg3Zm0zQVBDdk5BbXV3RnMwTHlQ?= =?utf-8?B?T0xyU1JpSjRwcFgxSWZaTFB6Y0NnendzTWhBTi9LeVlnK1cybS9FQ2JzUkJV?= =?utf-8?B?U3RwSjQ1bjNHWFVQQ2J5dkd3NzU0dngrVEhCY3ZIZEZGMUhZWjdtUitKckl3?= =?utf-8?B?OHE5WE9OMmkveHRlTTRyL2pBVHdaN09wWFA2M2xmR09VbXNwWVN0V2d6RXpN?= =?utf-8?B?eDFzeERxSGRaeWM0c2hqMm1qbEtlKy9RcFZiSC9ZV3dVb2hmMDVnVlJ6c2ZZ?= =?utf-8?B?Q3d0ZndJd0FobFA0Wmx2ZXpvU04wbEYzZlNQVWJ3ZXZHV011d3Jra3BLVVhF?= =?utf-8?B?OGNldml6NFZWc3U3Ukxqd0xTTGNRMVRCczd0Tk5hZU9sNDBqQjR6bys2VGpF?= =?utf-8?B?RmpQVDJrdlQvTUlkWmt1alFJeElXMU54V3g2c1lVSFJLU08zcm1QMFUzM09y?= =?utf-8?B?UndXUTR0Wld3Z2NFTzJod1lVZXJaUldnR2htWHNaUGU5Mm1Rc3o3SGV5MWpR?= =?utf-8?B?UktKMElxZWswYzZwaG5pTEFLUUFPdHprZXpMNWIwUlpzS2hySktJQU55K0R1?= =?utf-8?B?SFUwTDdWSWNjaFlNVHRpUHdycG5RQ3hyYk9oQlk1Qzh0dFNtcTkrZEtqVnlh?= =?utf-8?B?NXUyVXdVaWswRXVFd3VSRGdJUXUzU0VYYkRobU5SazRsWEI1SmdsMHl0c3I4?= =?utf-8?B?WEFoY0hYbEpBbHNyRGpjbWtCbm1ER2xhOTA2M3IrUTJ1OUtqLzlVbW10UCt2?= =?utf-8?B?ZXdGdFZZdzdhQnZrNVM3aW5IUU5mclgzNlk1MmRjUzgvTThGVUpmL3BvUVpZ?= =?utf-8?B?NllOUlQ3N1pIOC9ZZzcrSXpaUVhiakFCTjErYmFjei95NytEMVhoc2dtUU5t?= =?utf-8?B?a3p1V2NjYnZKTjRZVTROR1N3aHUwZm1tQ3Nra25CYVBRZlUya1lSUmQxNVVW?= =?utf-8?B?MmJnV0p3VThXT09NZ3dlckJvNlRBKzJPK2kzVE4rQUlUdlB2b3NjUWF4cE1i?= =?utf-8?B?UVRya2M4T29jVXNsWHRtcklGQTJUNmZ4eFBDV3RqMW1haEtBc0hRb0lQN3NC?= =?utf-8?B?V0pjZzhtaHl2TFA1Z1I1RzlYWlZlS0FRWHlwMkR1K2lQRlVZQnN0VlRQTmJX?= =?utf-8?B?SzhkbDV3ZDZ4NVhxcnVZWmhFSEJLM2lubVRJVGNPY09oY3dDMkVrTDJ6V09Q?= =?utf-8?B?RzhzeEpIVU5oUldaNmljOVFvWTZLekhyNnBPZld3ZFVDZm5aSW9IWW1CYnpz?= =?utf-8?Q?WY9MreU1582emWQPQHOgEr/Ns8jpE99UFLhQAnC?= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0801MB1841 Original-Authentication-Results: lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Office365-Filtering-Correlation-Id-Prvs: af1f5df9-d2fa-4425-2bdb-08d945e297dc X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GLvT9QdiBosEd/fFQq9tZCfcnamohyum5HYQ29J8oPfpUicjtBzSH/7esLmjhedGnnfJQ4LEPsXCgTceY4ok/ohKURx3FjjejF9CZ4dcJibK7vGriMOy7Pgbl0+P5ocx/xGNh5q4Pu8L2DBdtWUt9/FGpX+47LjukLrzrvNmBoBX0A9PNFRHvJqiWl0soVTE432Ito5oU3SqhAQUY7zxPQLVJ3gHcTk1qs96r8kSS3yp/2XpmKjj06tdHcgpjiV8yYhbPO8H04axTK++1mYZP5TeyWjcta4/NSQFJLZWvWQaquIqiPBeI10EnCDwXsPYhtnbXMAmX+2KhTc99woXMdIu9JyunhDd7AjmesYb71nQLot5pMZ0kUjVggfhuv8QjWr7no/t8tUjCFntebMF9ok7cMw13eULV/U1MxiyjQLec+bNdE8esiYukwv96e8JZ7u8w048LdbaU66H3aBk269ekFE05BnDN1EOChjX4wIujo1yfqhETCcthqzAeNpt9YCmdVfpttPqnm5jrXA3dO6NssAS+TUiMwJVJBvb7yg63O1GWLWeYDRsph8i3pyanYS1vvG9yaDYxJ0oVKg6ZDX17MNNjYgBXn8w3di+kIsNfhqyepClA0a3f5UrVnIq5DD1KUC+DTlsqoj5TIgqnB/XtK6K7aa47Oj72cRBIJt71Rn6uMrkCDGdhEVoBdB8+mRCdGP046zvKZZDDezHyzm6lZ5XVzAulqb3+yZqeI9XN3vz9z/k7LL39c+Ea0rkGyef7tdMxf26KKt8iXGdHpADMVuvLaFsuZs6zDz36lC3FOCQnur9wi6Ghzdwgli1 X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(39860400002)(376002)(46966006)(36840700001)(110136005)(82740400003)(70206006)(8676002)(30864003)(31686004)(478600001)(316002)(6486002)(82310400003)(36860700001)(16576012)(47076005)(86362001)(186003)(83380400001)(2906002)(6666004)(966005)(36756003)(8936002)(336012)(31696002)(4326008)(26005)(81166007)(5660300002)(44832011)(956004)(2616005)(53546011)(356005)(70586007)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2021 09:43:18.5844 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 778fe924-f999-42eb-1d41-08d945e2a540 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT036.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4329 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210713_024325_353312_85A80014 X-CRM114-Status: GOOD ( 16.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mathieu, On 7/12/21 5:44 PM, Mathieu Poirier wrote: > Good morning Mike, > > On Wed, Jul 07, 2021 at 02:29:53PM +0100, Mike Leach wrote: >> This patchset introduces initial concepts in CoreSight system >> configuration management support. to allow more detailed and complex >> programming to be applied to CoreSight systems during trace capture. >> >> Configurations consist of 2 elements:- >> 1) Features - programming combinations for devices, applied to a class of >> device on the system (all ETMv4), or individual devices. >> 2) Configurations - a set of programmed features used when the named >> configuration is selected. >> >> Features and configurations are declared as a data table, a set of register, >> resource and parameter requirements. Features and configurations are loaded >> into the system by the virtual cs_syscfg device. This then matches features >> to any registered devices and loads the feature into them. >> >> Individual device classes that support feature and configuration register >> with cs_syscfg. >> >> Once loaded a configuration can be enabled for a specific trace run. >> Configurations are registered with the perf cs_etm event as entries in >> cs_etm/events. These can be selected on the perf command line as follows:- >> >> perf record -e cs_etm// ... >> >> This patch set has one pre-loaded configuration and feature. >> A named "strobing" feature is provided for ETMv4. >> A named "autofdo" configuration is provided. This configuration enables >> strobing on any ETM in used. >> >> Thus the command: >> perf record -e cs_etm/autofdo/ ... >> >> will trace the supplied application while enabling the "autofdo" configuation >> on each ETM as it is enabled by perf. This in turn will enable strobing for >> the ETM - with default parameters. Parameters can be adjusted using configfs. >> >> The sink used in the trace run will be automatically selected. >> >> A configuration can supply up to 15 of preset parameter values, which will >> subsitute in parameter values for any feature used in the configuration. >> >> Selection of preset values as follows >> perf record -e cs_etm/autofdo,preset=1/ ... >> >> (valid presets 1-N, where N is the number supplied in the configuration, not >> exceeding 15. preset=0 is the same as not selecting a preset.) >> >> Applies to & tested against coresight/next (5.13-rc6 base) >> >> Changes since v7: >> >> Fixed kernel test robot issue - config with CORESIGHT=y & CONFIGFS_FS=m causes >> build error. Altered CORESIGHT config to select CONFIGFS_FS. >> Reported-by: kernel test robot >> >> Replaced mutex use to protect loaded config lists in coresight devices with per >> device spinlock to remove issue when disable called in interrupt context. >> Reported-by: Branislav Rankov >> > > Can you indicate which patches have changed so I don't have to review the whole > thing again? It is also common practice to remove the RB tag when patches > have changed enough to mandate another review. In this case all patches still > bare my RB tags. > > Branislav reported the problem but he is not a recipient. I would like to have > a confirmation from him that this set fixes the problem he observed before I > start looking at it. I have tested this series and the issue I reported is fixed. > > Thanks, > Mathieu > >> >> Changes since v6: >> Fixed kernel test robot issues- >> Reported-by: kernel test robot >> >> Changes since v5: >> >> 1) Fix code style issues from auto-build reports, as >> Reported-by: kernel test robot >> 2) Update comments to get consistent docs for API functions. >> 3) remove unused #define from autofdo example. >> 4) fix perf code style issues from patch 4 (Mathieu) >> 5) fix configfs code style issues from patch 9. (Mathieu) >> >> Changes since v4: (based on comments from Matthieu and Suzuki). >> No large functional changes - primarily code improvements and naming schema. >> 1) Updated entire set to ensure a consistent naming scheme was used for >> variables and struct members that refer to the key objects in the system. >> Suffixes _desc used for all references to feature and configuraion descriptors, >> suffix _csdev used for all references to load feature and configs in the csdev >> instances. (Mathieu & Suzuki). >> 2) Dropped the 'configurations' sub dir in cs_etm perf directories as superfluous >> with the configfs containing the same information. (Mathieu). >> 3) Simplified perf handling code (suzuki) >> 4) Multiple simplifications and improvements for code readability (Matthieu >> and Suzuki) >> >> Changes since v3: (Primarily based on comments from Matthieu) >> 1) Locking mechanisms simplified. >> 2) Removed the possibility to enable features independently from >> configurations.Only configurations can be enabled now. Simplifies programming >> logic. >> 3) Configuration now uses an activate->enable mechanism. This means that perf >> will activate a selected configuration at the start of a session (during >> setup_aux), and disable at the end of a session (around free_aux) >> The active configuration and associated features will be programmed into the >> CoreSight device instances when they are enabled. This locks the configuration >> into the system while in use. Parameters cannot be altered while this is >> in place. This mechanism will be extended in future for dynamic load / unload >> of configurations to prevent removal while in use. >> 4) Removed the custom bus / driver as un-necessary. A single device is >> registered to own perf fs elements and configfs. >> 5) Various other minor issues addressed. >> >> Changes since v2: >> 1) Added documentation file. >> 2) Altered cs_syscfg driver to no longer be coresight_device based, and moved >> to its own custom bus to remove it from the main coresight bus. (Mathieu) >> 3) Added configfs support to inspect and control loaded configurations and >> features. Allows listing of preset values (Yabin Cui) >> 4) Dropped sysfs support for adjusting feature parameters on the per device >> basis, in favour of a single point adjustment in configfs that is pushed to all >> device instances. >> 5) Altered how the config and preset command line options are handled in perf >> and the drivers. (Mathieu and Suzuki). >> 6) Fixes for various issues and technical points (Mathieu, Yabin) >> >> Changes since v1: >> 1) Moved preloaded configurations and features out of individual drivers. >> 2) Added cs_syscfg driver to manage configurations and features. Individual >> drivers register with cs_syscfg indicating support for config, and provide >> matching information that the system uses to load features into the drivers. >> This allows individual drivers to be updated on an as needed basis - and >> removes the need to consider devices that cannot benefit from configuration - >> static replicators, funnels, tpiu. >> 3) Added perf selection of configuarations. >> 4) Rebased onto the coresight module loading set. >> >> To follow in future revisions / sets:- >> a) load of additional config and features by loadable module. >> b) load of additional config and features by configfs >> c) enhanced resource management for ETMv4 and checking features have sufficient >> resources to be enabled. >> d) ECT and CTI support for configuration and features. >> >> Mike Leach (10): >> coresight: syscfg: Initial coresight system configuration >> coresight: syscfg: Add registration and feature loading for cs devices >> coresight: config: Add configuration and feature generic functions >> coresight: etm-perf: update to handle configuration selection >> coresight: syscfg: Add API to activate and enable configurations >> coresight: etm-perf: Update to activate selected configuration >> coresight: etm4x: Add complex configuration handlers to etmv4 >> coresight: config: Add preloaded configurations >> coresight: syscfg: Add initial configfs support >> Documentation: coresight: Add documentation for CoreSight config >> >> .../trace/coresight/coresight-config.rst | 244 ++++++ >> Documentation/trace/coresight/coresight.rst | 16 + >> drivers/hwtracing/coresight/Kconfig | 1 + >> drivers/hwtracing/coresight/Makefile | 7 +- >> .../hwtracing/coresight/coresight-cfg-afdo.c | 153 ++++ >> .../coresight/coresight-cfg-preload.c | 31 + >> .../coresight/coresight-cfg-preload.h | 13 + >> .../hwtracing/coresight/coresight-config.c | 275 ++++++ >> .../hwtracing/coresight/coresight-config.h | 253 ++++++ >> drivers/hwtracing/coresight/coresight-core.c | 12 +- >> .../hwtracing/coresight/coresight-etm-perf.c | 150 +++- >> .../hwtracing/coresight/coresight-etm-perf.h | 12 +- >> .../hwtracing/coresight/coresight-etm4x-cfg.c | 182 ++++ >> .../hwtracing/coresight/coresight-etm4x-cfg.h | 30 + >> .../coresight/coresight-etm4x-core.c | 38 +- >> .../coresight/coresight-etm4x-sysfs.c | 3 + >> .../coresight/coresight-syscfg-configfs.c | 396 +++++++++ >> .../coresight/coresight-syscfg-configfs.h | 45 + >> .../hwtracing/coresight/coresight-syscfg.c | 829 ++++++++++++++++++ >> .../hwtracing/coresight/coresight-syscfg.h | 81 ++ >> include/linux/coresight.h | 11 + >> 21 files changed, 2746 insertions(+), 36 deletions(-) >> create mode 100644 Documentation/trace/coresight/coresight-config.rst >> create mode 100644 drivers/hwtracing/coresight/coresight-cfg-afdo.c >> create mode 100644 drivers/hwtracing/coresight/coresight-cfg-preload.c >> create mode 100644 drivers/hwtracing/coresight/coresight-cfg-preload.h >> create mode 100644 drivers/hwtracing/coresight/coresight-config.c >> create mode 100644 drivers/hwtracing/coresight/coresight-config.h >> create mode 100644 drivers/hwtracing/coresight/coresight-etm4x-cfg.c >> create mode 100644 drivers/hwtracing/coresight/coresight-etm4x-cfg.h >> create mode 100644 drivers/hwtracing/coresight/coresight-syscfg-configfs.c >> create mode 100644 drivers/hwtracing/coresight/coresight-syscfg-configfs.h >> create mode 100644 drivers/hwtracing/coresight/coresight-syscfg.c >> create mode 100644 drivers/hwtracing/coresight/coresight-syscfg.h >> >> -- >> 2.17.1 >> > _______________________________________________ > CoreSight mailing list > CoreSight@lists.linaro.org > https://lists.linaro.org/mailman/listinfo/coresight > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel