From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4305DC43463 for ; Fri, 18 Sep 2020 15:49:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B876323787 for ; Fri, 18 Sep 2020 15:49:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="0OiaKplT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B876323787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=HRvctfeU8pvshwEAahztdwTFB+eg2EFgeyV82Jk4w10=; b=0OiaKplTq+ensfglpmavwBRhE KuJN1/x3DchPLpjHq9pejcGhedaSXn5vVgnYt7cdcwOBJnDCIyZjtdA/mz56y+Gn4FMznlP8TVA++ NHtI5ASN5WneK9CPyvzuIwoGA3kio21WneqhzAXj2m2oqZYu9/T68T3/z7iECKjXjl5x7+VtVDFxP /xaLVIIrCzBqUSfpJCOnLRtUVkcc5P0G5UBE8uLVqa6cgL3ZJxrmBQl70MyE/il7AD7IbOblGzZU6 0pwqHYyX39+44Vm47K04CWsT+5J29n53x0hJzxzmKL/CV/jpxXdcEm/nqCeDCblxFz7KrEP7RDthK LSoew4moQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIcd-0002sb-7n; Fri, 18 Sep 2020 15:48:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJIcZ-0002qr-Al for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 15:48:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A478E1045; Fri, 18 Sep 2020 08:48:21 -0700 (PDT) Received: from [10.57.51.251] (unknown [10.57.51.251]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 35F0A3F73B; Fri, 18 Sep 2020 08:48:20 -0700 (PDT) Subject: Re: [PATCH 05/19] coresight: Use device access layer for Software lock/unlock operations To: mike.leach@linaro.org References: <20200911084119.1080694-1-suzuki.poulose@arm.com> <20200911084119.1080694-6-suzuki.poulose@arm.com> From: Suzuki K Poulose Message-ID: Date: Fri, 18 Sep 2020 16:52:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_114823_443603_072F5F80 X-CRM114-Status: GOOD ( 19.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: coresight@lists.linaro.org, anshuman.khandual@arm.com, mathieu.poirier@linaro.org, linux-arm-kernel@lists.infradead.org, leo.yan@linaro.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 09/18/2020 04:34 PM, Mike Leach wrote: > Hi Suzuki, > > On Fri, 11 Sep 2020 at 09:41, Suzuki K Poulose wrote: >> >> Convert CS_LOCK/UNLOCK operations to use the device access layer. >> >> Cc: Mathieu Poirier >> Cc: Mike Leach >> Signed-off-by: Suzuki K Poulose >> --- >> >> diff --git a/drivers/hwtracing/coresight/coresight-cpu-debug.c b/drivers/hwtracing/coresight/coresight-cpu-debug.c >> index 96544b348c27..5d5619284866 100644 >> --- a/drivers/hwtracing/coresight/coresight-cpu-debug.c >> +++ b/drivers/hwtracing/coresight/coresight-cpu-debug.c >> @@ -108,6 +108,20 @@ static bool debug_enable; >> module_param_named(enable, debug_enable, bool, 0600); >> MODULE_PARM_DESC(enable, "Control to enable coresight CPU debug functionality"); >> >> +static inline void coresight_debug_lock(struct debug_drvdata *drvdata) >> +{ >> + struct csdev_access dummy = CSDEV_ACCESS_IOMEM(drvdata->base); >> + >> + CS_LOCK(&dummy); >> +} >> + >> +static void coresight_debug_unlock(struct debug_drvdata *drvdata) >> +{ >> + struct csdev_access dummy = CSDEV_ACCESS_IOMEM(drvdata->base); >> + >> + CS_UNLOCK(&dummy); >> +} >> + > > Perhaps it's just me, but whenever I see "dummy" in code, I > immediately think this is stubbed out and doing nothing. > No, you are not alone. I will change it to something sensible. >> > > Reviewed by: Mike Leach Thanks for the review Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel