From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B03E3C433DB for ; Mon, 22 Mar 2021 12:36:07 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3AF9D619B6 for ; Mon, 22 Mar 2021 12:36:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3AF9D619B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monstr.eu Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GsuiA9JRELgrk4Vm305ieyTde2+t6F6Ep9WR+xHJZ1I=; b=JoVf+mchKfQeiVYteb7nUWecW PYyvGj4pdS87PHYTLSWamSe6iqlWvGgRr4ZcuvJz43mTi4gcILg7FAUEk0oAOCgbXPiHIZVRZUXN5 CiLblj2iHjwvnORhnCkHLHhMzbq0s0lJuKO64pZ9KeYFIL69KQGOLags1DoQaG/2/6dpaoBRjbY/7 BEOWlTQBnBrvrtpdE1toNIE5ggRdeHCmPvbq0NRZqOUfHw6KkJgmq6fQXeGAWHelfJVOKMh3y0P6X 5vfUuUbX3OEajKvXEFOAcdAutqdPXX0GSJl16drUQUB4N96mlb3eYazoUiNktSUdlJu5UPk8P1OIV VvWMHlF1Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lOJkb-00BavI-33; Mon, 22 Mar 2021 12:33:41 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lOJkP-00BatW-NR for linux-arm-kernel@lists.infradead.org; Mon, 22 Mar 2021 12:33:31 +0000 Received: by mail-ed1-x534.google.com with SMTP id e7so19041712edu.10 for ; Mon, 22 Mar 2021 05:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bFXSCk7jXzi1oDqUKnupFbkdc1ED5SojZj7S5YlWylo=; b=Nb6vq2/ii4Uu5XEatx9s0w0vyMHBFNdJ9XkyhRXQRTYCa2DlOgNpuMLBtGI32mU4LR mM7dCOyOsSQiBYx78D9Tou6WPJCLVJK2++P19JKJpLnY6jpQoN++z2bIdKzEKPwiTfB8 flKUIx/jPAbEh+WGHPcfHxffQaeLfuKX6yZiKFKqfDTbAz9SFCQqpEeOUdO2QyBtYKaB Oaywbong+u/EvIZ1Ewmyy2wctKFSPqSSpRnb2lmoQ1pHGjZFL4kuL558WSZeqj9KAhZv uvC/l92Hw9hGqb+CsWq5oYBUh8+QoyxagBJkBo5OWb8T+4+67ScVqWdqIvHbdZ1sM5Rt FeCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bFXSCk7jXzi1oDqUKnupFbkdc1ED5SojZj7S5YlWylo=; b=V7RdGChqw6pv/UUwMMuniUtagIbRX8JSvqUGIqOhgrZNvTPfFa0hdbBufkc8wDahVk 8W9f+4UEI/3DyiEtRsbjseFRHEbtjU93Sb7jWBT4gdNfZRr/rTpU+jJVGEP7roNrUOP6 kn7hOPyBzSzDIDCKV0K9dRShpv68N8ZH6z+C0GcwKHwsxE0XV8+Zw4PvO60QJiZbtlZD UGufv9Wm3fFZffYgV+58/MqBAHiCcTc2Wo87UjZn/Ir/acJIPwuZ3Lkf/BvBTu4O8b+S dC4rWe5ObFJQzdq3tRTEu7Zgves+uQIg0Z0YfZn3+Lio14QyX8bt+gs28SR9ifqfU9Fq d5lA== X-Gm-Message-State: AOAM530Vas2rBM+37nZM+GkPfmdZiAtoEYEbUjd2exup+nCqqqEwj+hQ jJVd3maK80iErK4/ZXyeoJbVcw== X-Google-Smtp-Source: ABdhPJxjAmo2ovKlm60IvoJxky+iKUF6BuDJdKXWp1pzrvgmxzgCNEarFOfUlp+DzNDRON+cPs/jug== X-Received: by 2002:a50:fc94:: with SMTP id f20mr25432235edq.370.1616416409440; Mon, 22 Mar 2021 05:33:29 -0700 (PDT) Received: from ?IPv6:2a02:768:2307:40d6::e05? ([2a02:768:2307:40d6::e05]) by smtp.gmail.com with ESMTPSA id q10sm11247181eds.67.2021.03.22.05.33.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 05:33:29 -0700 (PDT) Subject: Re: [PATCH 03/13] PCI: xilinx: Convert to MSI domains To: Lorenzo Pieralisi , Marc Zyngier Cc: Bjorn Helgaas , Frank Wunderlich , Thierry Reding , Thomas Gleixner , Rob Herring , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Thierry Reding , Jonathan Hunter , Ryder Lee , Marek Vasut , Yoshihiro Shimoda , Michal Simek , Paul Walmsley , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org References: <20210225151023.3642391-1-maz@kernel.org> <20210225151023.3642391-4-maz@kernel.org> <20210322122315.GB11469@e121166-lin.cambridge.arm.com> From: Michal Simek Message-ID: Date: Mon, 22 Mar 2021 13:33:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210322122315.GB11469@e121166-lin.cambridge.arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210322_123330_159285_92AE5F7B X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/22/21 1:23 PM, Lorenzo Pieralisi wrote: > On Thu, Feb 25, 2021 at 03:10:13PM +0000, Marc Zyngier wrote: >> In anticipation of the removal of the msi_controller structure, convert >> the ancient xilinx host controller driver to MSI domains. >> >> We end-up with the usual two domain structure, the top one being a >> generic PCI/MSI domain, the bottom one being xilinx-specific and handling >> the actual HW interrupt allocation. >> >> This allows us to fix some of the most appaling MSI programming, where >> the message programmed in the device is the virtual IRQ number instead >> of the allocated vector number. The allocator is also made safe with >> a mutex. This should allow support for MultiMSI, but I decided not to >> even try, since I cannot test it. >> >> Also take the opportunity to get rid of the cargo-culted memory allocation >> for the MSI capture address. *ANY* sufficiently aligned address should >> be good enough, so use the physical address of the xilinx_pcie_host >> structure instead. > > I'd agree with Bjorn that the MSI doorbell change is better split into > a separate patch, I can do it myself at merge if you agree. Thank you for doing it. Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel