From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA3C7ECAAA1 for ; Mon, 12 Sep 2022 10:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2qw6vehDpwYKu6otp9ppSTKlD+zzItt0sdVT18WqrOU=; b=cz0UY568XWQ8we A5DkVYUXqycqI2OpKttZ8gplXio5Oj6VzC6PmKVjgHF100+g/Empl/RkTI2W/sWgok7vPo/Vb0tmu e1TlopzfAKrb53/5KiaC5A2czjYgkJMT/K9aaqH/cZ6XS5g2MB44hOvdDaVcTlpefz9URKU/zKcVV Vl5qo8PC8LFxIK8AyD+ZIU/lJt2kbMiLx7Oh1w7F9Ln3GPf0OyAgDT1nzaKl9fxDssbsXUFJxipKb vkp5UuEAWRSYM4gZFqITzjzFeoPeT7ePS9qPbSSV882gZyjHoTqK9mGpVGX1LtPrpi5q1Nzny5xHM ab46iUbDpuqUrPs+w4EA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXgyV-008y3g-SD; Mon, 12 Sep 2022 10:47:36 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXgvQ-008wIK-KC for linux-arm-kernel@lists.infradead.org; Mon, 12 Sep 2022 10:44:26 +0000 Received: by mail-lf1-x12e.google.com with SMTP id k10so14129412lfm.4 for ; Mon, 12 Sep 2022 03:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=F5GFWlX5p+iK1uMljz0gi7oHJBPZquU122BFTAsILYU=; b=I7I0XbaD3zB7PPPgbSX9itHG4KiBz5coBxZLBl3oHU2imYvQhzYzeLkusK+K8RR2uJ mQ2gcpMbYoNuZkCYLhJuT2nqzpwToLAxHOIL+N7PlwUpoKxU+oCwVmYwmvUUzvs3QKsr 9j/6XZHnm+t5AIJgfwQa0wRYc6razGcbtC+HXOOqfr8cHphk9b2XicS7aUsPnGOxHjHB sXO4a0mWXRlSmZStxHBfeHkvx92UTqQFKOHdrEPROXQtDr/C5d5KTXIMB5hIYLyjESsB +p+aWcwSQe0MYOlwNSiDiYwoYATAHhm/AYkc0dBH0rC6Lu2Ie20+a33SlQkRhKvTpbfd KX5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=F5GFWlX5p+iK1uMljz0gi7oHJBPZquU122BFTAsILYU=; b=VlNqxbTjZ/TjDqcTYR9IY3Mqb9OmO4zNAmuVstG68WO4cbTOY64DNQkggXrrGbKX7e l6FLaaqscQczrj027Jr6Y/wlp1kXQbTWJvSPiRtNfdx7avebh4BIQ0qCHVbUNjwML+HC xyk+pHf80m2c6oZTLw/rUe+CtcWz8GJxcc12Mj4UfecucFeb1izrN3dulbgMVtpQ/pC6 4ePP8fRVFq/2saSKpRavtu/Zq3ksOoOStXC8/BKYUKvOtRuBs2EfvYwEtTMbiOmG8Yh9 5Hn5Tm8dxZVTbc8xxRb22BtrJzOG+tCjHN7AAGvLdXYc4ybC6NUh46j5U6PiOH16ifHM wVEQ== X-Gm-Message-State: ACgBeo0gMPSFB0Fn5asw3dUKH8NreYlxwYRUzeAgu2O6r3G2uZcw1p8M X1rmchXZcZtVD60sjondOOUkEQ== X-Google-Smtp-Source: AA6agR7/0d9DiYev9RCBwIhVGhNfzBFslqnPc8Ij7QZ/jYKPApzGCBOfvtR+jDenXc5T/wt3zdzt3w== X-Received: by 2002:a05:6512:b15:b0:492:ebc3:80d9 with SMTP id w21-20020a0565120b1500b00492ebc380d9mr9721467lfu.77.1662979462003; Mon, 12 Sep 2022 03:44:22 -0700 (PDT) Received: from [10.129.96.84] ([109.232.243.34]) by smtp.gmail.com with ESMTPSA id y18-20020a2e7d12000000b00268d84f8db1sm1019944ljc.92.2022.09.12.03.44.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Sep 2022 03:44:21 -0700 (PDT) Message-ID: Date: Mon, 12 Sep 2022 12:44:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH v2 06/13] dt-bindings: serial: atmel,at91-usart: Add SAM9260 compatibles to SAM9x60 Content-Language: en-US To: Sergiu.Moga@microchip.com, robh@kernel.org References: <20220906135511.144725-1-sergiu.moga@microchip.com> <20220906135511.144725-7-sergiu.moga@microchip.com> <9aa29d74-b1fc-d00e-dee4-57f277a366ab@linaro.org> <20220909013644.GA3731620-robh@kernel.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220912_034424_717251_DB8E89B1 X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linux-clk@vger.kernel.org, Kavyasree.Kotagiri@microchip.com, Tudor.Ambarus@microchip.com, richard.genoud@gmail.com, gregkh@linuxfoundation.org, radu_nicolae.pirea@upb.ro, lee@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, mturquette@baylibre.com, broonie@kernel.org, admin@hifiphile.com, krzysztof.kozlowski+dt@linaro.org, linux-serial@vger.kernel.org, sboyd@kernel.org, jirislaby@kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/09/2022 09:45, Sergiu.Moga@microchip.com wrote: > On 09.09.2022 04:36, Rob Herring wrote: >> On Thu, Sep 08, 2022 at 03:15:44PM +0000, Sergiu.Moga@microchip.com wrote: >>> On 08.09.2022 15:30, Krzysztof Kozlowski wrote: >>>> On 06/09/2022 15:55, Sergiu Moga wrote: >>>>> Add the AT91SAM9260 serial compatibles to the list of SAM9X60 compatibles >>>>> in order to highlight the incremental characteristics of the SAM9X60 >>>>> serial IP. >>>>> >>>>> Signed-off-by: Sergiu Moga >>>>> --- >>>>> >>>>> >>>>> v1 -> v2: >>>>> - Nothing, this patch was not here before >>>>> >>>>> >>>>> Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >>>>> index b25535b7a4d2..4d80006963c7 100644 >>>>> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >>>>> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >>>>> @@ -26,6 +26,8 @@ properties: >>>>> - items: >>>>> - const: microchip,sam9x60-dbgu >>>>> - const: microchip,sam9x60-usart >>>>> + - const: atmel,at91sam9260-dbgu >>>>> + - const: atmel,at91sam9260-usart >>>> >>>> This is weird. You say in commit msg to "highlight the incremental >>>> characteristics" but you basically change here existing compatibles. >>> >>> >>> Does "show that they are incremental IP's" sound better then? >>> >>> >>>> This is not enum, but a list. >>>> >>> >>> >>> What do you mean by this? I know it is a list, I specified so in the >>> commit message. >> >> You are saying that compatible must be exactly the 4 strings above in >> the order listed. You need another entry with another 'items' list. >> >> Rob > > > That is what was intended though: a list of the 4 compatibles in that > exact order. The 4th patch of this series also ensures that all 9x60 > nodes have that exact list of 4 compatibles. The commit msg suggest otherwise - two options, because it is incremental... But this one is not really incremental - you require this one, only one, configuration. It's in general fine, but commit msg should reflect what you are really intend to do here and why you are doing it. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel