From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CF91C433F5 for ; Fri, 30 Sep 2022 05:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Loqf8KTVTxzBblSZGiz5FciUC1JGzpYoms6LhSD33r4=; b=CDMCz1nHdP9Qr2a4fY7h/Ys46W LgdWfLgzQm5aFvXCWFgNaM03/avHqUxNEs/z4KFeg8TOYC0VeoejU3+lfv2PSVoHpIsztUdvQFBPA fB67v4ooe6YhJLaJzjCRXeDCjjInXEws8j8mTqHEMxKqUbDux8NheGUcu5LsmTg/qv4hANTZ9Dfsw bPM2JUx8/1L+Z3c+AEsygS2aDTIt1pxBuMVZopvFIBIOC5M5GLVUilmGFs1fA9MjVAuNm+2LERnus HjZLWzPuC14T8DLwjuWCaWQkchCnoYUnXUPc2fKc5Q2VUtpntqTfnHRlpsHUftU2WjoPEdNG1f90R Q/lQl5Rw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oe8nO-007MMD-D8; Fri, 30 Sep 2022 05:42:46 +0000 Received: from mailout-taastrup.gigahost.dk ([46.183.139.199]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oe8nL-007MJj-8E; Fri, 30 Sep 2022 05:42:44 +0000 Received: from mailout.gigahost.dk (mailout.gigahost.dk [89.186.169.112]) by mailout-taastrup.gigahost.dk (Postfix) with ESMTP id D4E701884C74; Fri, 30 Sep 2022 05:42:37 +0000 (UTC) Received: from smtp.gigahost.dk (smtp.gigahost.dk [89.186.169.109]) by mailout.gigahost.dk (Postfix) with ESMTP id CC22E2500370; Fri, 30 Sep 2022 05:42:37 +0000 (UTC) Received: by smtp.gigahost.dk (Postfix, from userid 1000) id BB3929EC0010; Fri, 30 Sep 2022 05:42:37 +0000 (UTC) X-Screener-Id: 413d8c6ce5bf6eab4824d0abaab02863e8e3f662 MIME-Version: 1.0 Date: Fri, 30 Sep 2022 07:42:37 +0200 From: netdev@kapio-technology.com To: Jakub Kicinski Cc: davem@davemloft.net, netdev@vger.kernel.org, Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Kurt Kanzenbach , Hauke Mehrtens , Woojung Huh , UNGLinuxDriver@microchip.com, Sean Wang , Landen Chao , DENG Qingfang , Matthias Brugger , Claudiu Manoil , Alexandre Belloni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Nikolay Aleksandrov , Shuah Khan , Russell King , Christian Marangi , Daniel Borkmann , Yuwei Wang , Petr Machata , Ido Schimmel , Florent Fourcot , Hans Schultz , Joachim Wiberg , Amit Cohen , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v6 net-next 0/9] Extend locked port feature with FDB locked flag (MAC-Auth/MAB) In-Reply-To: <20220929112744.27cc969b@kernel.org> References: <20220928150256.115248-1-netdev@kapio-technology.com> <20220929091036.3812327f@kernel.org> <12587604af1ed79be4d3a1607987483a@kapio-technology.com> <20220929112744.27cc969b@kernel.org> User-Agent: Gigahost Webmail Message-ID: X-Sender: netdev@kapio-technology.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_224243_469280_71CC9304 X-CRM114-Status: GOOD ( 16.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2022-09-29 20:27, Jakub Kicinski wrote: > On Thu, 29 Sep 2022 18:37:09 +0200 netdev@kapio-technology.com wrote: >> On 2022-09-29 18:10, Jakub Kicinski wrote: >> > On Wed, 28 Sep 2022 17:02:47 +0200 Hans Schultz wrote: >> >> From: "Hans J. Schultz" >> >> >> >> This patch set extends the locked port feature for devices >> >> that are behind a locked port, but do not have the ability to >> >> authorize themselves as a supplicant using IEEE 802.1X. >> >> Such devices can be printers, meters or anything related to >> >> fixed installations. Instead of 802.1X authorization, devices >> >> can get access based on their MAC addresses being whitelisted. >> > >> > Try a allmodconfig build on latest net-next, seems broken. Obviously my method of selecting all switchcore drivers with sub-options under menuconfig was not sufficient, and I didn't know of the allmodconfig option, otherwise I would have used it. So the question is if I should repost the fixed patch-set or I need to make a new version? Anyhow I hope that there will not be problems when running the selftests, as I have not been able to do so with my system, so there can be more that needs to be changed. If anyone needs it, here is the compile fix patch: diff --git a/drivers/net/dsa/qca/qca8k-common.c b/drivers/net/dsa/qca/qca8k-common.c index 0c5f49de6729..e26a9a483955 100644 --- a/drivers/net/dsa/qca/qca8k-common.c +++ b/drivers/net/dsa/qca/qca8k-common.c @@ -809,7 +809,7 @@ int qca8k_port_fdb_add(struct dsa_switch *ds, int port, int qca8k_port_fdb_del(struct dsa_switch *ds, int port, const unsigned char *addr, u16 vid, - struct dsa_db db) + u16 fdb_flags, struct dsa_db db) { struct qca8k_priv *priv = (struct qca8k_priv *)ds->priv; u16 port_mask = BIT(port); diff --git a/drivers/net/dsa/sja1105/sja1105_main.c b/drivers/net/dsa/sja1105/sja1105_main.c index 1f12a5b89c91..526177813d53 100644 --- a/drivers/net/dsa/sja1105/sja1105_main.c +++ b/drivers/net/dsa/sja1105/sja1105_main.c @@ -1938,7 +1938,7 @@ static void sja1105_fast_age(struct dsa_switch *ds, int port) u64_to_ether_addr(l2_lookup.macaddr, macaddr); - rc = sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid, db); + rc = sja1105_fdb_del(ds, port, macaddr, l2_lookup.vlanid, 0, db); if (rc) { dev_err(ds->dev, "Failed to delete FDB entry %pM vid %lld: %pe\n", @@ -1952,14 +1952,14 @@ static int sja1105_mdb_add(struct dsa_switch *ds, int port, const struct switchdev_obj_port_mdb *mdb, struct dsa_db db) { - return sja1105_fdb_add(ds, port, mdb->addr, mdb->vid, false, db); + return sja1105_fdb_add(ds, port, mdb->addr, mdb->vid, 0, db); } static int sja1105_mdb_del(struct dsa_switch *ds, int port, const struct switchdev_obj_port_mdb *mdb, struct dsa_db db) { - return sja1105_fdb_del(ds, port, mdb->addr, mdb->vid, db); + return sja1105_fdb_del(ds, port, mdb->addr, mdb->vid, 0, db); } /* Common function for unicast and broadcast flood configuration. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel