From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "lkp@intel.com" <lkp@intel.com>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>,
"heiko@sntech.de" <heiko@sntech.de>,
"geert+renesas@glider.be" <geert+renesas@glider.be>,
"narmstrong@baylibre.com" <narmstrong@baylibre.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"patrice.chotard@st.com" <patrice.chotard@st.com>,
"paul@crapouillou.net" <paul@crapouillou.net>,
"eric@anholt.net" <eric@anholt.net>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"ludovic.desroches@microchip.com"
<ludovic.desroches@microchip.com>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"wens@csie.org" <wens@csie.org>,
"agross@kernel.org" <agross@kernel.org>,
"bcm-kernel-feedback-list@broadcom.com"
<bcm-kernel-feedback-list@broadcom.com>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"mazziesaccount@gmail.com" <mazziesaccount@gmail.com>,
"rjui@broadcom.com" <rjui@broadcom.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-rpi-kernel@lists.infradead.org"
<linux-rpi-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kbuild-all@lists.01.org" <kbuild-all@lists.01.org>,
"sbranden@broadcom.com" <sbranden@broadcom.com>,
"sean.wang@kernel.org" <sean.wang@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"wahrenst@gmx.net" <wahrenst@gmx.net>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"linux-oxnas@groups.io" <linux-oxnas@groups.io>
Subject: Re: [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION
Date: Wed, 13 Nov 2019 06:52:51 +0000 [thread overview]
Message-ID: <ac16492e11899ef4ec981f7f2e84714c7d61d2a7.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <201911131438.KT6pnFZ7%lkp@intel.com>
On Wed, 2019-11-13 at 14:30 +0800, kbuild test robot wrote:
> Hi Matti,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on 70d97e099bb426ecb3ad4bf31e88dbf2ef4b2e4c]
>
> 480 static int wmt_gpio_get_direction(struct gpio_chip
> *chip, unsigned offset)
> 481 {
> 482 struct wmt_pinctrl_data *data =
> gpiochip_get_data(chip);
> 483 u32 bank = WMT_BANK_FROM_PIN(offset);
> 484 u32 bit = WMT_BIT_FROM_PIN(offset);
> 485 u32 reg_dir = data->banks[bank].reg_dir;
> 486 u32 val;
> 487
> 488 val = readl_relaxed(data->base + reg_dir);
> 489 if (val & BIT(bit))
> > 490 GPIO_LINE_DIRECTION_OUT;
Right. Return is missing. I think I already fixed this - I guess I sent
wrong version... Sorry guys. I'll do v3 with only this return added -
and I'll send it to limited amount of recipients as I think most of you
guys may not be interested. Probably to Linus W, Geert and GPIO list
only. Let me know if you want to see the v3 (or other subsequent
patches)
> 491
> 492 return GPIO_LINE_DIRECTION_IN;
> 493 }
> 494
>
> ---
> 0-DAY kernel test infrastructure Open Source
> Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel
> Corporation
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-13 6:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:18 [PATCH 2/2] pinctrl: Use new GPIO_LINE_DIRECTION Matti Vaittinen
2019-11-12 17:01 ` Bjorn Andersson
2019-11-12 18:18 ` Geert Uytterhoeven
2019-11-13 6:30 ` kbuild test robot
2019-11-13 6:52 ` Vaittinen, Matti [this message]
2019-11-13 9:40 ` Linus Walleij
2019-11-13 9:53 ` Vaittinen, Matti
2019-11-13 10:06 ` Vaittinen, Matti
2019-11-13 17:18 ` Linus Walleij
2020-02-14 11:14 ` Vaittinen, Matti
2019-11-13 8:53 ` Jacopo Mondi
2020-02-15 5:35 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac16492e11899ef4ec981f7f2e84714c7d61d2a7.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=agross@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bjorn.andersson@linaro.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=geert+renesas@glider.be \
--cc=gregory.clement@bootlin.com \
--cc=heiko@sntech.de \
--cc=jason@lakedaemon.net \
--cc=kbuild-all@lists.01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-oxnas@groups.io \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lkp@intel.com \
--cc=ludovic.desroches@microchip.com \
--cc=matthias.bgg@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=patrice.chotard@st.com \
--cc=paul@crapouillou.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=sean.wang@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=wahrenst@gmx.net \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).