From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: "Irui Wang (王瑞)" <Irui.Wang@mediatek.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Tiffany Lin (林慧珊)" <tiffany.lin@mediatek.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"nicolas.dufresne@collabora.com" <nicolas.dufresne@collabora.com>,
"hsinyi@chromium.org" <hsinyi@chromium.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"acourbot@chromium.org" <acourbot@chromium.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Longfei Wang (王龙飞)" <Longfei.Wang@mediatek.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Maoguang Meng (孟毛广)" <Maoguang.Meng@mediatek.com>,
"Yunfei Dong (董云飞)" <Yunfei.Dong@mediatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile
Date: Tue, 15 Nov 2022 12:49:08 +0100 [thread overview]
Message-ID: <ac1f56bc-2d38-8d0c-83ea-f5e36eb15e25@xs4all.nl> (raw)
In-Reply-To: <a386f704b43b117d8857a7d7f51b1652ddb40663.camel@mediatek.com>
Hi Irui,
On 11/15/22 12:40, Irui Wang (王瑞) wrote:
> Dear Hans,
>
> Gently ping for this patch.
> May I know this patch current status? It seems is under your reviewing
> state?
Mauro was on vacation last week, but he said that he hopes to merge
the pending PRs tomorrow. Fingers crossed...
Regards,
Hans
>
> Thanks
> Best Regards
>
> On Mon, 2022-09-26 at 17:35 +0800, Irui Wang wrote:
>> The encoder driver support h264 baseline, main, high encoder
>> profile, set mask for V4L2_CID_MPEG_VIDEO_H264_PROFILE to skip
>> the unsupported profile.
>>
>> get supported h264_profile by command: v4l2-ctl -d /dev/videoX -L
>> h264_profile 0x00990a6b (menu) : min=0 max=4 default=4 value=4
>> 0: Baseline
>> 2: Main
>> 4: High
>>
>> Signed-off-by: Irui Wang <irui.wang@mediatek.com>
>> ---
>> drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 5 ++++-
>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
>> b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
>> index d810a78dde51..d65800a3b89d 100644
>> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
>> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c
>> @@ -1397,7 +1397,10 @@ int mtk_vcodec_enc_ctrls_setup(struct
>> mtk_vcodec_ctx *ctx)
>> 0, V4L2_MPEG_VIDEO_HEADER_MODE_SEPARATE);
>> v4l2_ctrl_new_std_menu(handler, ops,
>> V4L2_CID_MPEG_VIDEO_H264_PROFILE,
>> V4L2_MPEG_VIDEO_H264_PROFILE_HIGH,
>> -0, V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
>> +~((1 << V4L2_MPEG_VIDEO_H264_PROFILE_BASELINE)
>> |
>> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_MAIN) |
>> + (1 << V4L2_MPEG_VIDEO_H264_PROFILE_HIGH)),
>> +V4L2_MPEG_VIDEO_H264_PROFILE_HIGH);
>> v4l2_ctrl_new_std_menu(handler, ops,
>> V4L2_CID_MPEG_VIDEO_H264_LEVEL,
>> h264_max_level,
>> 0, V4L2_MPEG_VIDEO_H264_LEVEL_4_0);
>
> ************* MEDIATEK Confidentiality Notice
> ********************
> The information contained in this e-mail message (including any
> attachments) may be confidential, proprietary, privileged, or otherwise
> exempt from disclosure under applicable laws. It is intended to be
> conveyed only to the designated recipient(s). Any use, dissemination,
> distribution, printing, retaining or copying of this e-mail (including its
> attachments) by unintended recipient(s) is strictly prohibited and may
> be unlawful. If you are not an intended recipient of this e-mail, or believe
>
> that you have received this e-mail in error, please notify the sender
> immediately (by replying to this e-mail), delete any and all copies of
> this e-mail (including any attachments) from your system, and do not
> disclose the content of this e-mail to any other person. Thank you!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-11-15 11:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 9:35 [PATCH] media: mediatek: vcodec: Skip unsupported h264 encoder profile Irui Wang
2022-09-28 13:38 ` Allen-KH Cheng (程冠勳)
2022-09-29 1:54 ` yunfei.dong
2022-09-29 8:32 ` AngeloGioacchino Del Regno
2022-10-19 10:07 ` Irui Wang
2022-11-15 11:40 ` Irui Wang (王瑞)
2022-11-15 11:49 ` Hans Verkuil [this message]
2022-11-15 11:57 ` Irui Wang (王瑞)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac1f56bc-2d38-8d0c-83ea-f5e36eb15e25@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=Irui.Wang@mediatek.com \
--cc=Longfei.Wang@mediatek.com \
--cc=Maoguang.Meng@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Yunfei.Dong@mediatek.com \
--cc=acourbot@chromium.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=robh+dt@kernel.org \
--cc=tiffany.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).