From: Steven Price <steven.price@arm.com>
To: "Clément Péron" <peron.clem@gmail.com>,
"Rob Herring" <robh@kernel.org>,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Alyssa Rosenzweig" <alyssa.rosenzweig@collabora.com>
Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/panfrost: no need to display probe deferred error
Date: Fri, 6 Dec 2019 10:02:21 +0000 [thread overview]
Message-ID: <ad2de6cc-41a2-7a4e-fe8a-84890b6c110a@arm.com> (raw)
In-Reply-To: <20191205221102.28248-1-peron.clem@gmail.com>
On 05/12/2019 22:11, Clément Péron wrote:
> Panfrost driver is shouting an error if the regulator init
> return an -EPROBE_DEFFER. This is a not a real error and
> it doesn't require to be display.
>
> Check if the error is not an EPROBE_DEFFER before displaying it.
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> drivers/gpu/drm/panfrost/panfrost_device.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 238fb6d54df4..00cef062c35d 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -92,7 +92,8 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev)
> pfdev->regulator = devm_regulator_get(pfdev->dev, "mali");
> if (IS_ERR(pfdev->regulator)) {
> ret = PTR_ERR(pfdev->regulator);
> - dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
> + if (ret != -EPROBE_DEFER)
> + dev_err(pfdev->dev, "failed to get regulator: %d\n", ret);
> return ret;
> }
>
> @@ -130,7 +131,8 @@ int panfrost_device_init(struct panfrost_device *pfdev)
>
> err = panfrost_regulator_init(pfdev);
> if (err) {
> - dev_err(pfdev->dev, "regulator init failed %d\n", err);
> + if (err != -EPROBE_DEFER)
> + dev_err(pfdev->dev, "regulator init failed %d\n", err);
You could actually drop this dev_err() altogether -
panfrost_regulator_init() will always produce it's own dev_err() output
if it returns non-zero.
Either way:
Reviewed-by: Steven Price <steven.price@arm.com>
> goto err_out0;
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-12-06 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 22:11 [PATCH] drm/panfrost: no need to display probe deferred error Clément Péron
2019-12-06 10:02 ` Steven Price [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad2de6cc-41a2-7a4e-fe8a-84890b6c110a@arm.com \
--to=steven.price@arm.com \
--cc=alyssa.rosenzweig@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=peron.clem@gmail.com \
--cc=robh@kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).