Re: [PATCH 0/8] ARM: Convert to platform remove callback returning void

From: "Arnd Bergmann" <arnd@arndb.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Russell King" <linux@armlinux.org.uk>,
	"Viresh Kumar" <viresh.kumar@linaro.org>,
	"Ulf Hansson" <ulf.hansson@linaro.org>,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Alan Stern" <stern@rowland.harvard.edu>,
	"Mark Brown" <broonie@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Aaro Koskinen" <aaro.koskinen@iki.fi>,
	"Janusz Krzysztofik" <jmkrzyszt@gmail.com>,
	"Tony Lindgren" <tony@atomide.com>,
	"Daniel Mack" <daniel@zonque.org>,
	"Haojian Zhuang" <haojian.zhuang@gmail.com>,
	"Robert Jarzmik" <robert.jarzmik@free.fr>
Cc: linux-arm-kernel@lists.infradead.org,
	"Pengutronix Kernel Team" <kernel@pengutronix.de>,
	"Fabio Estevam" <festevam@gmail.com>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	Linux-OMAP <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 0/8] ARM: Convert to platform remove callback returning void
Date: Wed, 08 Mar 2023 16:06:47 +0100	[thread overview]
Message-ID: <adaf8b7c-f1a7-4770-adb6-31ced13d64d2@app.fastmail.com> (raw)
In-Reply-To: <20230308100012.2539189-1-u.kleine-koenig@pengutronix.de>

On Wed, Mar 8, 2023, at 11:00, Uwe Kleine-König wrote:
> Hello,
>
> this patch series adapts the platform drivers below arch/arm to use the
> .remove_new() callback. Compared to the traditional .remove() callback
> .remove_new() returns no value. This is a good thing because the driver core
> doesn't (and cannot) cope for errors during remove. The only effect of a
> non-zero return value in .remove() is that the driver core emits a warning. The
> device is removed anyhow and an early return from .remove() usually yields a
> resource leak.
>
> By changing the remove callback to return void driver authors cannot
> reasonably assume any more that there is some kind of cleanup later.
>
> All drivers in arch/arm returned zero unconditionally in their remove callback,
> so they could all be converted trivially to .remove_new().
>
> Note that this series depends on commit 5c5a7680e67b ("platform: Provide
> a remove callback that returns no value") which is included in v6.3-rc1.

Looks good to me,

Reviewed-by: Arnd Bergmann <arnd@arndb.de>

> I'm unsure who will pick up this series. Will it go as a whole via arm-soc? Or
> will the individual maintainers pick it up?

I can take it through the soc tree, please send it to
soc@kernel.org once you are done getting Acks.

Since all eight patches in the series have the exact same
changelog text and are all trivial, I'd prefer them to be
folded into a single patch if that works for you.

      Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel