From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97E57C83000 for ; Wed, 29 Apr 2020 17:11:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 695312083B for ; Wed, 29 Apr 2020 17:11:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FQKyOTCc"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="F+IUXWmX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 695312083B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:To:From: Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oG89r2BZh0F8Lsqcy3LZxc09IBbBiIyG8AVnuy/FzuY=; b=FQKyOTCcu7l7BBhTgS5ZJ5Mkn G4Jn4OizbFb5bb4Mk2y2rKLDTPTARKZ+5POXrIk0eLo5EpTGfatNworg1BNkjz2+4I1kEI/hx2ocP xnhwKISY5Hn4/kzRDOczclZc7xzxZ6Mgmk92ds9IoMPeRsWko1hWeJzoJKxWEnQm50rthr+2NTmne G8K7UTTZ7nF/GLOHtcuKSi6Koc31dri3wzVRnqU9HDnttVjZgq744NkleOsDF4JNdz4cadqTUgB0d fVqFlYZR6Z/WDqtXEbjgN3UfAKg7gpw6h/xJ73GYywudZXNtY1GQPxnyKlyPUx4fERZFwwrhuIsNR jMNdW/Nzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTqF3-000487-9B; Wed, 29 Apr 2020 17:11:25 +0000 Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTqEy-00047T-O1 for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 17:11:23 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588180282; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=2H/grRhp1qnjOIul3MbQSy7YNYNUS9RRvwG048+TsJY=; b=F+IUXWmXU4b6uiVU4tVxkqbqc6ePvHf4N4qLNzRMthBYgpoIYhXV5T/kfjXILkJr/Op3bnTn KCyv3X3A87HdZkT+A7mvvPDkXjakoFIBn1sJqACcZI9+4uxODbiSlLt1aXT42VsMf31SCqXg fmYdn+dsZxa/6fx5l9h4CAouWsk= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJiYzAxZiIsICJsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5ea9b52c.7f0d18f4a848-smtp-out-n03; Wed, 29 Apr 2020 17:11:08 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 23D1AC433BA; Wed, 29 Apr 2020 17:11:07 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: saiprakash.ranjan) by smtp.codeaurora.org (Postfix) with ESMTPSA id 834D7C433D2; Wed, 29 Apr 2020 17:11:06 +0000 (UTC) MIME-Version: 1.0 Date: Wed, 29 Apr 2020 22:41:06 +0530 From: Sai Prakash Ranjan To: Mike Leach Subject: Re: [PATCH] coresight: dynamic-replicator: Fix handling of multiple connections In-Reply-To: References: <20200426143725.18116-1-saiprakash.ranjan@codeaurora.org> <84918e7d-c933-3fa1-a61e-0615d4b3cf2c@arm.com> <668ea1283a6dd6b34e701972f6f71034@codeaurora.org> <5b0f5d77c4eec22d8048bb0ffa078345@codeaurora.org> <759d47de-2101-39cf-2f1c-cfefebebd548@arm.com> <7d343e96cf0701d91152fd14c2fdec42@codeaurora.org> Message-ID: X-Sender: saiprakash.ranjan@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_101122_636924_47A4B080 X-CRM114-Status: GOOD ( 24.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathieu Poirier , Suzuki K Poulose , linux-arm-msm@vger.kernel.org, Linux Kernel Mailing List , Stephen Boyd , linux-arm-kernel Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mike, On 2020-04-29 22:28, Mike Leach wrote: > Hi, > [...] >> >> > You need to find what is resetting the IDFILTERs to 0 for replicator1. >> >> > >> >> >> >> That is right. >> >> >> > >> > By default all replicators have the IDFILTER registers set to 0 out of >> > hardware reset. This ensures that programmable replicators behave in >> > the same way as non-programmable replicators out of reset. >> > >> > The dynamic_replicator_reset() is of course a driver state reset - >> > which filters out all trace on the output ports. The trace is then >> > enabled when we set the trace path from source to sink. >> > >> >> Thanks for these explanations. >> >> > It seems to me that you have 2 problems that need solving here: >> > >> > 1) Why does the reset_replicator() called from probe() _not_ work >> > correctly on replicator 1? It seems to work later if you introduce a >> > reset after more of the system has powered and booted. This is >> > startiing to look a little like a PM / clocking issue. >> >> reset_replicator() does work in probe correctly for both replicators, >> below logs is collected before and after reset in probe. It is later >> that it's set back to 0x0 and hence the suggestion to look at firmware >> using this replicator1. >> > OK - sorry I read your statement saying that replicator1 was 0 after > the reset in probe(), rather than look at the logs. > > From the logs it is working at the time probe() occurs, but by the > time we come to enable the replicator later, something has reset these > registers / hardware outside the control of the replicator driver. > Yes, I will try to get some more information from the firmware side if there is anything messing up. > >> [ 8.477669] func replicator_probe before reset replicator >> replicator1 >> REPLICATOR_IDFILTER0=0x0 REPLICATOR_IDFILTER1=0x0 >> [ 8.489470] func replicator_probe after reset replicator >> replicator1 >> REPLICATOR_IDFILTER0=0xff REPLICATOR_IDFILTER1=0xff >> >> > >> > This failure is causing the state when we are trying to set an output >> > port that both branches of this replicator are enabled for output. >> > In effect for this replicator, setting the output port has no effect >> > as it is already enabled. >> > >> > 2) Why does having both ports of this repilicator enabled cause a hard >> > lockup? This is a separate hardware / system issue. >> > >> > The worst that should happen if both branches of a replicator are >> > enabled is that you get undesirable back pressure. (e.g. there is a >> > system we have seen - I think it is Juno - where there is a static >> > replicator feeding the TPIU and ETR - we need to disable the TPIU to >> > prevent undesired back pressure). >> > >> >> Ok so hardlockup is not expected because of this backpressure. >> > > Hardlockup is not expected, but this is not related to any possible > backpressure. > > Ordinarily having both legs of a replicator enabled should not cause > system failure. > Ok got it, thanks. Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel