Re: [PATCH 2/4] ARM: dts: am437x: Move l4 child devices to probe them with ti-sysc

From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: devicetree@vger.kernel.org, "Dave Gerlach" <d-gerlach@ti.com>,
	Keerthy <j-keerthy@ti.com>, "Tero Kristo" <t-kristo@ti.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/4] ARM: dts: am437x: Move l4 child devices to probe them with ti-sysc
Date: Fri, 7 Dec 2018 14:46:47 +0200	[thread overview]
Message-ID: <ae6c0180-ca44-c8d9-8a15-0b8debd99c9a@ti.com> (raw)
In-Reply-To: <20181205230242.GH6707@atomide.com>

Tony,

On 06/12/2018 1.02, Tony Lindgren wrote:
> * Tony Lindgren <tony@atomide.com> [181205 19:00]:
>> I think we're missing the top level ranges for mcasp l3 port
>> and the translation goes wrong there, I'll fix it hopefully
>> today.
> 
> Below is a fix for am473x that works for me as tested with
> am473x-sk-evm. Care to test please?

the patch works, thanks!

Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

> I'll send also a similar fix for am335x separately. And
> then for dra7. Looks like for dra7 we're also missing the
> mcasp optional clocks too.
> 
> Regards,
> 
> Tony
> 
> 8< ------------
> From tony Mon Sep 17 00:00:00 2001
> From: Tony Lindgren <tony@atomide.com>
> Date: Wed, 5 Dec 2018 14:08:21 -0800
> Subject: [PATCH] ARM: dts: Add missing ranges for am437x mcasp l3 ports
> 
> We need to add mcasp l3 port ranges for mcasp to use a correct l3
> data port address for dma.
> 
> Fixes: d95adfd45853 ("ARM: dts: am437x: Move l4 child devices to
> probe them with ti-sysc")
> Reported-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  arch/arm/boot/dts/am437x-l4.dtsi | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/am437x-l4.dtsi b/arch/arm/boot/dts/am437x-l4.dtsi
> --- a/arch/arm/boot/dts/am437x-l4.dtsi
> +++ b/arch/arm/boot/dts/am437x-l4.dtsi
> @@ -613,7 +613,9 @@
>  	ranges = <0x00000000 0x48000000 0x100000>,	/* segment 0 */
>  		 <0x00100000 0x48100000 0x100000>,	/* segment 1 */
>  		 <0x00200000 0x48200000 0x100000>,	/* segment 2 */
> -		 <0x00300000 0x48300000 0x100000>;	/* segment 3 */
> +		 <0x00300000 0x48300000 0x100000>,	/* segment 3 */
> +		 <0x46000000 0x46000000 0x400000>,	/* l3 data port */
> +		 <0x46400000 0x46400000 0x400000>;	/* l3 data port */
>  
>  	segment@0 {					/* 0x48000000 */
>  		compatible = "simple-bus";
> @@ -664,7 +666,9 @@
>  			 <0x00034000 0x00034000 0x001000>,	/* ap 80 */
>  			 <0x00035000 0x00035000 0x001000>,	/* ap 81 */
>  			 <0x00036000 0x00036000 0x001000>,	/* ap 84 */
> -			 <0x00037000 0x00037000 0x001000>;	/* ap 85 */
> +			 <0x00037000 0x00037000 0x001000>,	/* ap 85 */
> +			 <0x46000000 0x46000000 0x400000>,	/* l3 data port */
> +			 <0x46400000 0x46400000 0x400000>;	/* l3 data port */
>  
>  		target-module@8000 {			/* 0x48008000, ap 6 10.0 */
>  			compatible = "ti,sysc";
> @@ -826,7 +830,8 @@
>  			clock-names = "fck";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> -			ranges = <0x0 0x38000 0x2000>;
> +			ranges = <0x0 0x38000 0x2000>,
> +				 <0x46000000 0x46000000 0x400000>;
>  
>  			mcasp0: mcasp@0 {
>  				compatible = "ti,am33xx-mcasp-audio";
> @@ -857,7 +862,8 @@
>  			clock-names = "fck";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> -			ranges = <0x0 0x3c000 0x2000>;
> +			ranges = <0x0 0x3c000 0x2000>,
> +				 <0x46400000 0x46400000 0x400000>;
>  
>  			mcasp1: mcasp@0 {
>  				compatible = "ti,am33xx-mcasp-audio";
> 

- Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel