From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 3/3] Documentation: DT bindings: Tegra AHB: note base address change
Date: Thu, 19 Mar 2015 16:46:18 +0000 (UTC) [thread overview]
Message-ID: <alpine.DEB.2.02.1503191645350.9480@utopia.booyaka.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1503191601520.9480@utopia.booyaka.com>
On Thu, 19 Mar 2015, Paul Walmsley wrote:
> On Thu, 19 Mar 2015, Stephen Warren wrote:
>
> > On 03/19/2015 09:26 AM, Paul Walmsley wrote:
> > > On Tue, 17 Mar 2015, Russell King - ARM Linux wrote:
> > >
> > > > On Tue, Mar 17, 2015 at 01:32:21AM -0700, Paul Walmsley wrote:
> > > > > Required properties:
> > > > > - compatible : For Tegra20, must contain "nvidia,tegra20-ahb". For
> > > > > - Tegra30, must contain "nvidia,tegra30-ahb". Otherwise, must contain
> > > > > - '"nvidia,<chip>-ahb", "nvidia,tegra30-ahb"' where <chip> is tegra124,
> > > > > - tegra132, or tegra210.
> > > > > -- reg : Should contain 1 register ranges(address and length)
> > > > > + Tegra30, must contain "nvidia,tegra30-ahb". For Tegra114 and
> > > > > Tegra124, must
> > > > > + contain '"nvidia,<chip>-ahb", "nvidia,tegra30-ahb"' where <chip> is
> > > > > tegra114
> > > > > + or tegra124. For Tegra132, the compatible string must contain
> > > > > + "nvidia,tegra132-ahb".
> > > > > +
> > > > > +- reg : Should contain 1 register ranges(address and length). On
> > > > > Tegra20,
> > > > > + Tegra30, Tegra114, and Tegra124 chips, the low byte of the physical
> > > > > base
> > > > > + address of the IP block must end in 0x04. On DT files for later
> > > > > chips, the
> > > > > + actual hardware base address of the IP block should be used.
> > > >
> > > > You could check that in the driver. If you can check it in the driver,
> > > > you can also decide to ignore it if it were offset by 0x04 (possibly
> > > > printing a warning.) That opens up the ability to fix the older Tegra
> > > > DT files going forward while still remaining compatible with existing
> > > > DT files, and avoiding the need for a complex note about this.
> > >
> > > That's fine, I'll do that and drop this patch.
> >
> > Don't we still want to update the DT binding documentation to state what the
> > preferred base address (or at least set of legal base addresses) is/are?
>
> As far as I know, the DT binding documents are intended to be a
> reference for IP block integration data like base addresses.
The above is missing an important word: it should have read "are _not_
intended"
- Paul
next prev parent reply other threads:[~2015-03-19 16:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 8:32 [PATCHv2 0/3] amba: tegra-ahb: fix base address and register offsets for future chip support Paul Walmsley
2015-03-17 8:32 ` [PATCHv2 1/3] amba: tegra-ahb: fix register offsets in the macros Paul Walmsley
2015-03-17 8:32 ` [PATCHv2 2/3] amba: tegra-ahb: use correct base address for future chip support Paul Walmsley
2015-03-17 8:32 ` [PATCHv2 3/3] Documentation: DT bindings: Tegra AHB: note base address change Paul Walmsley
2015-03-17 10:38 ` Russell King - ARM Linux
2015-03-19 15:26 ` Paul Walmsley
2015-03-19 15:42 ` Stephen Warren
2015-03-19 16:17 ` Paul Walmsley
2015-03-19 16:46 ` Paul Walmsley [this message]
2015-03-19 16:54 ` Stephen Warren
2015-03-19 17:55 ` Paul Walmsley
2015-03-19 18:28 ` Stephen Warren
2015-03-19 18:46 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1503191645350.9480@utopia.booyaka.com \
--to=paul@pwsan.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).