From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Tony Lindgren <tony@atomide.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [11/12] ARM: OMAP2+: add missing of_node_put after of_device_is_available
Date: Sun, 14 Apr 2019 18:49:12 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1904141848390.2496@hadrien> (raw)
In-Reply-To: <903ec107-46ed-f19f-56a7-c20031247503@web.de>
On Sun, 14 Apr 2019, Markus Elfring wrote:
> > @@ -250,8 +250,10 @@ static int __init omapdss_init_of(void)
> > if (!node)
> > return 0;
> >
> > - if (!of_device_is_available(node))
> > + if (!of_device_is_available(node)) {
> > + of_node_put(node);
> > return 0;
> > + }
> >
> > pdev = of_find_device_by_node(node);
>
> Is there a need to put the node also in subsequent if branches
> for complete exception handling in this function implementation?
Yes, it looks like this is indeed missing. I will try to send a better
patch when time permits.
julia
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-14 16:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 13:20 [PATCH 00/12] add missing of_node_put after of_device_is_available Julia Lawall
2019-02-23 13:20 ` [PATCH 09/12] meson-gx-socinfo: " Julia Lawall
2019-03-12 20:28 ` Kevin Hilman
2019-04-14 16:12 ` Markus Elfring
2019-02-23 13:20 ` [PATCH 10/12] cpufreq: ap806: " Julia Lawall
2019-02-25 4:29 ` Viresh Kumar
2019-02-23 13:20 ` [PATCH 11/12] ARM: OMAP2+: " Julia Lawall
2019-03-22 22:24 ` Tony Lindgren
2019-04-14 16:38 ` [11/12] " Markus Elfring
2019-04-14 16:49 ` Julia Lawall [this message]
2019-02-23 13:20 ` [PATCH 12/12] drivers: firmware: psci: " Julia Lawall
2019-04-01 12:47 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1904141848390.2496@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).