From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF75C76186 for ; Wed, 17 Jul 2019 10:05:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB2892077C for ; Wed, 17 Jul 2019 10:05:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uP4AWUYZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB2892077C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZMF1y9KGh1SXtNMnGpc9k5FvRzCgV4gMiPhmswLk1fw=; b=uP4AWUYZfPQWlq fC92JPPrbdZlnYT7VoE9FOMlQ4PvD0xz+2vLXjJmX+DL0KPR1H/Y5nZBVzL9Sri3mQG2VwKl3h3rC rxmVkFiMccL/h+2FJyIS3MTxJcaczvIog846RwFNR+4a0munVZypEV6LBDKIiBft1pF52Ka26GV+9 j94DUXPR+UZsPgtzHnF2pqp9OIofonIq+HfiZK4rDHh6yYDEZyJlngsF5tgv0Fxe0FCkvEhbwulFs V9P+lb+yjB82Lz7f07qhBcVvh9wwvtgw7Uh1fYYCwYlIo3NzzLXzgpo4854Mhz/UMOEnWgsBMHPZi hzsFzl+bcbNg51c9ijlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hngoa-00071P-11; Wed, 17 Jul 2019 10:05:37 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hngo1-0005JI-8k for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2019 10:05:02 +0000 Received: from pd9ef1cb8.dip0.t-ipconnect.de ([217.239.28.184] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hngnw-0002Pa-HU; Wed, 17 Jul 2019 12:04:56 +0200 Date: Wed, 17 Jul 2019 12:04:55 +0200 (CEST) From: Thomas Gleixner To: Valentin Schneider Subject: Re: [PATCH] arm64: Avoid pointless schedule_preempt_irq() invocations In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1, SHORTCIRCUIT=-0.0001 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190717_030501_553670_4E48D294 X-CRM114-Status: GOOD ( 13.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Zijlstra , Catalin Marinas , Will Deacon , LKML , LAK Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 17 Jul 2019, Valentin Schneider wrote: > On 17/07/2019 09:43, Thomas Gleixner wrote: > > When preempt_count is zero on return from interrupt then > > schedule_preempt_irq() is invoked even if TIF_NEED_RESCHED is not set. > > > > That does not make sense because schedule_preempt_irq() has to go through a > > full __schedule() for nothing in that case. > > > > Check TIF_NEED_RESCHED and invoke schedule_preempt_irq() only if set. > > > > Signed-off-by: Thomas Gleixner > > Don't we have NEED_RESCHED squashed into preempt count? > > 396244692232 ("arm64: preempt: Provide our own implementation of asm/preempt.h") > > So the existing check should cover that, unless I'm missing something? Right. Ignore me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel