From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E1B3ECE587 for ; Tue, 1 Oct 2019 17:38:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 156642053B for ; Tue, 1 Oct 2019 17:38:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="buhf7KfR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PGyzGHOi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 156642053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Message-ID: In-Reply-To:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VtL/n0ZDx2inCIAUJxd1f65LxdbSL44H6+5JbimQ/eU=; b=buhf7KfR0KsYEg ZJ/pqlFmaMuGmb6BL7pQJI5tQhvP5y7wZ+Rv+aq46pA5icQ/4z1wEcSrmm209Tarjl63Ym9KBAnB7 2CYVzrViR5QeqWU10F4SbK2LEX8Ylnc3KsDxHcAqQp+elSoF1hL8M2xxMhupJRbgYglk80+lWN/rG chhgOec95SnxvE4KeFse0WvfIiSf0mlty4IS9YRd22jlCfTAFFU71wHmBA/5jZghHDsuFr37T8YYi uuR9sk+g1BAEQeOXeyCLLmM11l2zW8n2mB0WIU5WRg7R/Bcnzp3efRPm9RQiHWVZoWbDXIdA5tFj8 +W6FF7IB8gC1+yyG5OlQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFM6I-0007nw-OP; Tue, 01 Oct 2019 17:38:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFM6E-0007mT-Sr for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2019 17:38:12 +0000 Received: from localhost (c-67-164-102-47.hsd1.ca.comcast.net [67.164.102.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B7CEE2053B; Tue, 1 Oct 2019 17:38:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569951490; bh=MMmGvGL9mMISD7665FS8n/2elHIASz6KuyJpSch+Vzc=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=PGyzGHOi8DLY9Ntkwu1xLIIjou96erVvR41GoRYE63/OEUdplRKDX/U+LkKD1XiPD 4RC1VBOtqVJPdE3vzE0V0JTmVjnNOFDFOOfnH/zLIYFmxWmDIhAvlM0PHZnLoSvOgQ 7wnlKe7hxq0JZ33qeMO21zV/luBcFtqS9qbtj/18= Date: Tue, 1 Oct 2019 10:38:03 -0700 (PDT) From: Stefano Stabellini X-X-Sender: sstabellini@sstabellini-ThinkPad-T480s To: Arnd Bergmann Subject: Re: [PATCH] ARM: xen: unexport HYPERVISOR_platform_op function In-Reply-To: <20190906153948.2160342-1-arnd@arndb.de> Message-ID: References: <20190906153948.2160342-1-arnd@arndb.de> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191001_103810_975058_F7D934AB X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Stefano Stabellini , Emil Velikov , Russell King , Denis Efremov , linux-kernel@vger.kernel.org, Masahiro Yamada , xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 6 Sep 2019, Arnd Bergmann wrote: > HYPERVISOR_platform_op() is an inline function and should not > be exported. Since commit 15bfc2348d54 ("modpost: check for > static EXPORT_SYMBOL* functions"), this causes a warning: > > WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL > > Remove the extraneous export. > > Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions") > Signed-off-by: Arnd Bergmann > --- > arch/arm/xen/enlighten.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c > index 1e57692552d9..845c528acf24 100644 > --- a/arch/arm/xen/enlighten.c > +++ b/arch/arm/xen/enlighten.c > @@ -437,7 +437,6 @@ EXPORT_SYMBOL_GPL(HYPERVISOR_memory_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_physdev_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_vcpu_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_tmem_op); > -EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op); > EXPORT_SYMBOL_GPL(HYPERVISOR_multicall); > EXPORT_SYMBOL_GPL(HYPERVISOR_vm_assist); > EXPORT_SYMBOL_GPL(HYPERVISOR_dm_op); Hi Arnd, Thank you for the patch. HYPERVISOR_platform_op() is an inline function, the underlying function that should be exported is HYPERVISOR_platform_op_raw. So, instead of removing HYPERVISOR_platform_op, we should change it to HYPERVISOR_platform_op_raw. For convenience, and for testing I cooked up a patch. Arnd, if you are happy with it (in the sense that it solves your problem) we'll check it in the xentip tree, unless you would like to get it in your tree? Cheers, Stefano --- From: Stefano Stabellini HYPERVISOR_platform_op() is an inline function and should not be exported. Since commit 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions"), this causes a warning: WARNING: "HYPERVISOR_platform_op" [vmlinux] is a static EXPORT_SYMBOL_GPL Instead, export the underlying function called by the static inline: HYPERVISOR_platform_op_raw. Fixes: 15bfc2348d54 ("modpost: check for static EXPORT_SYMBOL* functions") Signed-off-by: Arnd Bergmann Signed-off-by: Stefano Stabellini diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index 1e57692552d9..522c97d43ef8 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -437,7 +437,7 @@ EXPORT_SYMBOL_GPL(HYPERVISOR_memory_op); EXPORT_SYMBOL_GPL(HYPERVISOR_physdev_op); EXPORT_SYMBOL_GPL(HYPERVISOR_vcpu_op); EXPORT_SYMBOL_GPL(HYPERVISOR_tmem_op); -EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op); +EXPORT_SYMBOL_GPL(HYPERVISOR_platform_op_raw); EXPORT_SYMBOL_GPL(HYPERVISOR_multicall); EXPORT_SYMBOL_GPL(HYPERVISOR_vm_assist); EXPORT_SYMBOL_GPL(HYPERVISOR_dm_op); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel