From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60BB5C433DB for ; Mon, 11 Jan 2021 21:05:25 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01B3422D02 for ; Mon, 11 Jan 2021 21:05:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01B3422D02 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:Message-ID:In-Reply-To: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=f2ftp557bIdbMhbY8AWG4TNEUTTEyGFFX5c0iqHJnM8=; b=o7Nq7QT8P46hQy+SqSpQJZhoR SxPTEkjMq95luFiDFCXzJa8u8eEGXC1ILL3sEtQ1q2cH4K6yyX/QODQ8fhAZcwtwXwenJC+1E3T43 s/VaFVGq+uKaaFG7QmHC+/mniWwRawMgh0di+k7XGV9BaO1lZz6BUXcY4+cIZBigmO1N0c3a5nRiY W/3JoA4vTHS+6scZNnMBRTKr/u+7XNOCG9FiVV0a7WIZgDuCCSj1uZsrMh0t47p3ptsLh004zjmJF /PZr+7M+DrfKytZwSRDsujN571fIGUrYXZbFJBZKgq32PXgcverhqbl66u+7EhDC/r3CB6KYW/rpE jSUY6nnlw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz4Ls-0006Lb-KN; Mon, 11 Jan 2021 21:03:48 +0000 Received: from mail-oo1-xc35.google.com ([2607:f8b0:4864:20::c35]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz4Lp-0006Jy-BW for linux-arm-kernel@lists.infradead.org; Mon, 11 Jan 2021 21:03:46 +0000 Received: by mail-oo1-xc35.google.com with SMTP id j21so71979oou.11 for ; Mon, 11 Jan 2021 13:03:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=D0WsNvRmpBji920/NLXuSxF1voxQjixvAcc1ep1K53k=; b=azspcaalHcJMxoaJcLWKEOOfP9+fKM96I9nb8n17Oyh+Crzg0pdbuIsZZvB+Q2Z/IX 4G3Zvp44mQsXJU3/HYukyexeX7/RUsYb9oep6Tq0gCIgXbTAuA0avhZyL9KiGlPetOJF Gio4Oy6UjAInYNrXZSMxyueSj9+5bt65Yz8uhx0OPnlkBr02eV+EWpf3xyS5aG3+Ckce x/HAhHilGocjsnPlAjb8NybRMrtww45Nigd5iA3berXAGFsc8aakB4x2ELNR4+A3AIsm tNODDrV83uvQRGqXIdmsIyLQt+RVp5iovLIQIcqF51+J7AsPWFcez4s/ApMqPJFIUX2L UHIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=D0WsNvRmpBji920/NLXuSxF1voxQjixvAcc1ep1K53k=; b=toa/0L/ypHTUUvQHHsaCwkRJaooqJESNtZ/nW8Ortuf2N6iAbx+X0BC5HCP5w/TAQz req6TrtvB8sMSP1UHxdCYQAfilZSLC6sJ2Bb2Cz/nIbM8oR8bFHI0FHdXV/LtW12DuoW sSZuf+chpWz1X5drwt0OJATO2n1AMR6Th+f05rwRaqjKvyuQJ1QRI6P3TlcppZshCmt3 5KoJL7iphm80htCqhL1Qcvp5B3yjiTncuiU2yKAKFZmASQLSQIDhPQH19HzTqA7H+SJK KnucC4lXG0BTInDkYnAZyzVUV4cGaZX/OMh2we6a7EbhcpnaShaGkpgzL2oDBXfc6uDm LGHQ== X-Gm-Message-State: AOAM531EMeghG33G0wZjfdOpH+JYDm+kf+WgHTI78HvLtpmCAPjMW2kX vfl1LOOlKSgztoQLyiJN9gJkvg== X-Google-Smtp-Source: ABdhPJwoPOIOzFsA8HrKwq8BkpXKz4xbBOGnDZj5hWPQPvkz6AthHRvqF/O25zKJWn4ePNr5WUYCOg== X-Received: by 2002:a4a:e1c1:: with SMTP id n1mr748612oot.36.1610399023421; Mon, 11 Jan 2021 13:03:43 -0800 (PST) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id y10sm197210ota.42.2021.01.11.13.03.42 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Mon, 11 Jan 2021 13:03:42 -0800 (PST) Date: Mon, 11 Jan 2021 13:03:29 -0800 (PST) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Will Deacon Subject: Re: [PATCH v2 0/3] Create 'old' ptes for faultaround mappings on arm64 with hardware access flag In-Reply-To: <20210111133007.GA7642@willie-the-truck> Message-ID: References: <20210108171517.5290-1-will@kernel.org> <20210111133007.GA7642@willie-the-truck> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210111_160345_533874_5A7A0B19 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Android Kernel Team , Jan Kara , Minchan Kim , Catalin Marinas , Hugh Dickins , Linux Kernel Mailing List , Linux-MM , Vinayak Menon , "Kirill A . Shutemov" , Andrew Morton , Linus Torvalds , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 11 Jan 2021, Will Deacon wrote: > On Fri, Jan 08, 2021 at 11:34:08AM -0800, Linus Torvalds wrote: > > On Fri, Jan 8, 2021 at 9:15 AM Will Deacon wrote: > > > > > > The big difference in this version is that I have reworked it based on > > > Kirill's patch which he posted as a follow-up to the original. However, > > > I can't tell where we've landed on that -- Linus seemed to like it, but > > > Hugh was less enthusiastic. > > > > Yeah, I like it, but I have to admit that it had a disturbingly high > > number of small details wrong for several versions. I hope you picked > > up the final version of the code. > > I picked the version from here: > > https://lore.kernel.org/r/20201229132819.najtavneutnf7ajp@box > > and actually, I just noticed that willy spotted a typo in a comment, so > I'll fix that locally as well as adding the above to a 'Link:' tag for > reference. > > > At the same time, I do think that the "disturbingly high number of > > issues" was primarily exactly _because_ the old code was so > > incomprehensible, and I think the end result is much cleaner, so I > > still like it. Just to report that I gave this v2 set a spin on a few (x86_64 and i386) machines, and found nothing objectionable this time around. And the things that I'm unenthusiastic about are exactly those details that you and Kirill and Linus find unsatisfactory, but awkward to eliminate: expect no new insights from me! Hugh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel