From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5932DC432BE for ; Mon, 30 Aug 2021 09:31:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1FCC260FBF for ; Mon, 30 Aug 2021 09:31:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1FCC260FBF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nxp.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Bt5zBAHrmDGLmnHnMlzMxWAf7m/RacndBM/wxWm3BgM=; b=pQ56FZhaTmflSRH5ZfpISkiTYU espz8+8pgvO1v0QuWGyhn7MBnv0DGuxPqNGJOCJG/+EeClE8ucGUBa/K3Q+vYlQpRzzt38tNaxCvR Oxt28XTwAnn0GzRs7/lcH5K19+HrZGaeQZ8W3tzUlqts+3metxRajvNgsP7FLyb8A3WC0TkcLDxwP R6VM58/H4HvKWryK8wrstUTBfPAknxftA04iZIyV5dKTrN7ElJOnuSNJuYoM/SNMMLVTqvk1QoQR4 PDGE8IXCKhb7CQFX92chCYZOqm85r71/iDrfWMnJQ6+EMr23MvpH0vq5LERBaGT3s3P+2aAumoMrc xd+1NnPw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKdbo-00Grx9-Fm; Mon, 30 Aug 2021 09:29:40 +0000 Received: from mail-am6eur05on2069.outbound.protection.outlook.com ([40.107.22.69] helo=EUR05-AM6-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mKdbi-00GrwD-GK for linux-arm-kernel@lists.infradead.org; Mon, 30 Aug 2021 09:29:38 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OdR4ChkO7vcyWudVbgcZs6lrBvrlxi5us3bRze50Q74bDQ+nFwRspMBiZOK1noG2hPnUkNFc/kxFcrqeuNRZ2v9wvREtkbjxfFt9gseQ981wXdzaxeWNoiZqRjj2MPf8G5v48Z+d7wxwojuRfoT2mDNQGV1DYBa9ZgP3PZ4GordN0lqaGpatG+uxEwyPwC/4tyiPJJEUU8w+T6A03vEfucy4/6FBDcn2jKeukeUecbeCNR0LE/PCfmv/8mw2rdpzcGJ95kYakNqZ9dT/BJK7KU1Elj6BnFj0hasDRo8BqlgIrDqJlAicSYF+QGB6MRbt46pBIjDtZBjVqHZ/DR2ZBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KEl2ycz/1/25Z0dBZjFKmmyWw5JF4L3mRN6A12igN0M=; b=H3EryHQkS1X4l1b9gS/7ryuOHGWYJrL1PNZqeJZ4tKtAJD55QBo87zqlKESmpZVnYl5MsQkfkH5utYMtT0DHU95/UdUqNSSjTmxy5eCcfya31omFcINTDKcAUH64+zG0/rrFRCSkYrv5VMpqyf3HDj5HnWmyBSgdOcRuSOQu9gS6xbd7R7fQB3vJMSwiPY6rh6fXSP0WO/97E6bjQ433C0q4EvKBmBInRZDIhU/GtqFtHxy1pkflmZT/rsSDjdGeHG2q2s8LRBKIqRIaeVlo3UbpU7E8gTU0tNvpjFAtC34J8oLv/Ke4C2AF+o7sDkcSqCXtgKlcyTtbpz3lNMmJLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KEl2ycz/1/25Z0dBZjFKmmyWw5JF4L3mRN6A12igN0M=; b=J02TTw8h9m2EGLjcYB7yw78SkknPIz0R5GatLgYYRqJQjp43RwP82M/qVmzuhjW9+BvBWtBYoyI0Brv/VDfpRYYBAefVXzpgLR9wWtFIk7oXnziNFzmOyOMTazDSK1mz6mnSScIfwy0yEhbkLqu7N7JQFAoGUmjxg/XM0fdN70A= Authentication-Results: lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=none action=none header.from=nxp.com; Received: from VI1PR0402MB3405.eurprd04.prod.outlook.com (2603:10a6:803:3::26) by VI1PR04MB5037.eurprd04.prod.outlook.com (2603:10a6:803:57::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.17; Mon, 30 Aug 2021 09:29:25 +0000 Received: from VI1PR0402MB3405.eurprd04.prod.outlook.com ([fe80::10e6:799c:9d34:fc2d]) by VI1PR0402MB3405.eurprd04.prod.outlook.com ([fe80::10e6:799c:9d34:fc2d%6]) with mapi id 15.20.4457.024; Mon, 30 Aug 2021 09:29:25 +0000 Subject: Re: [PATCH 1/2] bus/fsl-mc: Add generic implementation for open/reset/close commands To: Diana Craciun , linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Alex Williamson , kvm@vger.kernel.org Cc: Li Yang , linux-arm-kernel@lists.infradead.org References: <20210825090538.4860-1-diana.craciun@oss.nxp.com> From: Laurentiu Tudor Message-ID: Date: Mon, 30 Aug 2021 12:29:23 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 In-Reply-To: <20210825090538.4860-1-diana.craciun@oss.nxp.com> Content-Language: en-US X-ClientProxiedBy: AM0PR01CA0092.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::33) To VI1PR0402MB3405.eurprd04.prod.outlook.com (2603:10a6:803:3::26) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.108] (79.113.50.66) by AM0PR01CA0092.eurprd01.prod.exchangelabs.com (2603:10a6:208:10e::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20 via Frontend Transport; Mon, 30 Aug 2021 09:29:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6557f365-40eb-4d98-46e5-08d96b98a87b X-MS-TrafficTypeDiagnostic: VI1PR04MB5037: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: af5dK4qXcB4lX26/KfLmSBeKOA4KLJah60yqu3tBHdMnNsWCYU1vm5S+n1rP7P7PfkiEdyWYqynB9iKH5BJndTjGZMeEuGesVQo7mr173Ikk1oMpBjthZn+GCVHBCrBDu8ZlFZFumGHqWmYmdHxU4tX6WOs6BjcQg1769pVYVWqf79/To3Sn/iwVNmyJLLEiXn2eL/hlm2KSBjPdwANnfozwAlH4Lk0hVgLITPMeiFpl/gILOxoNN3ZkFNXlcLsqumcVlhtMfbmVRbV676aUn8yf1k5uVBR0lLEGVwJepBoNq8tbRsu3aOZytyKZHFlaoS+XJ+SH52j2RzNT0QWfoqJ/L3463Aegljx/SOb0FMAZ66+CpdpSaQ6kaWDaHLYCOrlJgMjVMmiGBGlSFqiwbvXYp3idudEiGN6/M0LgBSGGjXv6RFmo13QasN827QDKuVwGjQVItvBBItt3VCYliUS6y6M4nDwbGxBm8B5j7OMHZL2Sxcb16Sr8yKIQ/Erfyv1mPqQIK+JQdZ8vUqwq3lwTv7WyUs9WE5rhwTACYjJDp/BEltzEmwjM2cNAH9Blg4gXEw9TmMy5AmJfRZpZuTbq0MK1behoxLrTDXKEzkCjfyJEuMuSvYvI+p7lSV0nea9r4s53UpjC79Q7iFkgdBjH4zqciPfC9nIrXFKegtfeVjBQZfFoCm8NA+bd8rYfXIOdNNfASkMIOa0pqexM/onZEa1XA6+5FrHArcagE6czOVY6Qh5kfeKPU8cbP4n6 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR0402MB3405.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(39860400002)(136003)(396003)(2906002)(2616005)(86362001)(110136005)(52116002)(44832011)(38100700002)(83380400001)(66476007)(6486002)(31696002)(316002)(16576012)(36756003)(66946007)(5660300002)(26005)(8676002)(53546011)(478600001)(31686004)(66556008)(38350700002)(956004)(4326008)(186003)(8936002)(41533002)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aUdSZllRUGtiSGVxWlR3NklzRFc4V1lXaE9Va0pDQTFMYytwVXloNDc3Q0tq?= =?utf-8?B?V25ianBNSUpMaVdiUzN4SElGTmRaOE1nVjJjUlhpMmMrdStjRTVOUVIvRnNU?= =?utf-8?B?eklTYnRsRlU0R2hsbS9jVG40enVXU08vSFR5SERJRmVjZ2NDTXQyVDd0NU5r?= =?utf-8?B?UkpUZEJ5VVVvQVRuRDRoRER3RzlOQ1NTMTFOOXY3WThMQVBOaHBxMjJPNk5h?= =?utf-8?B?RUxwWlNKR0dkQzIyV1R5ekVQZ0NRQkJZY2VISEtYNUI0Ti9VcCtVTVhtbTd0?= =?utf-8?B?NjJpMzZlY3VVQmplQWtKby81T2VsbDZtc2l6emVuL243SXZpQ2FROVVLekFS?= =?utf-8?B?V1k5RThoUTh3bUdZek1xT2dEY3VoL1Jva2RqVXdSdnFXMlhSL2NUdXY3OGh6?= =?utf-8?B?RURmdUR2NGs5cHcxdGRoUnlKWGt4OHhYTExLbmV6MGpOTDZ3dVJRTDBEUk0w?= =?utf-8?B?Mm5ka2wvcDNWRW5WbVUvUzBucU43WkJzV0J1aWFRcDhicmx5WVpHUUxSZjlr?= =?utf-8?B?YmdLR2x1ZUxKMCtyZjB0Y2lrRmNhYVI4UWt3bTdrdFE1T1dkTFliSHFkWTFY?= =?utf-8?B?RjI0K2hKdnR6aFd4K3RYTDBvNVdTdGRrbThsM0hUUWMwTkhJZENSRUFSeUhI?= =?utf-8?B?QWFLMVhUYmxJS0UrZnJ2cDdmMTR1WFJhRWI2aXA3Q1ZoTzF0cUFvVzlwMzRq?= =?utf-8?B?bGxVdDY1bXdqVUJreERGRkdmeEt1dU5xZHZGVXBPNzkzNUlpbkIxWWw4b0pH?= =?utf-8?B?emMyYW82VjFuR3BZeE9IOWMrblhhWjZkRjVlUHErNTF4bnB1WE1wWCtXNit2?= =?utf-8?B?VGFITHIzR0ErK0lzQnRDZDg3NGY0c1lCdDhqdHNrUDNNdGorYnA0TXN1azh4?= =?utf-8?B?T283bHloVzVlYm5oS25DMGxMOW9kY0RQa2drNk9PQW45VkR6M2xmUTJmSWZG?= =?utf-8?B?RmFuMmoxOE51M0hMQ2dxalI2MjJENVNBdmFKdWRJMkVlandFZi92VG9tYnFU?= =?utf-8?B?SUppUklYdWtIemJ3VitVYjEvZmZPekpFN1dEK2w5VVZlSmFGRTcvcTk0NVNH?= =?utf-8?B?NUxhanJLcW9GeGNXVkF5L1I0N2FPbW9tOVBEbmJaMjNDeHg1ZE9pTGhCR0dh?= =?utf-8?B?NWkxR2FYSzREbWlmWWR4QXlJM0M3ZE1iVUlSay9Ed1ZqdERIMFhWLzgwU2pJ?= =?utf-8?B?cXZYVUFqNXJwSzB2MUdtZUlZQnJJTU5hZmFKRGpqOGMyWVFDOU95aXZZYXE3?= =?utf-8?B?WEZZTkZMSDFMV202bWsvQ0xZWjJXQ0lwckdJQ1R2djlmYUxoYm5kZDJnUFdK?= =?utf-8?B?UHE0cEVvQlNnbmprYk4rLzA0ZUhZOFhkQlltL1pPUWkvMFNtWUJ6dHNVR0E4?= =?utf-8?B?SkJ4OTNJeFpBenRxUlkreVNGNjYvY0RrbEx1WEFCN2Fzb0w3RmJmRkUzNmxa?= =?utf-8?B?RndlZWlQZG4vTE1CMnh3Zi95UTl0VEl4TFF3V1p3UG9kTHFPaGlOK1NXUHlX?= =?utf-8?B?V0NLZ09OZmVqZmgvSURuRjRGSnZiNkJ2aGY4cDlZR05FWWxFcUtLMUZqY2JG?= =?utf-8?B?RFNIb3lCRzAvT1NXV2cvTzN1WnpPOHMrbmtnb3VmUitLcTRncGVwMGJmRTJT?= =?utf-8?B?SVk0V0Z4dnBxbzl4WHBOWVFBUWJUOWh6dWFzUTB5SUl5SmNIeHRRL29WaXIv?= =?utf-8?B?aGFjRUd0RGlUYmlKbGswbWJhYU1VMjI3aUJjSnVFODJJNk42R3R2dWhlVnRT?= =?utf-8?Q?Z6aa6d5HGexdX6u0GCCe/MeXuipCjnLF9yVy8gU?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6557f365-40eb-4d98-46e5-08d96b98a87b X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3405.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2021 09:29:25.6947 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 47cpeDsF5kwWGZpDFo1AR2vtLM8gXwvHAX7XFsVyzEtyk+VbtWrilH1fZy0hzfLoPj1CViQXRQfaRlTv1deAEw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5037 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210830_022934_673200_30FE41B5 X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/25/2021 12:05 PM, Diana Craciun wrote: > The open/reset/close commands format is similar for all objects. > Currently there are multiple implementations for these commands > scattered through various drivers. The code is cavsi-identical. > Create a generic implementation for the open/reset/close commands. > One of the consumer will be the VFIO driver which needs to > be able to reset a device. > > Signed-off-by: Diana Craciun > --- > drivers/bus/fsl-mc/Makefile | 3 +- > drivers/bus/fsl-mc/fsl-mc-private.h | 39 +++++++++-- > drivers/bus/fsl-mc/obj-api.c | 104 ++++++++++++++++++++++++++++ > include/linux/fsl/mc.h | 14 ++++ > 4 files changed, 155 insertions(+), 5 deletions(-) > create mode 100644 drivers/bus/fsl-mc/obj-api.c > > diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile > index 4ae292a30e53..892946245527 100644 > --- a/drivers/bus/fsl-mc/Makefile > +++ b/drivers/bus/fsl-mc/Makefile > @@ -15,7 +15,8 @@ mc-bus-driver-objs := fsl-mc-bus.o \ > dprc-driver.o \ > fsl-mc-allocator.o \ > fsl-mc-msi.o \ > - dpmcp.o > + dpmcp.o \ > + obj-api.o > > # MC userspace support > obj-$(CONFIG_FSL_MC_UAPI_SUPPORT) += fsl-mc-uapi.o > diff --git a/drivers/bus/fsl-mc/fsl-mc-private.h b/drivers/bus/fsl-mc/fsl-mc-private.h > index 1958fa065360..6055ef3e9e02 100644 > --- a/drivers/bus/fsl-mc/fsl-mc-private.h > +++ b/drivers/bus/fsl-mc/fsl-mc-private.h > @@ -48,7 +48,6 @@ struct dpmng_rsp_get_version { > > /* DPMCP command IDs */ > #define DPMCP_CMDID_CLOSE DPMCP_CMD(0x800) > -#define DPMCP_CMDID_OPEN DPMCP_CMD(0x80b) > #define DPMCP_CMDID_RESET DPMCP_CMD(0x005) > > struct dpmcp_cmd_open { > @@ -91,7 +90,6 @@ int dpmcp_reset(struct fsl_mc_io *mc_io, > > /* DPRC command IDs */ > #define DPRC_CMDID_CLOSE DPRC_CMD(0x800) > -#define DPRC_CMDID_OPEN DPRC_CMD(0x805) > #define DPRC_CMDID_GET_API_VERSION DPRC_CMD(0xa05) > > #define DPRC_CMDID_GET_ATTR DPRC_CMD(0x004) > @@ -453,7 +451,6 @@ int dprc_get_connection(struct fsl_mc_io *mc_io, > > /* Command IDs */ > #define DPBP_CMDID_CLOSE DPBP_CMD(0x800) > -#define DPBP_CMDID_OPEN DPBP_CMD(0x804) > > #define DPBP_CMDID_ENABLE DPBP_CMD(0x002) > #define DPBP_CMDID_DISABLE DPBP_CMD(0x003) > @@ -492,7 +489,6 @@ struct dpbp_rsp_get_attributes { > > /* Command IDs */ > #define DPCON_CMDID_CLOSE DPCON_CMD(0x800) > -#define DPCON_CMDID_OPEN DPCON_CMD(0x808) > > #define DPCON_CMDID_ENABLE DPCON_CMD(0x002) > #define DPCON_CMDID_DISABLE DPCON_CMD(0x003) > @@ -524,6 +520,41 @@ struct dpcon_cmd_set_notification { > __le64 user_ctx; > }; > > +/* > + * Generic FSL MC API > + */ > + > +/* generic command versioning */ > +#define OBJ_CMD_BASE_VERSION 1 > +#define OBJ_CMD_ID_OFFSET 4 > + > +#define OBJ_CMD(id) (((id) << OBJ_CMD_ID_OFFSET) | OBJ_CMD_BASE_VERSION) > + > +/* open command codes */ > +#define DPRTC_CMDID_OPEN OBJ_CMD(0x810) > +#define DPNI_CMDID_OPEN OBJ_CMD(0x801) > +#define DPSW_CMDID_OPEN OBJ_CMD(0x802) > +#define DPIO_CMDID_OPEN OBJ_CMD(0x803) > +#define DPBP_CMDID_OPEN OBJ_CMD(0x804) > +#define DPRC_CMDID_OPEN OBJ_CMD(0x805) > +#define DPDMUX_CMDID_OPEN OBJ_CMD(0x806) > +#define DPCI_CMDID_OPEN OBJ_CMD(0x807) > +#define DPCON_CMDID_OPEN OBJ_CMD(0x808) > +#define DPSECI_CMDID_OPEN OBJ_CMD(0x809) > +#define DPAIOP_CMDID_OPEN OBJ_CMD(0x80a) > +#define DPMCP_CMDID_OPEN OBJ_CMD(0x80b) > +#define DPMAC_CMDID_OPEN OBJ_CMD(0x80c) > +#define DPDCEI_CMDID_OPEN OBJ_CMD(0x80d) > +#define DPDMAI_CMDID_OPEN OBJ_CMD(0x80e) > +#define DPDBG_CMDID_OPEN OBJ_CMD(0x80f) > + > +/* Generic object command IDs */ > +#define OBJ_CMDID_CLOSE OBJ_CMD(0x800) > +#define OBJ_CMDID_RESET OBJ_CMD(0x005) > + > +struct obj_cmd_open { Nit: maybe the name should be made less generic, e.g. fsl_mc_obj_cmd_open. Otherwise, looks good to me: Reviewed-by: Laurentiu Tudor --- Best Regards, Laurentiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel