From: Robin Murphy <robin.murphy@arm.com>
To: Jaedon Shin <jaedon.shin@gmail.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org
Cc: Vincenzo Frascino <vincenzo.frascino@arm.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] ARM: VDSO: Fix incorrect clock_gettime64
Date: Sat, 30 May 2020 15:51:35 +0100 [thread overview]
Message-ID: <b17b74eb-1ca9-8af4-6564-3874c97d5ae7@arm.com> (raw)
In-Reply-To: <20200409050508.96753-1-jaedon.shin@gmail.com>
On 2020-04-09 06:05, Jaedon Shin wrote:
> __vdso_*() should be removed and fallback used if CNTCVT is not
> available by cntvct_functional(). __vdso_clock_gettime64 when added
> previous commit is using the incorrect CNTCVT value in that state.
> __vdso_clock_gettime64 is also added to remove it's symbol.
Tested-by: Robin Murphy <robin.murphy@arm.com>
Turns out this is what was making my RK3288 box virtually unusable since
its last couple of updates - it would be nice to get the fix merged and
backported ASAP. I suspect it's also the same underlying thing for the
Raspberry Pi thread over here:
https://lore.kernel.org/linux-arm-kernel/CAK8P3a2Tw2w73ZkK-W6AA9veMK4-miLUx-TL1EuOdP7EdW-AmQ@mail.gmail.com/
Robin.
> Fixes: 74d06efb9c2f ("ARM: 8932/1: Add clock_gettime64 entry point")
> Signed-off-by: Jaedon Shin <jaedon.shin@gmail.com>
> ---
> arch/arm/kernel/vdso.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/kernel/vdso.c b/arch/arm/kernel/vdso.c
> index e0330a25e1c6..28cfe7bad1bf 100644
> --- a/arch/arm/kernel/vdso.c
> +++ b/arch/arm/kernel/vdso.c
> @@ -184,6 +184,7 @@ static void __init patch_vdso(void *ehdr)
> if (!cntvct_ok) {
> vdso_nullpatch_one(&einfo, "__vdso_gettimeofday");
> vdso_nullpatch_one(&einfo, "__vdso_clock_gettime");
> + vdso_nullpatch_one(&einfo, "__vdso_clock_gettime64");
> }
> }
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-30 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 5:05 [PATCH] ARM: VDSO: Fix incorrect clock_gettime64 Jaedon Shin
2020-05-30 14:51 ` Robin Murphy [this message]
2020-05-30 14:59 ` Russell King - ARM Linux admin
2020-06-08 13:54 ` Robin Murphy
2020-06-18 17:30 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b17b74eb-1ca9-8af4-6564-3874c97d5ae7@arm.com \
--to=robin.murphy@arm.com \
--cc=arnd@arndb.de \
--cc=jaedon.shin@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).