From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: alexandre.torgue@st.com, pierre-yves.mordret@st.com,
marc.w.gonzalez@free.fr, linux-kernel@vger.kernel.org,
fabien.dessenne@st.com, linux-i2c@vger.kernel.org,
mcoquelin.stm32@gmail.com,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] i2c: i2c-stm32f7: fix the get_irq error cases
Date: Mon, 17 Jun 2019 09:54:31 +0200 [thread overview]
Message-ID: <b1fb50c0-b5ee-dd73-0b8e-f025dd843cbe@st.com> (raw)
In-Reply-To: <20190614205322.GA17899@ninjato>
On 6/14/19 10:53 PM, Wolfram Sang wrote:
> Hi Fabrice,
>
>> + return irq_event ? irq_event : -ENODEV;
>
> Maybe -ENOENT instead of -ENODEV? I mean you have a dev_err there, so
> the driver core should probably also complain?
>
> You could also shorten the ternary operator to:
>
> return irq_event ? : -E<whatyouprefer>;
>
> However, both are minor nits. If you prefer to keep the patch as is,
> fine with me.
Hi Wolfram,
Thanks for reviewing,
I've sent a v3 with your suggestions.
Regards,
Fabrice
>
> Regards,
>
> Wolfram
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-06-17 7:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-16 15:29 [PATCH v2] i2c: i2c-stm32f7: fix the get_irq error cases Fabrice Gasnier
2019-06-12 12:29 ` Fabrice Gasnier
2019-06-14 20:53 ` Wolfram Sang
2019-06-17 7:54 ` Fabrice Gasnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1fb50c0-b5ee-dd73-0b8e-f025dd843cbe@st.com \
--to=fabrice.gasnier@st.com \
--cc=alexandre.torgue@st.com \
--cc=fabien.dessenne@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=marc.w.gonzalez@free.fr \
--cc=mcoquelin.stm32@gmail.com \
--cc=pierre-yves.mordret@st.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).