From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B4B2C00140 for ; Tue, 2 Aug 2022 08:59:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7+U2WyLHpZpbQr1GQHn2ND5RP4f+KYAojiH1G/cAM+w=; b=0rcjYf+4F8L9x5 Jc68OFoFYeF0d8GXmmHHnxgLz20btdubGTiUgjC34rSP+7VwPB5/qi77qs/ArFxY22tsn/y9mLGlX f2tT1j0kGle18EMXCqFKVcJ77M0ra8BGlScIsSvmpRryLO3td1uGlZ0qT1UrgRKf88/QWL2aJD5cQ gkvJMRekuyqyQxwzcj+IYoUeGsQth3F7BI6i0zTHgztLm7+qlNdP7mnzCsFBh8zDdvrCqRpWT8skR 1y2LF99zr3eUprlpTds6+WJX67gAe6poajxkIA+AFmw8YITirmZva9vQNnt7+4nXhJ/EM5f4oi67E hJnVgFkedXaHSBVvx5xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oInjG-00C6S1-Al; Tue, 02 Aug 2022 08:58:18 +0000 Received: from mail-lj1-x22f.google.com ([2a00:1450:4864:20::22f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oInjB-00C6Mv-Ae for linux-arm-kernel@lists.infradead.org; Tue, 02 Aug 2022 08:58:15 +0000 Received: by mail-lj1-x22f.google.com with SMTP id z4so259339ljn.8 for ; Tue, 02 Aug 2022 01:58:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=npQP1PTeFOBz/aH/qk/2cJgnMA7yHhXLpALhGeue+vw=; b=wrhadkP9rdiZt1XXIHzWWCrjD0rl5hQMS+ZHqpbiG8Bt2LLowIhnWcU7ppEYLP+n5h feQRYMFdysj8IjhdN8uy//PHWuS2s0gAwNG2Tl4bJRy/VJ9+pKLcCEgofn1G/zzwOdbc Bklq4hdGFHGafaOmpt8fbbRFgY2Swqfn0djw4xHaNIQUxdGw7fQt/cg6ATRE6IJ64N3u SJgUmnLAuwZUEPt3YYr+G8Cs5Yl1YdtfUahwTnkJ/1KXe+/za3ugN2PeP7+3or95tLx+ zqcqdUUdODthmLA5lyqRvz90oSbF2qfLtF5jWkgC45Uoo1xD+XGM0+Lw/wJ93t2KtsXd AgzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=npQP1PTeFOBz/aH/qk/2cJgnMA7yHhXLpALhGeue+vw=; b=BpRLvVViBSFtdRDwKBMXaXp3pb6Fh36ErIOc+m0o1x0ppV7qJ6u+vB2ASgusyfzDWV AbJ5bwBLJOf6sjVowtzMajYniTF9ymEdtQ9SHuS8gdmtt3ForYTwabdOZHckpbhOBjZN kliVJLhQKNZbdHcrdsDgetWGIOhGvw0/4Hzb3m+P4rhbbcWRYnCfjOOcOyznVGF4UeMR 5LWBTXpC9Tg5aSIr/9pxJe+hQgMKE/3CSz/4fxGCJjJRzU3qZwt6oXoJXy1O8ErCpPQG hfsQd50glRHO9ejgFu/zkRYSS28E2dcb19jB7RSqJGfQhnZI1CzuZ73BVkpGxaeF83ty aPgQ== X-Gm-Message-State: AJIora9RaVj5qB+sI0qToTla/3suCNEUUKE5ptuC2bDcAhiMJCM3yq6S qcY58ASmGP47E1FSdYY7MWUMew== X-Google-Smtp-Source: AGRyM1s6TASgKeoeefB3kojxmqJkb8Ddf94gvx/txy9BStGigDLYfFEvUo1PUBytil1oYOafbF8+hQ== X-Received: by 2002:a05:651c:179f:b0:25d:ba24:2e16 with SMTP id bn31-20020a05651c179f00b0025dba242e16mr5887088ljb.422.1659430689430; Tue, 02 Aug 2022 01:58:09 -0700 (PDT) Received: from [192.168.1.6] ([213.161.169.44]) by smtp.gmail.com with ESMTPSA id bf43-20020a05651225ab00b0047fae90bfb4sm2033495lfb.56.2022.08.02.01.58.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 01:58:08 -0700 (PDT) Message-ID: Date: Tue, 2 Aug 2022 10:58:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v4 06/20] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Content-Language: en-US To: Tinghan Shen , Yong Wu , Joerg Roedel , Will Deacon , Robin Murphy , Rob Herring , Krzysztof Kozlowski , Lee Jones , Matthias Brugger , AngeloGioacchino Del Regno , MandyJH Liu Cc: iommu@lists.linux.dev, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220729063208.16799-1-tinghan.shen@mediatek.com> <20220729063208.16799-7-tinghan.shen@mediatek.com> From: Krzysztof Kozlowski In-Reply-To: <20220729063208.16799-7-tinghan.shen@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220802_015813_501577_DBCAECF0 X-CRM114-Status: GOOD ( 13.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 29/07/2022 08:31, Tinghan Shen wrote: > The System Control Processor System (SCPSYS) has several power > management related tasks in the system. Add the bindings for it. > > Signed-off-by: Tinghan Shen Thank you for your patch. There is something to discuss/improve. > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + syscon@10006000 { > + compatible = "mediatek,mt8195-scpsys", "syscon", "simple-mfd"; > + reg = <0x10006000 0x100>; > + > + spm: power-controller { > + compatible = "mediatek,mt8195-power-controller"; > + #address-cells = <1>; > + #size-cells = <0>; > + #power-domain-cells = <1>; > + > + /* sample of power domain nodes */ > + power-domain@MT8195_POWER_DOMAIN_PCIE_PHY { > + reg = ; Wrong indentation. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel