From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B924CC433F5 for ; Thu, 14 Apr 2022 09:03:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hcpH+QjvvJxNL6gl50YgW/Er9Vyk0mMgcEu4IMq9bsU=; b=i+zxW66+6Z2+T9 FoQzdIBvX61wQBcQo34rxY8nnWa2A/EBsUydY7hTLNHrfYevKptf0otyRdTBmbadl0Z6dRg6Jd6sB nQR27wCztmdzqCJZRmW2rO+wxbTL2z/PA4Qp4ku6yKNHsmijY8ONMjDuPu7BQEJcYpzE6hyKv4NOH r8zAV4x6X1+aZLVbpeI18AMmYeXZaxrbyT1wo+Y4AL+whuoarEhx9K15cbYm0lUh9cbj3Jvfkj1Xe MSQwxjUSup4ilcFg2NrRFMnYdcZLuqDy7CcRGv86pwzG0TLuxkp1LUB1cE5ZCy+wfDqJ4ft9p6W9b qJ2cg1L5+QWAU0Ra2v8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevMJ-004j5V-CQ; Thu, 14 Apr 2022 09:01:47 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nevI4-004giI-7d for linux-arm-kernel@lists.infradead.org; Thu, 14 Apr 2022 08:57:26 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A86CD139F; Thu, 14 Apr 2022 01:57:18 -0700 (PDT) Received: from [10.32.36.25] (e121896.Emea.Arm.com [10.32.36.25]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6F3203F5A1; Thu, 14 Apr 2022 01:57:17 -0700 (PDT) Message-ID: Date: Thu, 14 Apr 2022 09:57:15 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 00/15] Make ETM register accesses consistent with sysreg.h Content-Language: en-US To: Mathieu Poirier Cc: suzuki.poulose@arm.com, coresight@lists.linaro.org, mike.leach@linaro.org, anshuman.khandual@arm.com, leo.yan@linaro.com, Leo Yan , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220304171913.2292458-1-james.clark@arm.com> <20220323162257.GC3248686@p14s> <4ef77445-b58d-a71a-0ddc-70e308ea99c8@arm.com> <20220413170844.GA547134@p14s> From: James Clark In-Reply-To: <20220413170844.GA547134@p14s> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220414_015724_472052_655EF948 X-CRM114-Status: GOOD ( 15.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 13/04/2022 18:08, Mathieu Poirier wrote: > On Mon, Mar 28, 2022 at 11:41:48AM +0100, James Clark wrote: >> >> >> On 23/03/2022 16:22, Mathieu Poirier wrote: >>> On Fri, Mar 04, 2022 at 05:18:57PM +0000, James Clark wrote: >>>> Changes since v2: >>>> * Implement Mike's suggestion of not having _SHIFT and using the existing >>>> FIELD_GET and FIELD_PREP methods. >>>> * Dropped the change to add the new REG_VAL macro because of the above. >>>> * FIELD_PREP could be used in some trivial cases, but in some cases the >>>> shift is still required but can be calculated with __bf_shf >>>> * Improved the commit messages. >>>> * The change is still binary equivalent, but requires an extra step >>>> mentioned at the end of this cover letter. >>>> >>>> Applies to coresight/next 3619ee28488 >>>> Also available at https://gitlab.arm.com/linux-arm/linux-jc/-/tree/james-cs-register-refactor-v3 >>>> >>>> To check for binary equivalence follow the same steps in the cover letter >>>> of v2, but apply the following change to coresight-priv.h. This is because >>>> the existing version of the macros wrap the expression in a new scope {} >>>> that flips something in the compiler: >>>> >>>> #undef FIELD_GET >>>> #define FIELD_GET(_mask, _reg) (((_reg) & (_mask)) >> __bf_shf(_mask)) >>>> #undef FIELD_PREP >>>> #define FIELD_PREP(_mask, _val) (((_val) << __bf_shf(_mask)) & (_mask)) >>>> >>>> Thanks >>>> James >>>> >>>> James Clark (15): >>>> coresight: etm4x: Cleanup TRCIDR0 register accesses >>>> coresight: etm4x: Cleanup TRCIDR2 register accesses >>>> coresight: etm4x: Cleanup TRCIDR3 register accesses >>>> coresight: etm4x: Cleanup TRCIDR4 register accesses >>>> coresight: etm4x: Cleanup TRCIDR5 register accesses >>>> coresight: etm4x: Cleanup TRCCONFIGR register accesses >>>> coresight: etm4x: Cleanup TRCEVENTCTL1R register accesses >>>> coresight: etm4x: Cleanup TRCSTALLCTLR register accesses >>>> coresight: etm4x: Cleanup TRCVICTLR register accesses >>>> coresight: etm3x: Cleanup ETMTECR1 register accesses >>>> coresight: etm4x: Cleanup TRCACATRn register accesses >>>> coresight: etm4x: Cleanup TRCSSCCRn and TRCSSCSRn register accesses >>>> coresight: etm4x: Cleanup TRCSSPCICRn register accesses >>>> coresight: etm4x: Cleanup TRCBBCTLR register accesses >>>> coresight: etm4x: Cleanup TRCRSCTLRn register accesses >>>> >>>> .../coresight/coresight-etm3x-core.c | 2 +- >>>> .../coresight/coresight-etm3x-sysfs.c | 2 +- >>>> .../coresight/coresight-etm4x-core.c | 136 +++++-------- >>>> .../coresight/coresight-etm4x-sysfs.c | 180 +++++++++--------- >>>> drivers/hwtracing/coresight/coresight-etm4x.h | 122 ++++++++++-- >>>> 5 files changed, 244 insertions(+), 198 deletions(-) >>> >>> I am done reviewing this set. I will wait until rc1 or rc2 before moving >>> forward. If there are other comments needing a respin then I will wait for the >>> next revision. Otherwise I will apply this one after correcting the extra lines >>> at the end of patch 15. >>> >> >> Thanks for the review! >> > > I have applied this set. Thanks Mathieu > >>> Thanks, >>> Mathieu >>> >>>> >>>> -- >>>> 2.28.0 >>>> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel