From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Eddie James" <eajames@linux.ibm.com>, linux-aspeed@lists.ozlabs.org
Cc: Joel Stanley <joel@jms.id.au>, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node
Date: Mon, 17 Feb 2020 10:22:57 +1030 [thread overview]
Message-ID: <b4582178-9b9d-494e-a458-d5576b4e0266@www.fastmail.com> (raw)
In-Reply-To: <1581363147-19310-2-git-send-email-eajames@linux.ibm.com>
On Tue, 11 Feb 2020, at 06:02, Eddie James wrote:
> The node was defined with a unit address but had no reg property,
> resulting in a warning. Add a reg property for consistency to fix the
> warning.
>
> Signed-off-by: Eddie James <eajames@linux.ibm.com>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> arch/arm/boot/dts/aspeed-g5.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 569f9d7..9db7bde 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -225,6 +225,7 @@
> scu_ic: interrupt-controller@18 {
> #interrupt-cells = <1>;
> compatible = "aspeed,ast2500-scu-ic";
> + reg = <0x18 0x4>;
> interrupts = <21>;
> interrupt-controller;
> };
> --
> 1.8.3.1
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-16 23:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-10 19:32 [PATCH v2 0/2] ARM: dts: aspeed: Fix SCU IRQ controller node addresses Eddie James
2020-02-10 19:32 ` [PATCH v2 1/2] ARM: dts: aspeed: ast2500: Fix SCU IRQ controller node Eddie James
2020-02-16 23:52 ` Andrew Jeffery [this message]
2020-02-10 19:32 ` [PATCH v2 2/2] ARM: dts: aspeed: ast2600: Fix SCU IRQ controller nodes Eddie James
2020-02-16 23:54 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4582178-9b9d-494e-a458-d5576b4e0266@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=eajames@linux.ibm.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).