From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V9 6/9] vfio: platform: call _RST method when using ACPI
Date: Fri, 15 Jul 2016 21:09:33 -0400 [thread overview]
Message-ID: <b46984d2-25b4-9d3b-394b-b0baf92bbf01@codeaurora.org> (raw)
In-Reply-To: <20160714160439.5bafca73@t450s.home>
On 7/14/2016 6:04 PM, Alex Williamson wrote:
>> +static inline
>> > +bool vfio_platform_acpi_has_reset(struct vfio_platform_device *vdev)
>> > +{
>> > +#ifdef CONFIG_ACPI
>> > + struct device *dev = vdev->device;
>> > + acpi_handle handle = ACPI_HANDLE(dev);
>> > +
>> > + return acpi_has_method(handle, "_RST");
>> > +#else
>> > + return false;
>> > +#endif
>> > +}
> What exactly is the rationale for making these inline? Clearly reset
> is not a performance relevant path. Thanks,
>
> Alex
>
It is remaining from the previous stub functions which were inline. I'll get rid
of the inlines.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-07-16 1:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 2:06 [PATCH V9 0/9] vfio, platform: add ACPI support Sinan Kaya
2016-07-14 2:06 ` [PATCH V9 1/9] vfio: platform: rename reset function Sinan Kaya
2016-07-14 2:06 ` [PATCH V9 2/9] vfio: platform: move reset call to a common function Sinan Kaya
2016-07-14 2:06 ` [PATCH V9 3/9] vfio: platform: determine reset capability Sinan Kaya
2016-07-14 2:06 ` [PATCH V9 4/9] vfio: platform: add support for ACPI probe Sinan Kaya
2016-07-14 21:41 ` Alex Williamson
2016-07-16 1:27 ` Sinan Kaya
2016-07-18 17:32 ` Alex Williamson
2016-07-18 21:23 ` Sinan Kaya
2016-07-14 2:06 ` [PATCH V9 5/9] vfio: platform: add extra debug info argument to call reset Sinan Kaya
2016-07-14 2:06 ` [PATCH V9 6/9] vfio: platform: call _RST method when using ACPI Sinan Kaya
2016-07-14 22:04 ` Alex Williamson
2016-07-16 1:09 ` Sinan Kaya [this message]
2016-07-14 2:06 ` [PATCH V9 7/9] vfio, platform: make reset driver a requirement by default Sinan Kaya
2016-07-14 22:24 ` Alex Williamson
2016-07-16 1:07 ` Sinan Kaya
2016-07-14 2:06 ` [PATCH V9 8/9] vfio: platform: check reset call return code during open Sinan Kaya
2016-07-14 2:06 ` [PATCH V9 9/9] vfio: platform: check reset call return code during release Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b46984d2-25b4-9d3b-394b-b0baf92bbf01@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).